Re: RFR: 8334137: Marlin: replace sun.misc.Unsafe memory access methods with FFM [v8]

2025-06-11 Thread Laurent Bourgès
On Wed, 11 Jun 2025 16:54:21 GMT, Kevin Rushforth wrote: >> PR to replace the use of sun.misc.Unsafe memory access methods in the Marlin >> rasterizer with FFM. >> >> I broke this up into the following commits. The bulk of the work is in the >> first two: >> >> 1. Encapsulate all off-heap acc

Re: RFR: 8334137: Marlin: replace sun.misc.Unsafe memory access methods with FFM

2025-06-10 Thread Laurent Bourgès
On Mon, 9 Jun 2025 22:09:44 GMT, Kevin Rushforth wrote: > > > I'd looked at that but it was not obvious. And it definitely is not > > > obvious that it will be the same thread that initialises the > > > MaskMarlinAlphaConsumer.java class > > > > Yes, I see what you are saying. The `ALPHA_MASK_

Re: RFR: 8334137: Marlin: replace sun.misc.Unsafe memory access methods with FFM [v7]

2025-06-10 Thread Laurent Bourgès
On Tue, 10 Jun 2025 15:31:22 GMT, Kevin Rushforth wrote: >> PR to replace the use of sun.misc.Unsafe memory access methods in the Marlin >> rasterizer with FFM. >> >> I broke this up into the following commits. The bulk of the work is in the >> first two: >> >> 1. Encapsulate all off-heap acc

Re: RFR: 8334137: Marlin: replace sun.misc.Unsafe memory access methods with FFM [v6]

2025-06-09 Thread Laurent Bourgès
On Mon, 9 Jun 2025 17:55:21 GMT, Kevin Rushforth wrote: >> PR to replace the use of sun.misc.Unsafe memory access methods in the Marlin >> rasterizer with FFM. >> >> I broke this up into the following commits. The bulk of the work is in the >> first two: >> >> 1. Encapsulate all off-heap acce

Re: RFR: 8334137: Marlin: replace sun.misc.Unsafe memory access methods with FFM [v5]

2025-06-09 Thread Laurent Bourgès
On Mon, 9 Jun 2025 15:13:49 GMT, Kevin Rushforth wrote: >> PR to replace the use of sun.misc.Unsafe memory access methods in the Marlin >> rasterizer with FFM. >> >> I broke this up into the following commits. The bulk of the work is in the >> first two: >> >> 1. Encapsulate all off-heap acce

Re: RFR: 8334137: Marlin: replace sun.misc.Unsafe memory access methods with FFM

2025-06-06 Thread Laurent Bourgès
On Wed, 21 May 2025 14:07:28 GMT, Kevin Rushforth wrote: >> PR to replace the use of sun.misc.Unsafe memory access methods in the Marlin >> rasterizer with FFM. >> >> I broke this up into the following commits. The bulk of the work is in the >> first two: >> >> 1. Encapsulate all off-heap acc

Re: RFR: 8334137: Marlin: replace sun.misc.Unsafe memory access methods with FFM

2025-06-06 Thread Laurent Bourgès
On Wed, 21 May 2025 13:24:32 GMT, Kevin Rushforth wrote: > PR to replace the use of sun.misc.Unsafe memory access methods in the Marlin > rasterizer with FFM. > > I broke this up into the following commits. The bulk of the work is in the > first two: > > 1. Encapsulate all off-heap access in

Re: Possible mistakes in com.sun.javafx.geom.AreaOp

2024-11-30 Thread Laurent Bourgès
Probably derived from java.awt.Area: https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/java/awt/geom/Area.java Le sam. 30 nov. 2024, 17:59, Nir Lisker a écrit : > I agree with your type analysis. However, I'm hesitant to change the logic > in regarding 'numedges' without

Re: RFR: 8342456: Remove calls to doPrivileged in javafx.graphics/other [v2]

2024-11-01 Thread Laurent Bourgès
On Thu, 31 Oct 2024 17:11:36 GMT, Kevin Rushforth wrote: >> modules/javafx.graphics/src/main/java/com/sun/marlin/MarlinProperties.java >> line 271: >> >>> 269: >>> 270: // system property utilities >>> 271: @SuppressWarnings("removal") >> >> really, this should be in Utils. > > Unrela

Re: RFR: 8342456: Remove calls to doPrivileged in javafx.graphics/other [v2]

2024-11-01 Thread Laurent Bourgès
On Thu, 31 Oct 2024 14:09:52 GMT, Lukasz Kostyra wrote: >> This PR removes uses of `AccessControler.doPrivileged()` from >> `javafx.graphics` package. All uses of `doPrivileged()` were removed >> _excluding_ `com.sun.javafx.tk` and `com.sun.ui.glass` subpackages - those >> are handled by [JDK-

Integrated: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0

2024-02-06 Thread Laurent Bourgès
On Wed, 24 Jan 2024 14:55:21 GMT, Laurent Bourgès wrote: > Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java This pull request has now been integrated. Changeset: 172c491d Author: Laurent Bourgès URL: https://git.openjdk.org/jfx/com

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v6]

2024-02-06 Thread Laurent Bourgès
> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java Laurent Bourgès has updated the pull request incrementally with one additional commit since the last revision: minor cleanup to simplify test and fixed imports - Changes: - all: https://git.openjdk.org/

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v5]

2024-02-05 Thread Laurent Bourgès
> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java Laurent Bourgès has updated the pull request incrementally with one additional commit since the last revision: improved rendez-vous to collect stderr - Changes: - all: https://git.openjdk.org/jfx/pull/1

Re: RFR: 8325154: resizeColumnToFitContent is slower than it needs to be

2024-02-05 Thread Laurent Bourgès
On Mon, 5 Feb 2024 09:45:25 GMT, Marius Hanl wrote: > A side comment: the default implementation of resizeColumnToFitContent() is > to iterate over all the rows, and I think this is not right. The UI locks up > if the table has, let's say, 10,000,000 rows. I think in this case it should > inst

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v4]

2024-02-02 Thread Laurent Bourgès
> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java Laurent Bourgès has updated the pull request incrementally with one additional commit since the last revision: fixed tests thanks to + copyright years - Changes: - all: https://git.openjdk.org/jfx/pull/1

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v3]

2024-01-31 Thread Laurent Bourgès
On Wed, 31 Jan 2024 18:40:29 GMT, Kevin Rushforth wrote: >> Laurent Bourgès has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed copyright years of modified files + fixed comments in >> DMarlinPrismUtils

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v3]

2024-01-31 Thread Laurent Bourgès
On Tue, 30 Jan 2024 12:52:09 GMT, Kevin Rushforth wrote: >> Tests in BidirectionalBindingTest with following exception. (Note: This was >> during the first JavaFX pre-submit test for this PR) >> >> BidirectionalBindingTest > [0] > testDoubleBrokenBind[0] STANDARD_ERROR >> Exception in threa

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v3]

2024-01-30 Thread Laurent Bourgès
On Mon, 29 Jan 2024 21:29:31 GMT, Laurent Bourgès wrote: >> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java > > Laurent Bourgès has updated the pull request incrementally with one > additional commit since the last revision: > > fixed copyright ye

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v3]

2024-01-29 Thread Laurent Bourgès
On Mon, 29 Jan 2024 21:29:31 GMT, Laurent Bourgès wrote: >> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java > > Laurent Bourgès has updated the pull request incrementally with one > additional commit since the last revision: > > fixed copyright ye

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v3]

2024-01-29 Thread Laurent Bourgès
> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java Laurent Bourgès has updated the pull request incrementally with one additional commit since the last revision: fixed copyright years of modified files + fixed comments in DMarlinPrismUtils - Changes: -

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v2]

2024-01-25 Thread Laurent Bourgès
On Thu, 25 Jan 2024 17:16:51 GMT, Laurent Bourgès wrote: >> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java > > Laurent Bourgès has updated the pull request incrementally with one > additional commit since the last revision: > > fixed test package

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v2]

2024-01-25 Thread Laurent Bourgès
> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java Laurent Bourgès has updated the pull request incrementally with one additional commit since the last revision: fixed test package - Changes: - all: https://git.openjdk.org/jfx/pull/1348/files - new: ht

RFR: JDK-8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 + minor syntax fixes (merge with latest MarlinFX)

2024-01-24 Thread Laurent Bourgès
Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java - Commit messages: - JDK-8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 + minor syntax fixes (merge with latest MarlinFX) Changes: https://git.openjdk.org/jfx/pull/1348/files Webrev: https://we

Re: Enhance javafx Canvas API

2023-02-12 Thread Laurent Bourgès
oint(), restoreToCount() should be added to GraphicsContext API... Cheers, Laurent Le ven. 3 févr. 2023, 23:31, Laurent Bourgès a écrit : > Hi, > > While working with skia & jfree's skijaGraphics2D wrapper, I observed skia > offers nice methods in SkCanvas missing in javafx

Enhance javafx Canvas API

2023-02-03 Thread Laurent Bourgès
Hi, While working with skia & jfree's skijaGraphics2D wrapper, I observed skia offers nice methods in SkCanvas missing in javafx Canvas/GraphicsContext to deal with save/restore state: - int getSaveCount () Returns the number of saved states, each containing: SkMatrix and clip. - void restoreT

Integrated: 8287604: Update MarlinFX to 0.9.4.6

2022-08-29 Thread Laurent Bourgès
On Wed, 17 Nov 2021 22:05:25 GMT, Laurent Bourgès wrote: > Changelog for this MarlinFX 0.9.4.6 release: > > The Marlin-renderer 0.9.4.6 release provides one bug fix in Stroker: skip > repeated endpoint to preserve mitter orientation: see JDK-8264999, > https://bugs.openjdk

Re: RFR: 8287604: Update MarlinFX to 0.9.4.6 [v6]

2022-08-17 Thread Laurent Bourgès
On Tue, 16 Aug 2022 21:48:37 GMT, Kevin Rushforth wrote: >> Laurent Bourgès has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed dpqs javadoc + tests (setupOnce) > > modules/javafx.graphic

Re: RFR: 8287604: Update MarlinFX to 0.9.4.6 [v2]

2022-08-17 Thread Laurent Bourgès
On Thu, 13 Jan 2022 08:35:08 GMT, Johan Vos wrote: >> Laurent Bourgès has updated the pull request incrementally with one >> additional commit since the last revision: >> >> added test for huge polygon coords > > Building and testing works, I am looking into

Re: RFR: 8287604: Update MarlinFX to 0.9.4.6 [v6]

2022-08-13 Thread Laurent Bourgès
On Sat, 13 Aug 2022 13:24:30 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.6 release: >> >> The Marlin-renderer 0.9.4.6 release provides one bug fix in Stroker: skip >> repeated endpoint to preserve mitter orientation: see JDK-8264999, >> https

Re: RFR: 8287604: Update MarlinFX to 0.9.4.6 [v6]

2022-08-13 Thread Laurent Bourgès
oslavskiy that provided me up-to-date DPQS > 19.05 with many variants, improving almost-sorted datasets. We are > collaborating to provide a complete Sort framework (15 algorithms, many > various datasets, JMH benchmarks) publicly on github: > see https://github.com/bourgesl/nearly-o

Re: RFR: 8287604: Update MarlinFX to 0.9.4.6 [v5]

2022-08-10 Thread Laurent Bourgès
On Tue, 9 Aug 2022 14:52:12 GMT, Kevin Rushforth wrote: >> Laurent Bourgès has updated the pull request incrementally with one >> additional commit since the last revision: >> >> upgraded to 0.9.4.6 (no repeated lineTo) + fixed tests > > modules/javafx.graphic

Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v3]

2022-08-09 Thread Laurent Bourgès
On Thu, 4 Aug 2022 23:01:37 GMT, Kevin Rushforth wrote: >> Laurent Bourgès has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed pixel color tests on hi-dpi > > I did a quick skim of the DPQS class, enou

Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v5]

2022-08-08 Thread Laurent Bourgès
cial Thanks to Vladimir Yaroslavskiy that provided me up-to-date DPQS > 19.05 with many variants, improving almost-sorted datasets. We are > collaborating to provide a complete Sort framework (15 algorithms, many > various datasets, JMH benchmarks) publicly on github: > see https://github.co

Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v4]

2022-08-08 Thread Laurent Bourgès
cial Thanks to Vladimir Yaroslavskiy that provided me up-to-date DPQS > 19.05 with many variants, improving almost-sorted datasets. We are > collaborating to provide a complete Sort framework (15 algorithms, many > various datasets, JMH benchmarks) publicly on github: > see https://github.co

Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v3]

2022-08-05 Thread Laurent Bourgès
On Thu, 4 Aug 2022 23:01:37 GMT, Kevin Rushforth wrote: > I did a quick skim of the DPQS class, enough to know that code review is > unlikely to spot the kind of subtle bugs that such code might have. So my > main question is around testing of DQPS itself. How much standalone testing > has bee

Re: Security Manager deprecation in JDK 17

2022-07-30 Thread Laurent Bourgès
Hi, I will fix the MarlinFX code myself, as I am proposing an openjfx patch, that has already @SuppressWarning lines from jdk17. See https://github.com/openjdk/jfx/pull/674 Kevin will review it soon, so I propose you to ignore changes on your side to avoid conflicts in modules/javafx.graphics/src

Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v3]

2022-07-29 Thread Laurent Bourgès
On Tue, 12 Jul 2022 23:05:06 GMT, Kevin Rushforth wrote: >> Laurent Bourgès has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed pixel color tests on hi-dpi > > At this point, due to time constraints, we

Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v3]

2022-07-14 Thread Laurent Bourgès
On Thu, 7 Jul 2022 22:46:53 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 &

Re: CFV: New OpenJFX Committer: Michael Strauß

2022-07-09 Thread Laurent Bourgès
Vote: YES Congratulations, michael ! Le sam. 9 juil. 2022, 07:53, Ajit Ghaisas a écrit : > Vote : YES > > Regards, > Ajit > > > On 08-Jul-2022, at 6:01 PM, Kevin Rushforth > wrote: > > > > I hereby nominate Michael Strauß [1] to OpenJFX Committer. > > > > Michael is an OpenJFX community member

Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v3]

2022-07-08 Thread Laurent Bourgès
On Thu, 7 Jul 2022 22:46:53 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 &

Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v3]

2022-07-08 Thread Laurent Bourgès
On Fri, 8 Jul 2022 18:02:44 GMT, Kevin Rushforth wrote: >> Yes, the tests now all pass on my MacBook Pro which has a retina display. >> >>> I will merge with my latest marlin code asap = 0.9.4.6 (2 more bugs fixed), >>> low risk (few lines) if you agree. >> >> Yes, that would be fine. Let's ch

Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v3]

2022-07-08 Thread Laurent Bourgès
cial Thanks to Vladimir Yaroslavskiy that provided me up-to-date DPQS > 19.05 with many variants, improving almost-sorted datasets. We are > collaborating to provide a complete Sort framework (15 algorithms, many > various datasets, JMH benchmarks) publicly on github: > see https://github.co

Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v3]

2022-07-08 Thread Laurent Bourgès
On Thu, 7 Jul 2022 22:46:53 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 &