Re: RFR: 8361648: Update Glib to 2.84.3

2025-08-01 Thread Joeri Sykora
On Tue, 29 Jul 2025 21:02:20 GMT, Alexander Matveev wrote: > - GLib updated to 2.84.3. > - Tested on all platforms. > - No other changes are done. I've successfully ran a build on all platforms. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/

Re: RFR: 8359387: Bump minimum JDK version for JavaFX to JDK 23 [v2]

2025-07-08 Thread Joeri Sykora
On Tue, 8 Jul 2025 20:29:59 GMT, Kevin Rushforth wrote: >> This PR bumps the minimum version of the JDK needed to run JavaFX to JDK 23. >> >> In order for JavaFX to be able to use more recent JDK features, we should >> increase the minimum version of the JDK that can run the latest JavaFX. >>

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v3]

2025-06-24 Thread Joeri Sykora
On Mon, 23 Jun 2025 11:01:59 GMT, Ambarish Rapte wrote: >> ### Description >> This is the implementation of new graphics rendering pipeline for JavaFX >> using Metal APIs on MacOS. >> We released two Early Access (EA) builds and have reached a stage where it >> is ready to be integrated. >> Def

Re: RFR: 8358802: Update boot JDK to 24.0.1 [v2]

2025-06-18 Thread Joeri Sykora
On Tue, 17 Jun 2025 22:50:13 GMT, Ambarish Rapte wrote: >> Support for JDK 24 was added in Gradle 8.14.2. Hence update bootjdk to JDK >> 24.0.1 and gradle to 8.14.2 >> No changes to gradle build script were needed for this upgrade. > > Ambarish Rapte has updated the pull request with a new targe

Re: RFR: 8359387: Bump minimum JDK version for JavaFX to JDK 23

2025-06-18 Thread Joeri Sykora
On Fri, 13 Jun 2025 17:57:43 GMT, Kevin Rushforth wrote: > This PR bumps the minimum version of the JDK needed to run JavaFX to JDK 23. > > In order for JavaFX to be able to use more recent JDK features, we should > increase the minimum version of the JDK that can run the latest JavaFX. > Addi

Re: RFR: 8359396: [Linux] Require Gtk3 >= 3.20 for glass-gtk [v2]

2025-06-17 Thread Joeri Sykora
On Sun, 15 Jun 2025 21:12:45 GMT, Thiago Milczarek Sayao wrote: >> Upgrade the minimum required GTK version for JavaFX to GTK 3.20 to enable >> modern features and better Linux desktop integration. >> >> JavaFX currently depends on GTK 3.8, >> [released](https://mail.gnome.org/archives/gtk-de

Re: RFR: 8358770: incubator.richtext pom missing dependency on incubator.input

2025-06-16 Thread Joeri Sykora
On Fri, 6 Jun 2025 15:27:33 GMT, Kevin Rushforth wrote: > This PR adds a missing maven dependency for `jfx.incubator.richtext` on the > `jfx.incubator.input` module. The dependency is correctly present in the > `module-info.java` of `jfx.incubator.richtext` as well as the gradle > dependency f

Re: RFR: 8354986: Update to Visual Studio 2022 version 17.13.2 on Windows [v2]

2025-05-22 Thread Joeri Sykora
On Thu, 22 May 2025 16:53:07 GMT, Kevin Rushforth wrote: >> This PR updates the compiler on Windows to Visual Studio 2022 17.13.2 (from >> 17.6.5) to match JDK 25. >> >> I ran a full headless and headful test run, including building media and >> WebKit. All tests pass. >> >> NOTE: There is a

Re: RFR: 8354986: Update to Visual Studio 2022 version 17.13.2 on Windows

2025-05-22 Thread Joeri Sykora
On Wed, 14 May 2025 23:20:42 GMT, Kevin Rushforth wrote: > This PR updates the compiler on Windows to Visual Studio 2022 17.13.2 (from > 17.6.5) to match JDK 25. > > I ran a full headless and headful test run, including building media and > WebKit. All tests pass. > > NOTE: There is a compati

Re: RFR: 8355740: Update to Xcode 15.4 on macOS

2025-05-21 Thread Joeri Sykora
On Mon, 28 Apr 2025 18:41:09 GMT, Kevin Rushforth wrote: > This PR updates the compiler on macOS to Xcode 15.4 (from 14.3.1) to match > JDK 25. > > I ran a full headless and headful test run, including building media and > WebKit. No issues were found. > > NOTE: Xcode 15.4 requires macOS 14 S

Re: RFR: 8354875: Update to GCC 14.2.0 on Linux

2025-04-30 Thread Joeri Sykora
On Thu, 17 Apr 2025 18:17:21 GMT, Kevin Rushforth wrote: > This PR updates the compiler on Linux to GCC 14.2.0 (from 13.2.0) to match > JDK 25. > > I ran a full headless and headful test run, including building media and > WebKit, on the following: > > * [x] Oracle Linux 8 (our production bui

Re: RFR: 8354876: Update SQLite to 3.49.1

2025-04-23 Thread Joeri Sykora
On Fri, 18 Apr 2025 12:03:22 GMT, Jay Bhaskar wrote: > The upgrade is required to address several known issues from the previous > version to improve stability and performance. The builds ran successfully with these changes. - Marked as reviewed by sykora (Author). PR Review: htt

Re: RFR: 8352162: Update libxml2 to 2.13.8 [v9]

2025-04-23 Thread Joeri Sykora
On Tue, 22 Apr 2025 10:32:41 GMT, Jay Bhaskar wrote: >> The upgrade is required to address several known issues from the previous >> version to improve stability and performance. > > Jay Bhaskar has updated the pull request incrementally with one additional > commit since the last revision: >

Re: [jfx24u] RFR: 8354182: Create release notes for JavaFX 24.0.1

2025-04-14 Thread Joeri Sykora
On Wed, 9 Apr 2025 23:17:49 GMT, Kevin Rushforth wrote: > Release notes for JavaFX 24.0.1. > > Notes to reviewers: > > I used the following filter to pick the issues: > > https://bugs.openjdk.org/issues/?filter=47358 > > The original filter, with the backport IDs, is here: > > https://bugs.o

Re: RFR: 8349924: Additional WebKit 620.1 fixes from WebKitGTK 2.46.6 [v2]

2025-02-24 Thread Joeri Sykora
On Mon, 24 Feb 2025 06:49:13 GMT, Jay Bhaskar wrote: >> WebkitGTK 2.46.6 has additional fixes for crash and rendering issue, the >> crash fix is related to Skia CPU rendering which does not apply to JavaFX >> Webkit. >> This patch has been tested on Jenkins and there is no side effects >> int

Re: RFR: 8340322: Update WebKit to 620.1

2025-02-11 Thread Joeri Sykora
On Mon, 10 Feb 2025 15:27:49 GMT, Jay Bhaskar wrote: > Webkit JavaFx upgrade from 619.1 to 620.1 > Build is verified in mac , windows and linux. Sanity testing looks fine. No > issues seen, except one observed CanvasPattern test where it works only on > Linux but failed on Mac/Windows (WIP). >

Re: RFR: 8337960: Improve performance of mfwrapper by reusing GStreamer media buffers for decoded video

2025-02-10 Thread Joeri Sykora
On Wed, 5 Feb 2025 03:00:17 GMT, Alexander Matveev wrote: > - Added new class `CMFGSTBuffer` which can allocate memory internally or > provide GStreamer allocated memory to Media Foundation. > - Added `GstBufferPool` to limit allocation of output buffers used for > rendering (memory will not be

Re: RFR: 8346228: Update GStreamer to 1.24.10 [v2]

2025-01-13 Thread Joeri Sykora
On Fri, 10 Jan 2025 21:24:25 GMT, Alexander Matveev wrote: >> - Updated GStreamer to 1.24.10 and Glib to 2.82.4. >> - Testing done on all platforms with all supported formats. >> - Removed gstdiscoverer.c. We do not use code from this file. >> - No other changes or bug fixes are done. > > Alexan

Re: RFR: 8345136: Update JDK_DOCS property to point to JDK 23 docs [v2]

2024-12-17 Thread Joeri Sykora
On Tue, 17 Dec 2024 19:29:17 GMT, Kevin Rushforth wrote: >> Update the docs bundle to point to the JDK 23 docs (we're currently pointing >> to JDK 21). >> >> I will need to also download and host a zip bundle and add its checksum to >> gradle/verification-metadata.xml to avoid breaking our int

Re: RFR: 8341920: Intermittent WebKit build failure on Windows generating PDB files in 619.1

2024-10-13 Thread Joeri Sykora
On Fri, 11 Oct 2024 17:22:02 GMT, Hima Bindu Meda wrote: > Disabled the pdb file generation in order to resolve the build failure. > Sanity testing looks fine. Verified build on windows, mac and linux. I ran a test and all builds succeeded. - Marked as reviewed by sykora (Author).

Re: RFR: 8341164: Update boot JDK to 23

2024-10-03 Thread Joeri Sykora
On Wed, 2 Oct 2024 17:09:59 GMT, Ambarish Rapte wrote: > Update the boot JDK to version 23. > > Since Gradle 8.9 does not support JDK 23, it is necessary to upgrade Gradle > to the latest release, version 8.10.2, which supports JDK 23. > It is advised to upgrade directly to Gradle 8.10.2 rathe

Re: RFR: 8340980: Cannot build on Windows ARM

2024-09-26 Thread Joeri Sykora
On Thu, 26 Sep 2024 01:45:14 GMT, Martin Fox wrote: > Restored some behavior in genVSproperties that enabled ARM builds and > cross-compilation on Windows. Verified that I can build on ARM but have no > way of testing other architectures. The change looks good to me. I've done a build on our b

Re: RFR: 8340208: Additional WebKit 619.1 fixes from WebKitGTK 2.44.4

2024-09-17 Thread Joeri Sykora
On Mon, 16 Sep 2024 18:45:45 GMT, Hima Bindu Meda wrote: > Updated additional webkit-619.1 fixes from webkitgtk-2.44.4. Build is > successful on all platforms.No issues seen Builds and tests ran fine. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx

Re: RFR: 8338701: Provide media support for libavcodec version 61

2024-08-30 Thread Joeri Sykora
On Thu, 29 Aug 2024 21:02:41 GMT, Alexander Matveev wrote: > - Added support for libavcodec 61. > - Updated AV plugins to use new APIs instead of APIs which were removed in 61. > - We still using some deprecated APIs. > - `reordered_opaque` replacement exist in 61 which is used to pass user data

Re: RFR: 8339212: gradle downloads x64 binary of SWT on Linux/aarch64 [v2]

2024-08-30 Thread Joeri Sykora
On Thu, 29 Aug 2024 14:43:39 GMT, ANUPAM DEV wrote: >> Hi, >> >> I have updated the name of the SWT.jar that needs to be downloaded during >> the build process for Linux aarch64. >> from: >> IS_LINUX ? "org.eclipse.swt.gtk.linux.x86_64_3.124.200.v20231113-1355" : >> "" >> >> to: >> IS

Re: RFR: 8338307 : Additional WebKit 619.1 fixes from WebKitGTK 2.44.3

2024-08-23 Thread Joeri Sykora
On Wed, 21 Aug 2024 09:53:24 GMT, Hima Bindu Meda wrote: > Updated additonal fixes from webkit-2.44.3. Verified build on all platforms. > No issue seen. Builds and tests were successful on our infrastructure. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk

Re: RFR: 8336940: Update GStreamer to 1.24.6 [v2]

2024-08-22 Thread Joeri Sykora
On Wed, 21 Aug 2024 21:36:52 GMT, Alexander Matveev wrote: >> - Updated GStreamer to 1.24.6 and Glib to 2.80.4. >> - Testing done on all platforms with all supported formats. >> - Removed gstpluginloader.c. This file contains additional plugin loading >> mechanism which we do not use. Latest GS

Re: RFR: 8336632: Update Gradle to 8.9 [v3]

2024-08-21 Thread Joeri Sykora
On Tue, 20 Aug 2024 16:53:09 GMT, Ambarish Rapte wrote: >> Gradle 8.8 released on May 31, 2024, supports JDK 22. >> On Jul 11, 2024, gradle 8.9 was released too, so we can update to the latest >> gradle 8.9 >> >> This gradle update is required in order to update the boot jdk to 22.0.2. >> The

Re: RFR: 8338306: WebView Drag and Drop fails with WebKit 619.1 [v2]

2024-08-20 Thread Joeri Sykora
On Tue, 20 Aug 2024 14:04:29 GMT, Hima Bindu Meda wrote: >> This commit resolves drag and drop issue observed with Webkit-619.1. >> Verified build on all platforms. No issue seen > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision:

Re: RFR: 8336938: Update libFFI to 3.4.6 [v2]

2024-08-19 Thread Joeri Sykora
On Tue, 13 Aug 2024 19:04:09 GMT, Alexander Matveev wrote: >> - libFFI updated to 3.4.6. >> - No additional changes are done. >> - Tested on Windows, macOS and Linux with all supported formats. > > Alexander Matveev has updated the pull request incrementally with one > additional commit since t

Re: RFR: 8328994 : Update WebKit to 619.1

2024-07-16 Thread Joeri Sykora
On Fri, 12 Jul 2024 08:29:34 GMT, Hima Bindu Meda wrote: > This PR updates Webkit to v619.1. > Build is verified in mac , windows and linux. Sanity testing looks fine. No > issues seen. All builds succeeded. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.

Re: RFR: 8326712: Robot tests fail on XWayland

2024-06-28 Thread Joeri Sykora
On Wed, 26 Jun 2024 11:25:37 GMT, Alexander Zvegintsev wrote: > Most of the headful test failures on XWayland are due to screen capture is > not working. > > Wayland, unlike X11, does not allow arbitrary applications to capture the > screen contents directly. > Instead, screen capture functio

Re: RFR: 8331765: Websocket callbacks are not executed after WebKit 617.1 update [v4]

2024-06-21 Thread Joeri Sykora
On Fri, 21 Jun 2024 00:07:33 GMT, Jay Bhaskar wrote: >> Issue: The Websocket Channel is broken >> Solution: The socket Provider needs a web page pointer, since the web socket >> channel source code is moved to WebkitLegacy in 617.1 for the web process >> model, it is invalid for JavaFx Webkit.

Integrated: 8333147: update maven classifier syntax to recent gradle version

2024-06-07 Thread Joeri Sykora
On Thu, 6 Jun 2024 17:35:54 GMT, Joeri Sykora wrote: > Replaces the deprecated `classifier` property with `archiveClassifier`. The > property was removed with the release of Gradle 8.0: > https://docs.gradle.org/8.0/userguide/upgrading_version_7.html#abstractarchivetask_api_cleanup

RFR: 8333147: update maven classifier syntax to recent gradle version

2024-06-06 Thread Joeri Sykora
Replaces the deprecated `classifier` property with `archiveClassifier`. The property was removed with the release of Gradle 8.0: https://docs.gradle.org/8.0/userguide/upgrading_version_7.html#abstractarchivetask_api_cleanup - Commit messages: - fix 8333147 Changes: https://git.ope

Re: JavaFX applications fail to build with Maven 3.9.7

2024-05-29 Thread Joeri Sykora
FYI, version 23-ea+20 should contain the fixed parent pom. Op wo 29 mei 2024 om 09:31 schreef Michael Hall : > > > On May 29, 2024, at 2:19 AM, Joeri Sykora wrote: > > Hi John, > > maven artifacts are generated when providing the following gradle > property: -PMAVEN_

Re: JavaFX applications fail to build with Maven 3.9.7

2024-05-29 Thread Joeri Sykora
Hi John, maven artifacts are generated when providing the following gradle property: -PMAVEN_PUBLISH=true For the actual maven publication to maven central, Gluon uses a different parent pom file, which indeed has those duplicate profile id's. We'll provide a fix that will be available from 23-ea

Re: RFR: 8332539: Update libxml2 to 2.12.7

2024-05-27 Thread Joeri Sykora
On Fri, 24 May 2024 18:18:22 GMT, Hima Bindu Meda wrote: > Updated libxml to v2.12.7. Sanity testing looks fine. No issue seen Tests are green here as well. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1464#pullrequestreview-2080216007

Re: RFR: 8331748: Update libxml2 to 2.12.6

2024-05-15 Thread Joeri Sykora
On Tue, 14 May 2024 05:21:37 GMT, Hima Bindu Meda wrote: > Updated libxml to v2.12.6. Verified build and sanity testing on all > platforms. No issue seen All tests are green here too. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1453#pullre

Re: RFR: 8329011: Update SQLite to 3.45.3

2024-05-14 Thread Joeri Sykora
On Tue, 14 May 2024 11:45:06 GMT, Hima Bindu Meda wrote: > Update SQLite to v3.45.3.Verified build on all platforms. Sanity testing > looks fine. Everything built fine. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1454#pullrequestreview-205

Re: RFR: 8324326: Update ICU4C to 74.2

2024-03-14 Thread Joeri Sykora
On Tue, 12 Mar 2024 14:45:06 GMT, Hima Bindu Meda wrote: > Updated icu to v74.2. Sanity testing looks fine. Verified build on all > platforms Builds and tests all ran fine. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1398#pullrequestreview

Re: [jfx17u] RFR: 8318387: Update GStreamer to 1.22.6 [v2]

2024-03-07 Thread Joeri Sykora
On Thu, 7 Mar 2024 14:13:18 GMT, Johan Vos wrote: >> Almost clean backport of JDK-8318386. >> The original patch contains a fix to gstaacparse.c which is not in jfx17u >> because it does not have JDK-8277309 (JDK-8277309) > > Johan Vos has updated the pull request with a new target base due to a

Re: [jfx17u] RFR: 8318614: Update WebKit to 617.1 [v2]

2024-03-07 Thread Joeri Sykora
repository. >> >> The commit being backported was authored by Hima Bindu Meda on 16 Jan 2024 >> and was reviewed by Joeri Sykora and Kevin Rushforth. >> >> Thanks! > > Johan Vos has updated the pull request with a new target base due to a merge > or a reb

Re: RFR: 8325258: Additional WebKit 617.1 fixes from WebKitGTK 2.42.5

2024-02-09 Thread Joeri Sykora
On Fri, 9 Feb 2024 17:05:53 GMT, Hima Bindu Meda wrote: > Ported changes related to webkit-2.42.5. Verified build on all platforms. > Sanity testing looks fine. Builds and tests ran succesfully. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/

Re: RFR: JDK-8324337: Cherry-pick WebKit 617.1 stabilization fixes [v3]

2024-01-29 Thread Joeri Sykora
On Mon, 29 Jan 2024 04:24:54 GMT, Hima Bindu Meda wrote: >> Cherry-picked changes related to webkit-2.42.4.Verified build on all >> platforms. Sanity testing looks fine. > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: > > s

Re: RFR: JDK-8324337: Cherry-pick WebKit 617.1 stabilization fixes [v2]

2024-01-26 Thread Joeri Sykora
On Fri, 26 Jan 2024 14:19:53 GMT, Hima Bindu Meda wrote: >> Cherry-picked changes related to webkit-2.42.4.Verified build on all >> platforms. Sanity testing looks fine. > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: > > M

Re: RFR: 8318614: Update WebKit to 617.1

2024-01-11 Thread Joeri Sykora
On Wed, 10 Jan 2024 17:53:46 GMT, Hima Bindu Meda wrote: > This PR updates webkit to v617.1. Verified build on Mac,Windows and linux. > Sanity testing looks fine. No issues observed in HelloWebView as well All builds and tests went fine. - Marked as reviewed by sykora (Author). PR

Re: RFR: 8321434: Update Gradle to 8.5

2023-12-08 Thread Joeri Sykora
On Fri, 8 Dec 2023 00:53:56 GMT, Ambarish Rapte wrote: > Gradle 8.5.0 released on Nov 29, 2023, supports JDK 21. > We need to update Gradle to 8.5 in order to update the boot JDK. > There are not API level changes in Gradle that we need to work on, hence the > change is only Gradle version updat

Re: RFR: 8318388: Update libxslt to 1.1.39 [v2]

2023-12-04 Thread Joeri Sykora
On Thu, 30 Nov 2023 08:37:35 GMT, Hima Bindu Meda wrote: >> Updated libxslt to v1.1.39. Verified build on all platforms.No issue seen. > > Hima Bindu Meda has updated the pull request incrementally with two > additional commits since the last revision: > > - update license for libxslt > - upd

Re: RFR: 8318387: Update GStreamer to 1.22.6 [v2]

2023-11-21 Thread Joeri Sykora
On Tue, 21 Nov 2023 01:03:07 GMT, Alexander Matveev wrote: >> - GStreamer updated to 1.22.6 and GLib updated to 2.78.1. >> - Tested on all platforms with all supported media streams. >> - GStreamer 1.22.6 requires GLib 2.62.0, but since we need to support older >> GLib versions on Linux followi

Re: RFR: 8319996: Update to GCC 13.2.0 on Linux [v2]

2023-11-15 Thread Joeri Sykora
On Wed, 15 Nov 2023 12:35:50 GMT, Kevin Rushforth wrote: >> This PR updates the compiler on Linux to GCC 13.2.0 (from 12.2.0) to match >> JDK 22. >> >> I've run headless and headful tests on Ubuntu 16.04, 20.04, and 22.04. > > Kevin Rushforth has updated the pull request with a new target base

Re: RFR: 8319762: Update to Visual Studio 2022 version 17.6.5 on Windows [v2]

2023-11-14 Thread Joeri Sykora
On Tue, 14 Nov 2023 12:47:51 GMT, Kevin Rushforth wrote: >> This PR updates the compiler on Windows to Visual Studio 2022 17.6.5 (from >> 17.5.0) to match JDK 22. >> >> I've run headless and headful tests. > > Kevin Rushforth has updated the pull request with a new target base due to a > merge

Re: RFR: 8318984: Update to Xcode 14.3.1 on macOS

2023-11-14 Thread Joeri Sykora
On Mon, 13 Nov 2023 18:45:13 GMT, Kevin Rushforth wrote: > This PR updates the micro version of the compiler on macOS to 14.3.1 (from > 14.3) to match JDK 22. > > I've run headless and headful tests. Marked as reviewed by sykora (Author). - PR Review: https://git.openjdk.org/jfx/

Re: RFR: 8317508: Provide media support for libavcodec version 60

2023-10-18 Thread Joeri Sykora
On Fri, 13 Oct 2023 01:24:36 GMT, Alexander Matveev wrote: > - Added support for libavcodec version 60. > - Tested on Ubuntu 23.10 with all possible media formats. > - Changed "--disable-yasm" to "--disable-asm". "--disable-asm" disables all > assembler optimization and "--disable-yasm" only x8

Re: RFR: 8313321 : Set minimum python version in WebKit cmake scripts [v3]

2023-10-18 Thread Joeri Sykora
On Wed, 11 Oct 2023 03:58:01 GMT, Hima Bindu Meda wrote: >> Minimum version of python ,to run webkit build , on linux is set to 3.6 and >> for other platforms, minimum version of python is set to 3.8. >> >> Verified build on all platforms. No issue seen > > Hima Bindu Meda has updated the pull

Re: RFR: 8317370: JavaFX runtime version is wrong at runtime [v2]

2023-10-14 Thread Joeri Sykora
On Tue, 10 Oct 2023 16:24:42 GMT, John Neffenger wrote: >> Please review these changes to the build timestamp and to the JavaFX runtime >> version available in the system properties. > > John Neffenger has updated the pull request incrementally with one additional > commit since the last revisi

Re: RFR: 8313711: Cherry-pick WebKit 616.1 stabilization fixes [v2]

2023-08-07 Thread Joeri Sykora
On Mon, 7 Aug 2023 04:18:31 GMT, Hima Bindu Meda wrote: >> Cherry-picked commits from webkitgtk-2.40.5. >> Verified build on windows, mac and linux. Sanity testing looks fine. No >> issues seen > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the

Re: RFR: JDK-8310681: Update WebKit to 616.1 [v2]

2023-07-28 Thread Joeri Sykora
On Mon, 24 Jul 2023 12:43:57 GMT, Hima Bindu Meda wrote: >> Updated JavaFX Webkit to GTK WebKit 2.40 (616.1). >> Verified the updated version build, sanity tests and stability. No issues >> have been observed. > > Hima Bindu Meda has updated the pull request incrementally with one > additional

Re: RFR: 8308308: Update to Visual Studio 2022 version 17.5.0 on Windows [v2]

2023-06-01 Thread Joeri Sykora
On Tue, 30 May 2023 19:10:08 GMT, Kevin Rushforth wrote: >> Update the compiler on Windows to Visual Studio 2022 17.5.0. This provides >> the needed C++20 support for the next WebKit update. >> >> On Windows, the existing WebKit 615.1 build fails with Visual Studio 2022 >> 17.5.0 -- see [JDK-8

Re: RFR: 8308307: Update to gcc 12.2.0 on Linux

2023-05-30 Thread Joeri Sykora
On Sat, 20 May 2023 14:56:16 GMT, Kevin Rushforth wrote: > Update the compiler on Linux to gcc 12.2. This provides the needed C++20 > support for the next WebKit update. Marked as reviewed by sykora (Author). - PR Review: https://git.openjdk.org/jfx/pull/1141#pullrequestreview-145

Re: RFR: 8308306: Update to Xcode 14.3 on macOS [v2]

2023-05-30 Thread Joeri Sykora
On Thu, 25 May 2023 16:30:38 GMT, Kevin Rushforth wrote: >> Update the compiler on macOS to Xcode 14.3. In addition to providing the >> needed C++20 support for the next WebKit update, initial testing by the JDK >> team shows that this fixes a reproducible builds problem, so it might help >> a

Re: RFR: 8308308: Update to Visual Studio 2022 version 17.5.0 on Windows

2023-05-26 Thread Joeri Sykora
On Sat, 20 May 2023 14:58:40 GMT, Kevin Rushforth wrote: > Update the compiler on Windows to Visual Studio 2022 17.5.0. This provides > the needed C++20 support for the next WebKit update. > > On Windows, the existing WebKit 615.1 build fails with Visual Studio 2022 > 17.5.0 -- see [JDK-830374

Re: RFR: 8308308: Update to Visual Studio 2022 version 17.5.0 on Windows

2023-05-25 Thread Joeri Sykora
On Sat, 20 May 2023 14:58:40 GMT, Kevin Rushforth wrote: > Update the compiler on Windows to Visual Studio 2022 17.5.0. This provides > the needed C++20 support for the next WebKit update. > > On Windows, the existing WebKit 615.1 build fails with Visual Studio 2022 > 17.5.0 -- see [JDK-830374

Re: RFR: 8308306: Update to Xcode 14.3 on macOS

2023-05-25 Thread Joeri Sykora
On Sat, 20 May 2023 14:47:50 GMT, Kevin Rushforth wrote: > Update the compiler on macOS to Xcode 14.3. In addition to providing the > needed C++20 support for the next WebKit update, initial testing by the JDK > team shows that this fixes a reproducible builds problem, so it might help > addre

Re: RFR: 8306115 : Update libxml2 to 2.10.4

2023-04-25 Thread Joeri Sykora
On Fri, 21 Apr 2023 10:34:49 GMT, Hima Bindu Meda wrote: > Updated libxml to v2.10.4.Configured and verified on all Windows, Linux and > Mac. > Sanity testing looks fine. Builds and tests completed without issues. - Marked as reviewed by sykora (Author). PR Review: https://git.op

Re: RFR: 8286089: Intermittent WebKit build failure on macOS in JavaScriptCore

2023-04-04 Thread Joeri Sykora
On Tue, 28 Mar 2023 02:08:27 GMT, Jay Bhaskar wrote: > Issue: Error copying file (if different) from > Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_separate_header.py" > to > "modules/javafx.web/build/mac/Release/JavaScriptCcripts/builtins_generate_separate_header.py". > > Root

Re: RFR: 8282359: Intermittent WebKit build failure on Windows: C1090: PDB API call failed, error code 23 [v4]

2023-04-04 Thread Joeri Sykora
On Mon, 3 Apr 2023 18:50:57 GMT, Hima Bindu Meda wrote: >> In Jenkins Build, the intermediate failure on windows is observed due to >> crash in mspdbserv.exe, which generates Program database (.pdb) files. >> Disabled the pdb file generation in order to resolve the build failure. >> Sanity testi

Re: RFR: 8301009: Update libxml2 to 2.10.3

2023-03-16 Thread Joeri Sykora
On Tue, 14 Mar 2023 08:04:04 GMT, Hima Bindu Meda wrote: > Updated Libxml2 to v2.10.3. verfied build and sanity testing on windows, mac > and Linux platforms. > No issue observed. Building and running tests worked on windows, linux and macos. - Marked as reviewed by sykora (Author

Re: RFR: 8302684 : Cherry-pick WebKit 615.1 stabilization fixes (2)

2023-02-17 Thread Joeri Sykora
On Thu, 16 Feb 2023 19:29:26 GMT, Hima Bindu Meda wrote: > Stabilization fixes from Webkitgtk-2.38.5. > Verified drt and unit tests. No issues observed. Building and testing completed without issues. - Marked as reviewed by sykora (Author). PR: https://git.openjdk.org/jfx/pull/103

Re: RFR: 8302294 : Cherry-pick WebKit 615.1 stabilization fixes

2023-02-15 Thread Joeri Sykora
On Tue, 14 Feb 2023 18:19:17 GMT, Hima Bindu Meda wrote: > Cherry-pick stabilisation fixes till 2.38.4. > Verified unit tests and drt. No issue observed. Building and testing succeeded. - Marked as reviewed by sykora (Author). PR: https://git.openjdk.org/jfx/pull/1033

Re: RFR: JDK-8299977 : Update WebKit to 615.1 [v3]

2023-02-01 Thread Joeri Sykora
On Wed, 1 Feb 2023 04:11:48 GMT, Hima Bindu Meda wrote: >> Update JavaFX WebKit to GTK WebKit 2.38 (615.1). >> >> Verified the updated version build, sanity tests and stability. >> This does not cause any issues except one unit test failure. >> Also, there are some artifacts observed while playi

Re: RFR: JDK-8299977 : Update WebKit to 615.1 [v2]

2023-01-31 Thread Joeri Sykora
On Mon, 30 Jan 2023 15:11:20 GMT, Hima Bindu Meda wrote: >> Update JavaFX WebKit to GTK WebKit 2.38 (615.1). >> >> Verified the updated version build, sanity tests and stability. >> This does not cause any issues except one unit test failure. >> Also, there are some artifacts observed while play

Re: RFR: 8289952: Visual Studio libs msvcp140_1.dll and msvcp140_2.dll missing from build

2022-07-11 Thread Joeri Sykora
On Thu, 7 Jul 2022 23:16:12 GMT, Kevin Rushforth wrote: > On Windows platforms we redistribute the Visual Studio runtime libraries with > the JavaFX build so that JavaFX applications can run on systems that don't > have them installed already. The main C++ runtime library is `msvcp140.dll`, >