Integrated: 8323078: Incorrect length argument to g_utf8_strlen in pango.c

2024-01-08 Thread Florian Weimer
On Fri, 5 Jan 2024 17:52:03 GMT, Florian Weimer wrote: > 8323078: Incorrect length argument to g_utf8_strlen in pango.c This pull request has now been integrated. Changeset: 366b062c Author: Florian Weimer Committer: Kevin Rushforth URL: https://git.openjdk.org/jfx/com

Integrated: 8323077: C type error (incompatible function pointer) in X11GLContext.c

2024-01-08 Thread Florian Weimer
On Fri, 5 Jan 2024 17:01:25 GMT, Florian Weimer wrote: > 8323077: C type error (incompatible function pointer) in X11GLContext.c This pull request has now been integrated. Changeset: e3f2e968 Author: Florian Weimer Committer: Kevin Rushforth URL: https://git.openjdk.org/jfx/com

Re: RFR: 8323077: C type error (incompatible function pointer) in X11GLContext.c [v2]

2024-01-08 Thread Florian Weimer
On Mon, 8 Jan 2024 17:15:39 GMT, Kevin Rushforth wrote: > Thanks for addressing it as well. `glXGetProcAddress` is defined in > `glxext.h`, which we include in our sources. See [glxext.h line > 155](https://github.com/openjdk/jfx/blob/master/modules/javafx.graphics/src/main/native-prism-es2/GL/

Re: RFR: 8323077: C type error (incompatible function pointer) in X11GLContext.c [v2]

2024-01-08 Thread Florian Weimer
> 8323077: C type error (incompatible function pointer) in X11GLContext.c Florian Weimer has updated the pull request incrementally with one additional commit since the last revision: Suppress -Wpointer-sign warning - Changes: - all: https://git.openjdk.org/jfx/pull/1319/fi

Re: RFR: 8323078: Incorrect length argument to g_utf8_strlen in pango.c [v2]

2024-01-08 Thread Florian Weimer
On Fri, 5 Jan 2024 18:48:25 GMT, Kevin Rushforth wrote: >> Florian Weimer has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request co

Re: RFR: 8323078: Incorrect length argument to g_utf8_strlen in pango.c [v2]

2024-01-08 Thread Florian Weimer
> 8323078: Incorrect length argument to g_utf8_strlen in pango.c Florian Weimer has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one

Re: RFR: 8323077: C type error (incompatible function pointer) in X11GLContext.c

2024-01-08 Thread Florian Weimer
On Sat, 6 Jan 2024 16:42:19 GMT, Kevin Rushforth wrote: > Looks good. In looking at the logs from the GHA run I can see that the > warning is gone. > > I note that there is an additional warning on that same line: > > ``` > 2024-01-05T23:04:38.0399339Z > /home/runner/work/jfx/jfx/jfx/modules/

RFR: 8323078: Incorrect length argument to g_utf8_strlen in pango.c

2024-01-05 Thread Florian Weimer
8323078: Incorrect length argument to g_utf8_strlen in pango.c - Commit messages: - 8323078: Incorrect length argument to g_utf8_strlen in pango.c Changes: https://git.openjdk.org/jfx/pull/1320/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1320&range=00 Issue: https://bu

RFR: 8323077: C type error (incompatible function pointer) in X11GLContext.c

2024-01-05 Thread Florian Weimer
8323077: C type error (incompatible function pointer) in X11GLContext.c - Commit messages: - 8323077: C type error (incompatible function pointer type) in X11GLContext.c Changes: https://git.openjdk.org/jfx/pull/1319/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1319&range

Integrated: 8307542: Call to FcConfigAppFontAddFile uses wrong prototype, arguments

2023-06-16 Thread Florian Weimer
On Fri, 5 May 2023 15:56:40 GMT, Florian Weimer wrote: > Related to: > > * https://fedoraproject.org/wiki/Changes/PortingToModernC > * https://fedoraproject.org/wiki/Toolchain/PortingToModernC This pull request has now been integrated. Changeset: 42321838 Author:Florian Weime

Re: RFR: 8307542: Call to FcConfigAppFontAddFile uses wrong prototype, arguments [v3]

2023-06-14 Thread Florian Weimer
> Related to: > > * https://fedoraproject.org/wiki/Changes/PortingToModernC > * https://fedoraproject.org/wiki/Toolchain/PortingToModernC Florian Weimer has updated the pull request incrementally with one additional commit since the last revision: Trigger automation --

Re: RFR: 8307542: Call to FcConfigAppFontAddFile uses wrong prototype, arguments

2023-06-14 Thread Florian Weimer
On Tue, 13 Jun 2023 08:52:42 GMT, Florian Weimer wrote: >> Related to: >> >> * https://fedoraproject.org/wiki/Changes/PortingToModernC >> * https://fedoraproject.org/wiki/Toolchain/PortingToModernC > > @prrace @kevinrushforth Any chance to get this reviewed? Thanks

Re: RFR: 8307542: Call to FcConfigAppFontAddFile uses wrong prototype, arguments [v2]

2023-06-14 Thread Florian Weimer
> Related to: > > * https://fedoraproject.org/wiki/Changes/PortingToModernC > * https://fedoraproject.org/wiki/Toolchain/PortingToModernC Florian Weimer has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: 8307

Re: RFR: 8307542: Call to FcConfigAppFontAddFile uses wrong prototype, arguments

2023-06-13 Thread Florian Weimer
On Fri, 5 May 2023 15:56:40 GMT, Florian Weimer wrote: > Related to: > > * https://fedoraproject.org/wiki/Changes/PortingToModernC > * https://fedoraproject.org/wiki/Toolchain/PortingToModernC @prrace @kevinrushforth Any chance to get this reviewed? Thanks. - PR Co

RFR: 8307542: Call to FcConfigAppFontAddFile uses wrong prototype, arguments

2023-05-05 Thread Florian Weimer
Related to: * https://fedoraproject.org/wiki/Changes/PortingToModernC * https://fedoraproject.org/wiki/Toolchain/PortingToModernC - Commit messages: - 8307542: Call to FcConfigAppFontAddFile uses wrong prototype, arguments Changes: https://git.openjdk.org/jfx/pull/1128/files Webre