Integrated: 8339212: gradle downloads x64 binary of SWT on Linux/aarch64

2024-09-03 Thread ANUPAM DEV
On Thu, 29 Aug 2024 04:46:05 GMT, ANUPAM DEV wrote: > Hi, > > I have updated the name of the SWT.jar that needs to be downloaded during the > build process for Linux aarch64. > from: > IS_LINUX ? "org.eclipse.swt.gtk.linux.x86_64_3.124.200.v20231113-1355" :

Re: RFR: 8339212: gradle downloads x64 binary of SWT on Linux/aarch64

2024-08-29 Thread ANUPAM DEV
On Thu, 29 Aug 2024 14:09:47 GMT, Kevin Rushforth wrote: >> Hi @kevinrushforth, >> Thankyou for the review. Can you please let me know how to get the checksum >> for aarch64? I see it gets generated automatically by gradle. ( >> https://github.com/openjdk/jfx/tree/master/gradle#readme ) >> I do

Re: RFR: 8339212: gradle downloads x64 binary of SWT on Linux/aarch64 [v2]

2024-08-29 Thread ANUPAM DEV
ot; > > to: > IS_LINUX && IS_AARCH64 ? > "org.eclipse.swt.gtk.linux.aarch64_3.124.200.v20231113-1355" : > IS_LINUX && !IS_AARCH64 ? > "org.eclipse.swt.gtk.linux.x86_64_3.124.200.v20231113-1355" : "" > > Please review. > > Regards, > Anupam ANUPAM DEV

Re: RFR: 8339212: gradle downloads x64 binary of SWT on Linux/aarch64

2024-08-29 Thread ANUPAM DEV
On Thu, 29 Aug 2024 11:55:08 GMT, Kevin Rushforth wrote: >> Hi, >> >> I have updated the name of the SWT.jar that needs to be downloaded during >> the build process for Linux aarch64. >> from: >> IS_LINUX ? "org.eclipse.swt.gtk.linux.x86_64_3.124.200.v20231113-1355" : >> "" >> >> to: >>

RFR: 8339212: When build jfx in Linux(aarch64), gradle downloads the wrong eclipse swt jar

2024-08-28 Thread ANUPAM DEV
Hi, I have updated the name of the SWT.jar that needs to be downloaded during the build process for Linux aarch64. Please review. Regards, Anupam - Commit messages: - Updated build.gradle for SWT_FILE_NAME to support Linux aarch64 Changes: https://git.openjdk.org/jfx/pull/1549/fi

Integrated: 8336592: Wrong type in documentation for TreeTableView

2024-07-19 Thread ANUPAM DEV
On Wed, 17 Jul 2024 05:53:45 GMT, ANUPAM DEV wrote: > Hello, > > There was a typo in the documentation of TreeTableView. > I have changed TreeTableColumns to TreeTableColumn > > Please review. > > Regards, > Anupam This pull request has now been integrated.

Re: RFR: 8336592: Wrong type in documentation for TreeTableView

2024-07-17 Thread ANUPAM DEV
On Wed, 17 Jul 2024 14:42:43 GMT, Andy Goryachev wrote: >> Hello, >> >> There was a typo in the documentation of TreeTableView. >> I have changed TreeTableColumns to TreeTableColumn >> >> Please review. >> >> Regards, >> Anupam > > you may want to configure github actions for this repository -

RFR: 8336592: Wrong type in documentation for TreeTableView

2024-07-16 Thread ANUPAM DEV
Hello, There was a typo in the documentation of TreeTableView. I have changed TreeTableColumns to TreeTableColumn Please review. Regards, Anupam - Commit messages: - Update TreeTableView.java Changes: https://git.openjdk.org/jfx/pull/1510/files Webrev: https://webrevs.openjdk.o

Withdrawn: 8336592: Wrong type in documentation for TreeTableView

2024-07-16 Thread ANUPAM DEV
On Wed, 17 Jul 2024 05:21:21 GMT, ANUPAM DEV wrote: > Hello, > > There is a typo in TreeTableView.java documentation. TreeTableColumns is used > instead of TreeTableColumn. > I have updated the below lines: > > TreeTableColumn fileNameCol = new TreeTa

RFR: 8336592: Wrong type in documentation for TreeTableView

2024-07-16 Thread ANUPAM DEV
Hello, There is a typo in TreeTableView.java documentation. TreeTableColumns is used instead of TreeTableColumn. I have updated the below lines: TreeTableColumn fileNameCol = new TreeTableColumn<>("Filename"); TreeTableColumn sizeCol = new TreeTableColumn<>("Size"); Please review. ---