On Tue, 3 Jun 2025 19:13:08 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix
> Implementation of [CSS media
> queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7).
Michael Strauß has updated the pull request incrementally with one additional
commit since the last revision:
use custom mediaFeature javadoc tag
-
Changes:
- all: https:
On Thu, 10 Apr 2025 12:41:44 GMT, Ziad El Midaoui
wrote:
> When the Root TreeItem is set to null, need to relayout to show the children
> items
This pull request has now been integrated.
Changeset: 11f31146
Author:Ziad El Midaoui
Committer: Andy Goryachev
URL:
https://git.openjdk
On Tue, 3 Jun 2025 13:23:35 GMT, Ziad El Midaoui wrote:
>> When the Root TreeItem is set to null, need to relayout to show the children
>> items
>
> Ziad El Midaoui has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated ch
On Tue, 3 Jun 2025 13:23:35 GMT, Ziad El Midaoui wrote:
>> When the Root TreeItem is set to null, need to relayout to show the children
>> items
>
> Ziad El Midaoui has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated ch
On Sun, 1 Jun 2025 21:42:17 GMT, Michael Strauß wrote:
> `EventHandler` property implementations in `Scene` and `Window` use anonymous
> classes derived from `ObjectPropertyBase`. We can remove about 650 lines of
> boilerplate code by using a common property class instead.
To clarify, the diff
> Implementation of
> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
Michael Strauß has updated the pull request incrementally with one additional
commit since the last revision:
fix memory leak in ViewScene
-
Changes:
- all: https://g
On Tue, 3 Jun 2025 19:13:08 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix
There was a somewhat related discussion on hacker news - someone measured how
fast a naked javac compiles the project vs how fast the build runs in gradle.
I think it might have been this discussion, though the original blog post has
disappeared or moved
https://news.ycombinator.com/item?id=4224
On Tue, 3 Jun 2025 17:34:24 GMT, Kevin Rushforth wrote:
> This suggests a memory leak related to the glass changes on macOS and Linux.
would this be considered an integration blocker?
-
PR Comment: https://git.openjdk.org/jfx/pull/1605#issuecomment-2936507784
On Tue, 3 Jun 2025 17:03:57 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now conta
On Tue, 3 Jun 2025 01:14:04 GMT, Michael Strauß wrote:
> Some `` tags in cssref.html are written as `` or ``. It should
> be ``, since it is a void element.
>
> A single reviewer is sufficient.
Marked as reviewed by jhendrikx (Reviewer).
-
PR Review: https://git.openjdk.org/jfx/p
On Tue, 3 Jun 2025 16:44:17 GMT, Kevin Rushforth wrote:
> > > when the app devs create hundreds of windows and keep them hidden (I've
> > > seen those)
> >
> >
> > 😵
>
> Window and Scene are heavy-weight classes that are reasonably limited in
> quantity, so I'm not at all worried about this.
> Implementation of [CSS media
> queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7).
Michael Strauß has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 46 commits:
- Merge branch 'master' into feature/media-queries
On Sun, 1 Jun 2025 21:42:17 GMT, Michael Strauß wrote:
> `EventHandler` property implementations in `Scene` and `Window` use anonymous
> classes derived from `ObjectPropertyBase`. We can remove about 650 lines of
> boilerplate code by using a common property class instead.
I think this is a hu
> Implementation of
> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
Michael Strauß has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 99 commits:
- Merge branch 'master' into feature/extended-
On Sun, 1 Jun 2025 21:42:17 GMT, Michael Strauß wrote:
> `EventHandler` property implementations in `Scene` and `Window` use anonymous
> classes derived from `ObjectPropertyBase`. We can remove about 650 lines of
> boilerplate code by using a common property class instead.
This pull request ha
On Tue, 3 Jun 2025 01:14:04 GMT, Michael Strauß wrote:
> Some `` tags in cssref.html are written as `` or ``. It should
> be ``, since it is a void element.
>
> A single reviewer is sufficient.
This pull request has now been integrated.
Changeset: fdd50d86
Author:Michael Strauß
URL:
Sorry for the late reply, I was stuck abroad due to flight cancellations :)
This issue has been brought up before, including lengthy off-list
discussions. As a result, I created an umbrella issue that collects issues
regarding the Gradle file: https://bugs.openjdk.org/browse/JDK-8344728. The
linke
On Tue, 20 May 2025 19:01:26 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now cont
> Implementation of
> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
Michael Strauß has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 98 commits:
- add explicit cast in glass_window.cpp
- Mer
On Tue, 3 Jun 2025 16:32:21 GMT, Michael Strauß wrote:
> I've tried to do something similar for controls by replacing a lot of the
> anonymous classes with concrete ones. I can't find the issue/discussion right
> now, but Kevin measured a non-negligible increase in memory usage. I assume
> it'
On Tue, 3 Jun 2025 16:35:50 GMT, Michael Strauß wrote:
> > when the app devs create hundreds of windows and keep them hidden (I've
> > seen those)
>
> 😵
Window and Scene are heavy-weight classes that are reasonably limited in
quantity, so I'm not at all worried about this. The concern I raise
On Tue, 3 Jun 2025 16:10:18 GMT, Nir Lisker wrote:
> I've tried to do something similar for controls by replacing a lot of the
> anonymous classes with concrete ones. I can't find the issue/discussion right
> now, but Kevin measured a non-negligible increase in memory usage. I assume
> it's be
On Tue, 20 May 2025 19:01:26 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now cont
On Tue, 3 Jun 2025 16:27:15 GMT, Andy Goryachev wrote:
> when the app devs create hundreds of windows and keep them hidden (I've seen
> those)
😵
-
PR Comment: https://git.openjdk.org/jfx/pull/1819#issuecomment-293624
On Sun, 1 Jun 2025 21:42:17 GMT, Michael Strauß wrote:
> `EventHandler` property implementations in `Scene` and `Window` use anonymous
> classes derived from `ObjectPropertyBase`. We can remove about 650 lines of
> boilerplate code by using a common property class instead.
I've tried to do som
On Sun, 1 Jun 2025 21:42:17 GMT, Michael Strauß wrote:
> `EventHandler` property implementations in `Scene` and `Window` use anonymous
> classes derived from `ObjectPropertyBase`. We can remove about 650 lines of
> boilerplate code by using a common property class instead.
@arapte can be the s
On Sun, 1 Jun 2025 21:42:17 GMT, Michael Strauß wrote:
> `EventHandler` property implementations in `Scene` and `Window` use anonymous
> classes derived from `ObjectPropertyBase`. We can remove about 650 lines of
> boilerplate code by using a common property class instead.
I like it very much.
On Tue, 3 Jun 2025 13:23:35 GMT, Ziad El Midaoui wrote:
>> When the Root TreeItem is set to null, need to relayout to show the children
>> items
>
> Ziad El Midaoui has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated ch
On Tue, 3 Jun 2025 01:14:04 GMT, Michael Strauß wrote:
> Some `` tags in cssref.html are written as `` or ``. It should
> be ``, since it is a void element.
>
> A single reviewer is sufficient.
Marked as reviewed by angorya (Reviewer).
minor doc changes, a single reviewer is probably sufficie
On Tue, 3 Jun 2025 14:34:11 GMT, Andy Goryachev wrote:
>> Some `` tags in cssref.html are written as `` or ``. It should
>> be ``, since it is a void element.
>>
>> A single reviewer is sufficient.
>
> modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html line
> 1682:
>
>>
On Tue, 3 Jun 2025 01:14:04 GMT, Michael Strauß wrote:
> Some `` tags in cssref.html are written as `` or ``. It should
> be ``, since it is a void element.
>
> A single reviewer is sufficient.
left minor comments, otherwise looks good.
modules/javafx.graphics/src/main/docs/javafx/scene/doc-f
On Mon, 2 Jun 2025 09:58:32 GMT, Johan Vos wrote:
> Hi all,
>
> This pull request contains a backport of commit ac12979b from the openjdk/jfx
> repository.
>
> The commit being backported was authored by Gopal Pattnaik on 22 May 2025 and
> was reviewed by Kevin Rushforth and Jay Bhaskar.
>
>
On Mon, 2 Jun 2025 09:58:58 GMT, Johan Vos wrote:
> Hi all,
>
> This pull request contains a backport of commit ac12979b from the openjdk/jfx
> repository.
>
> The commit being backported was authored by Gopal Pattnaik on 22 May 2025 and
> was reviewed by Kevin Rushforth and Jay Bhaskar.
>
>
On Tue, 3 Jun 2025 13:23:35 GMT, Ziad El Midaoui wrote:
>> When the Root TreeItem is set to null, need to relayout to show the children
>> items
>
> Ziad El Midaoui has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated ch
> When the Root TreeItem is set to null, need to relayout to show the children
> items
Ziad El Midaoui has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains
Another possibly related bug is
https://bugs.openjdk.org/browse/JDK-8329227 which is fixed in JavaFX 25
ea build 14. You might try running with the latest JavaFX 25 build and
see if that helps.
If not, then it does seem likely that you are hitting
https://bugs.openjdk.org/browse/JDK-8305842 w
On Tue, 3 Jun 2025 11:12:19 GMT, Ziad El Midaoui wrote:
>> When the Root TreeItem is set to null, need to relayout to show the children
>> items
>
> Ziad El Midaoui has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Merge remote-tracking br
On Mon, 2 Jun 2025 09:02:34 GMT, Gopal Pattnaik wrote:
> A clean backport to jfx24u. This is a webkit fix, need to be back ported for
> the sources sync with the mainline.
This pull request has now been integrated.
Changeset: 4e5160f3
Author:Gopal Pattnaik
Committer: Kevin Rushforth
URL:
> When the Root TreeItem is set to null, need to relayout to show the children
> items
Ziad El Midaoui has updated the pull request incrementally with two additional
commits since the last revision:
- Merge remote-tracking branch 'origin/8341281.RootTreeItem' into
8341281.RootTreeItem
- Addi
On Mon, 2 Jun 2025 15:38:04 GMT, Ambarish Rapte wrote:
>> Ziad El Midaoui has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor change : new line added
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableViewSkin
42 matches
Mail list logo
