Re: RFR: 8357157: Exception thrown from AnimationTimer freezes application [v3]

2025-05-21 Thread Alexander Zuev
On Sat, 17 May 2025 12:24:46 GMT, Michael Strauß wrote: >> When an exception is thrown from `AnimationTimer::handle`, the JavaFX >> application freezes. The reason is that the user exception will bubble up >> into framework code, preventing the normal operation of JavaFX. >> >> The following p

Re: RFR: 8341670: [Text, TextFlow] Public API for Text Layout Info [v27]

2025-05-21 Thread Kevin Rushforth
On Wed, 21 May 2025 22:52:36 GMT, Andy Goryachev wrote: >> Please refer to >> >> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md >> >> The RichTextArea control >> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom >> control that needs n

Re: RFR: 8341670: [Text, TextFlow] Public API for Text Layout Info [v18]

2025-05-21 Thread Michael Strauß
On Mon, 10 Mar 2025 16:08:31 GMT, Andy Goryachev wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/scene/text/TextLayout.java >> line 256: >> >>> 254: * @return the caret geometry >>> 255: */ >>> 256: public float[] getCaretGeometry(int offset, boolean leading); >> >

Re: RFR: 8341670: [Text, TextFlow] Public API for Text Layout Info [v27]

2025-05-21 Thread Andy Goryachev
> Please refer to > > https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md > > The RichTextArea control > ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom > control that needs non-trivial navigation within complex or wrapped text > needs a p

Re: RFR: 8341670: [Text, TextFlow] Public API for Text Layout Info [v25]

2025-05-21 Thread Kevin Rushforth
On Fri, 2 May 2025 16:57:02 GMT, Andy Goryachev wrote: >> modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 2100: >> >>> 2098: * While there is no general guarantee that successive >>> invocations of this method return the same instance, >>> 2099: * it is safe to

Re: RFR: 8341670: [Text, TextFlow] Public API for Text Layout Info [v26]

2025-05-21 Thread Kevin Rushforth
On Fri, 2 May 2025 17:42:45 GMT, Andy Goryachev wrote: >> Please refer to >> >> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md >> >> The RichTextArea control >> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom >> control that needs no

RFR: 8357393: RichTextArea: fails to properly save text attributes

2025-05-21 Thread Andy Goryachev
Fixing a bug that breaks proper serialization of character attributes. This, unfortunately, makes a breaking change in the RichTextArea native format [0]. ## References [0] https://github.com/andy-goryachev-oracle/Test/blob/main/doc/RichTextArea/RichTextArea_DataFormat_V2.md - Co

Re: RFR: 8340344: The first item in TreeView is not aligned in the beginning [v7]

2025-05-21 Thread Ziad El Midaoui
On Wed, 21 May 2025 10:22:10 GMT, Ziad El Midaoui wrote: >> The issue occurred because items preceding an item with children (items with >> a disclosure node) had different widths, which led to misalignment. This can >> be fixed by requesting a cell relayout whenever the disclosure node's widt

Integrated: 8340344: The first item in TreeView is not aligned in the beginning

2025-05-21 Thread Ziad El Midaoui
On Wed, 19 Feb 2025 16:45:54 GMT, Ziad El Midaoui wrote: > The issue occurred because items preceding an item with children (items with > a disclosure node) had different widths, which led to misalignment. This can > be fixed by requesting a cell relayout whenever the disclosure node's width

Re: RFR: 8340344: The first item in TreeView is not aligned in the beginning [v7]

2025-05-21 Thread Andy Goryachev
On Wed, 21 May 2025 10:22:10 GMT, Ziad El Midaoui wrote: >> The issue occurred because items preceding an item with children (items with >> a disclosure node) had different widths, which led to misalignment. This can >> be fixed by requesting a cell relayout whenever the disclosure node's widt

Re: RFR: 8354940: Fail to sign in to Microsoft sites with WebView

2025-05-21 Thread Kevin Rushforth
On Thu, 15 May 2025 09:26:42 GMT, Gopal Pattnaik wrote: > On loading of the reported URL, it looks like a browser version check is made > (like Safari version, Chrome version etc). At present the browser version is > not part of the user agent string we are using for JavaFX Webview > > Solutio

Re: RFR: 8340344: The first item in TreeView is not aligned in the beginning [v7]

2025-05-21 Thread Ambarish Rapte
On Wed, 21 May 2025 10:22:10 GMT, Ziad El Midaoui wrote: >> The issue occurred because items preceding an item with children (items with >> a disclosure node) had different widths, which led to misalignment. This can >> be fixed by requesting a cell relayout whenever the disclosure node's widt

Re: RFR: 8340344: The first item in TreeView is not aligned in the beginning [v6]

2025-05-21 Thread Ziad El Midaoui
On Wed, 21 May 2025 05:09:28 GMT, Ambarish Rapte wrote: >> Ziad El Midaoui has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Avoid re-layout items twice after disclosure node width value updated > > modules/javafx.controls/src/main/java/ja

Re: RFR: 8340344: The first item in TreeView is not aligned in the beginning [v7]

2025-05-21 Thread Ziad El Midaoui
> The issue occurred because items preceding an item with children (items with > a disclosure node) had different widths, which led to misalignment. This can > be fixed by requesting a cell relayout whenever the disclosure node's width > changes. Ziad El Midaoui has updated the pull request inc

Re: RFR: 8355740: Update to Xcode 15.4 on macOS

2025-05-21 Thread Joeri Sykora
On Mon, 28 Apr 2025 18:41:09 GMT, Kevin Rushforth wrote: > This PR updates the compiler on macOS to Xcode 15.4 (from 14.3.1) to match > JDK 25. > > I ran a full headless and headful test run, including building media and > WebKit. No issues were found. > > NOTE: Xcode 15.4 requires macOS 14 S