Andy, I'm really glad we figured out the background-color issue, and I'm also
very grateful to you!
Regarding wavy lines and other types of underlining — in my previous message, I
listed the key attributes
that are essential for a modern CodeArea. For example, underline for links — I
don't thi
On Wed, 7 May 2025 23:09:51 GMT, Andy Goryachev wrote:
>> Ziad El Midaoui has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update TreeCellSkin.java
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeCellSkin.java
> l
The only property that makes sense is the background color. The wavy and other
kinds of underlines, while they make some sense in the context of the CodeArea,
would fail in general in the context of RichTextArea where the content may
include nodes and images. The highlights were designed speci
On Thu, 8 May 2025 20:16:12 GMT, Ziad El Midaoui wrote:
>> The issue occurred because items preceding an item with children (items with
>> a disclosure node) had different widths, which led to misalignment. This can
>> be fixed by requesting a cell relayout whenever the disclosure node's width
> The issue occurred because items preceding an item with children (items with
> a disclosure node) had different widths, which led to misalignment. This can
> be fixed by requesting a cell relayout whenever the disclosure node's width
> changes.
Ziad El Midaoui has updated the pull request inc
Since we’re talking about code styling, I would highlight the following as the
main properties:
- foreground color (+)
- background color (-)
- font (weight, italic, size, name) (+)
- underline (e.g. for links) (?)
- wavy underline (e.g. for spelling) (-)
I think these properties cover 99% of al
Oh, I finally get it what you want. Thanks!
What you asking is effectively to add support for some additional properties to
the class that renders the text segment (currently, Text). My first question
is - what are the additional properties, beside the background-color? If it's
only the back
Andy, thank you for your reply.
I have already provided some examples, but I’ll give one more very simple
example that clearly illustrates the problem.
I have a library that uses JFX CodeArea. Naturally, all styles are stored in a
CSS file. Users of this library can customize
how the code is d
On Thu, 8 May 2025 15:03:25 GMT, Andy Goryachev wrote:
>> Ziad El Midaoui has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixed minor issues and added test
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeViewTest.
Pavel:
I think your comments in the ticket are still invisible to me, so I can't
comment.
About your recent comment in the PR - I have difficulty understanding what you
mean. We are not adding methods to "style individual properties". We are
adding methods that allow the application to use C
I am not a member of the JavaFX team, but if I may, I’d like to express my
opinion. I believe that creating separate
methods for styling individual properties is a very problematic and dangerous
decision.
First, the usefulness of such methods is minimal because when styling is done
via CSS, th
> Fixed an NPE that should only happen in a headless test environment.
>
> This is a follow-up for https://github.com/openjdk/jfx/pull/1677
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brough
Adding missing APIs related to styling the highlights with CSS:
Adds methods to the `RichParagraph.Builder`:
/**
* Adds a wavy underline (typically used as a
On Wed, 7 May 2025 15:56:57 GMT, Ziad El Midaoui wrote:
>> The issue occurred because items preceding an item with children (items with
>> a disclosure node) had different widths, which led to misalignment. This can
>> be fixed by requesting a cell relayout whenever the disclosure node's width
On Thu, 8 May 2025 14:59:40 GMT, Ziad El Midaoui wrote:
>> The issue occurred because items preceding an item with children (items with
>> a disclosure node) had different widths, which led to misalignment. This can
>> be fixed by requesting a cell relayout whenever the disclosure node's width
> The issue occurred because items preceding an item with children (items with
> a disclosure node) had different widths, which led to misalignment. This can
> be fixed by requesting a cell relayout whenever the disclosure node's width
> changes.
Ziad El Midaoui has updated the pull request inc
On Wed, 7 May 2025 15:24:04 GMT, Andy Goryachev wrote:
>> Further, if you call `setAccessibile` in connection with `--add-opens`,
>> which your above code snippet does, you can even call _private_ methods.
>>
>> So at the risk of repeating myself, there is no concern that making this
>> method
17 matches
Mail list logo
