On 23/04/2025 20:59, Andy Goryachev wrote:
>
> Even though JavaFX explicitly permits creating Nodes and Scenes in a
> thread other than the Application Thread, I think it is still a bad
> idea, and I would strongly suggest against doing so. The code might
> work - initially - but you will soon dis
In both cases only a partial fix can be applied that can ensure that at
a minimum the listener management doesn't get into a bad state. The
issue of what happens when a callback occurs on a second thread while
instances are being manipulated on the first thread will remain.
The partial fix would
Hi,
I don't think adding synchronized in ExpressionHelper is going to really
solve your problem. It will just move it elsewhere, but feel free to
let me know your exact scenario. For now I will make some assumptions.
I'm assuming you are constructing UI's in a background thread, and this
UI req
On Fri, 18 Apr 2025 14:39:41 GMT, Andy Goryachev wrote:
> > So... you want me to add more styles so it then ends up looking like a
> > correctly colored hyperlink?
>
> No. I would like to retain the existing functionality where the styles
> alternate between `[ "details-button", "less" ]` and
- Fixed gcc 14 compiler errors.
../../../gstreamer-lite/gstreamer/gst/gstclock.c: In function
'gst_clock_entry_new':
../../../gstreamer-lite/gstreamer/gst/gstclock.c:178:48: error: passing
argument 1 of 'g_weak_ref_init' from incompatible pointer type
[-Wincompatible-pointer-types]
178 | #de
> Additional RichTextArea API tests.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
review comments
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1677/files
- new: https://git.openjdk.org/jfx/pull/1677/files/
On Wed, 23 Apr 2025 21:23:31 GMT, Andy Goryachev wrote:
>> Additional RichTextArea API tests.
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> review comments
Marked as reviewed by kcr (Lead).
-
PR Review: h
On Tue, 14 Jan 2025 19:44:01 GMT, Andy Goryachev wrote:
> Additional RichTextArea API tests.
This pull request has now been integrated.
Changeset: 1b2f022d
Author:Andy Goryachev
URL:
https://git.openjdk.org/jfx/commit/1b2f022d0c08d556d0decdf71d6e0c9d13dbe6f8
Stats: 1457 lines in
On Sun, 13 Apr 2025 15:24:43 GMT, Thiago Milczarek Sayao
wrote:
> Improve StageStyle Documentation
>
> - Update `StageStyle.UTILITY`:
> Clarified that UTILITY stages may impose platform-specific restrictions on
> window states, such as preventing maximize, minimize (iconify), and
> fullscreen
On Wed, 23 Apr 2025 18:28:17 GMT, Andy Goryachev wrote:
> beginning, missing, and end
Um, sorry about the typo. I'll blame auto-correct (although it's probably my
fault).
I meant "beginning, **middle**, and end".
Currently you are testing `copy` with the entire paragraph selected. What I was
On Wed, 23 Apr 2025 19:31:16 GMT, Andy Goryachev wrote:
>> Additional RichTextArea API tests.
>
> Andy Goryachev has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 29 commits:
>
> - review comments
> - Merge remote-tracking branch '
> Additional RichTextArea API tests.
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 29 commits:
- review comments
- Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests
- rm junit4
- Merge remote
On Wed, 23 Apr 2025 09:46:06 GMT, Thiago Milczarek Sayao
wrote:
>> This is a continuation to
>> [JDK-8236651](https://bugs.openjdk.org/browse/JDK-8236651) and it aims to
>> stabilize the linux glass gtk backend.
>>
>>
>> Overall, it has been made more robust within its scope, particularly in
On Tue, 22 Apr 2025 23:09:15 GMT, Kevin Rushforth wrote:
>> hmmm... This pattern was copied from some other test. We have 32 more
>> instances of this pattern elsewhere.
>>
>> I suspect it is not avoid declaring a checked exception.
>> What would you suggest? Forward the `throwable` to
>> `
The javafx.beans package for me at least isn't necessarily bound to
JavaFX nodes. In our case, we use observable values for more than just
for JavaFX nodes. They are useful on their own. Obviously in most cases
they are used in relation to nodes, but in our case we instantiate
properties and ad
On Wed, 12 Mar 2025 14:40:01 GMT, John Hendrikx wrote:
>> This provides and uses a new implementation of `ExpressionHelper`, called
>> `ListenerManager` with improved semantics.
>>
>> See also #837 for a previous attempt which instead of triggering nested
>> emissions immediately (like this PR
Even though JavaFX explicitly permits creating Nodes and Scenes in a thread
other than the Application Thread, I think it is still a bad idea, and I would
strongly suggest against doing so. The code might work - initially - but you
will soon discover that it presents a constant source of issues
John is replacing some of the ExpressionHelper uses (properties and
bindings) through https://github.com/openjdk/jfx/pull/1081. It's still
single threaded, but I think the new implementation there should be the
center point of this discussion.
On Wed, Apr 23, 2025 at 9:41 PM Kevin Rushforth
wrote
This came up most recently in the discussion of
https://github.com/openjdk/jfx/pull/1697
As noted by you and in that PR, properties are not thread-safe. If two
threads add a listener concurrently, or if one thread adds a listener
while and another thread notifies the listeners, it is likely to
On Tue, 22 Apr 2025 21:44:33 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 27 commits:
>>
>> - rm junit4
>> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.test
On Tue, 22 Apr 2025 23:12:37 GMT, Kevin Rushforth wrote:
>> modules/jfx.incubator.richtext/src/test/java/test/jfx/incubator/scene/control/richtext/RichTextAreaTest.java
>> line 466:
>>
>>> 464:
>>> 465: @Test
>>> 466: public void modelChangeClearsSelection() {
>>
>> Since the actual d
On Tue, 22 Apr 2025 22:48:43 GMT, Andy Goryachev wrote:
>> modules/jfx.incubator.richtext/src/test/java/test/jfx/incubator/scene/control/richtext/RichTextAreaTest.java
>> line 410:
>>
>>> 408: control.setModel(null);
>>> 409: // on second through, maybe this should return null
>
On Tue, 22 Apr 2025 21:37:38 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 27 commits:
>>
>> - rm junit4
>> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.test
On Wed, 16 Apr 2025 20:28:14 GMT, Andy Goryachev wrote:
>> The code should not set the `Task.state` value to `CANCELLED` if the said
>> task is already `SUCCEEDED` or `FAILED`.
>>
>> This is a product bug.
>>
>> Added `@RepeatedTest(50)` to the tests that used to fail intermittently -
>> this
Hello,
I encountered a rare exception where adding listeners to an observable
value might break when they are added concurrently. This is due to
ExpressionHelper not being synchronized. I thought about how to fix this
on my side, but it is very difficult to do. As this is not a typical
platfo
On Wed, 23 Apr 2025 15:27:23 GMT, Jayathirth D V wrote:
> As part of https://bugs.openjdk.org/browse/JDK-8353557,
> InitializeJavaFXLaunchTests were disabled as they were failing in Ubuntu24.04
> VM and product issue https://bugs.openjdk.org/browse/JDK-8353644 was created.
>
> But after verify
On Wed, 16 Apr 2025 20:28:14 GMT, Andy Goryachev wrote:
>> The code should not set the `Task.state` value to `CANCELLED` if the said
>> task is already `SUCCEEDED` or `FAILED`.
>>
>> This is a product bug.
>>
>> Added `@RepeatedTest(50)` to the tests that used to fail intermittently -
>> this
On Wed, 23 Apr 2025 15:17:26 GMT, Andy Goryachev wrote:
>> Unit tests already need to load the JavaFX modules, so I don't see how
>> packaging it in a jar would help. All it would do it add one more thing to
>> put on the path.
>
> I meant the single-file manual tests, continuing discussion in
Yeah, that's what I'm seeing, it happens on all kinds of actions, none
of which are triggering a resize that requires layout (like
opening/closing a TitledPane or resizing the whole Window).
--John
On 23/04/2025 16:45, Andy Goryachev wrote:
>
> Possibly related: https://bugs.openjdk.org/browse/JD
As part of https://bugs.openjdk.org/browse/JDK-8353557,
InitializeJavaFXLaunchTests were disabled as they were failing in Ubuntu24.04
VM and product issue https://bugs.openjdk.org/browse/JDK-8353644 was created.
But after verifying this test on actual Ubuntu 24.04 hardware it is identified
that
On Wed, 23 Apr 2025 14:21:16 GMT, Jay Bhaskar wrote:
> A clean backport to jfx24u, only files path in the patch has been has been
> updated. The patch is for libxml and libxslt upgrade as in mainline.
This pull request has now been integrated.
Changeset: 72745a45
Author:Jay Bhaskar
URL:
On Tue, 22 Apr 2025 23:10:56 GMT, Kevin Rushforth wrote:
>> It might, or perhaps it could be packaged into a jar so we can run single
>> source files + library via JEP 458 `--class-path 'libs/*'` argument?
>>
>> see "Using pre-compiled classes" section in
>> https://openjdk.org/jeps/458
>
> Uni
On Wed, 23 Apr 2025 13:59:43 GMT, Ambarish Rapte wrote:
>> When no specular color is set while rendering 3D primitives, 0.0 specular
>> power value is used by default in our shaders.
>> When same specular power value is used in pow() function in shader it
>> results in undefined behaviour as me
Possibly related: https://bugs.openjdk.org/browse/JDK-8089992
-andy
From: John Hendrikx
Date: Wednesday, April 16, 2025 at 16:13
To: Nir Lisker , Andy Goryachev
Cc: openjfx-dev@openjdk.org
Subject: [External] : Re: Unnecessary layouts; TLDR; new method
"requestLocalLayout"
I tested this wit
A clean backport to jfx24u, only files path in the patch has been has been
updated. The patch is for libxml and libxslt upgrade as in mainline.
-
Commit messages:
- Backport 4df2326391b3528c48a4594ec9f3bb6fdde9a437
Changes: https://git.openjdk.org/jfx24u/pull/24/files
Webrev: htt
On Wed, 23 Apr 2025 12:13:52 GMT, Jayathirth D V wrote:
> When no specular color is set while rendering 3D primitives, 0.0 specular
> power value is used by default in our shaders.
> When same specular power value is used in pow() function in shader it results
> in undefined behaviour as mentio
On Wed, 23 Apr 2025 12:13:52 GMT, Jayathirth D V wrote:
> When no specular color is set while rendering 3D primitives, 0.0 specular
> power value is used by default in our shaders.
> When same specular power value is used in pow() function in shader it results
> in undefined behaviour as mentio
On Wed, 23 Apr 2025 12:42:19 GMT, Jay Bhaskar wrote:
> A clean backport to jfx24u, only files path in the patch has been has been
> updated. The patch is sqlite upgrade as in mainline.
This pull request has now been integrated.
Changeset: 476fbad1
Author:Jay Bhaskar
URL:
https://gi
On Wed, 23 Apr 2025 12:31:49 GMT, Ambarish Rapte wrote:
>> When no specular color is set while rendering 3D primitives, 0.0 specular
>> power value is used by default in our shaders.
>> When same specular power value is used in pow() function in shader it
>> results in undefined behaviour as me
On Mon, 14 Apr 2025 17:40:02 GMT, Kevin Rushforth wrote:
> Clean backport of "incompatible pointer type" fix to jfx24u
This pull request has now been integrated.
Changeset: 54bd8aaf
Author:Kevin Rushforth
URL:
https://git.openjdk.org/jfx24u/commit/54bd8aaf249afdf59f9d870b9020ce6822c
On Fri, 11 Apr 2025 16:48:24 GMT, Kevin Rushforth wrote:
> Clean backport of GHA Windows fix to jfx24u.
This pull request has now been integrated.
Changeset: 1cd8c459
Author:Kevin Rushforth
URL:
https://git.openjdk.org/jfx24u/commit/1cd8c4593706b6d7d36c7ae56922d77234e7e187
Stats:
A clean backport to jfx24u, only files path in the patch has been has been
updated. The patch is sqlite upgrade as in mainline.
-
Commit messages:
- Backport 46b36fe432aab81468df44344ab5e36aa31c5f47
Changes: https://git.openjdk.org/jfx24u/pull/23/files
Webrev: https://webrevs.ope
On Wed, 23 Apr 2025 12:13:52 GMT, Jayathirth D V wrote:
> When no specular color is set while rendering 3D primitives, 0.0 specular
> power value is used by default in our shaders.
> When same specular power value is used in pow() function in shader it results
> in undefined behaviour as mentio
On Wed, 23 Apr 2025 12:31:49 GMT, Ambarish Rapte wrote:
>> When no specular color is set while rendering 3D primitives, 0.0 specular
>> power value is used by default in our shaders.
>> When same specular power value is used in pow() function in shader it
>> results in undefined behaviour as me
On Fri, 11 Apr 2025 16:48:24 GMT, Kevin Rushforth wrote:
> Clean backport of GHA Windows fix to jfx24u.
@johanvos Can you add maintainer approval for this bug?
-
PR Comment: https://git.openjdk.org/jfx24u/pull/20#issuecomment-2824046046
When no specular color is set while rendering 3D primitives, 0.0 specular power
value is used by default in our shaders.
When same specular power value is used in pow() function in shader it results
in undefined behaviour as mentioned at :
https://registry.khronos.org/OpenGL-Refpages/es3.0/html/
On Mon, 14 Apr 2025 17:40:02 GMT, Kevin Rushforth wrote:
> Clean backport of "incompatible pointer type" fix to jfx24u
@johanvos Can you add maintainer approval for this bug?
-
PR Comment: https://git.openjdk.org/jfx24u/pull/21#issuecomment-2824046179
On Wed, 23 Apr 2025 11:25:10 GMT, Jay Bhaskar wrote:
>> The upgrade is required to address several known issues from the previous
>> version to improve stability and performance.
>
> Jay Bhaskar has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Fri, 18 Apr 2025 05:41:38 GMT, Jay Bhaskar wrote:
> The upgrade is required to address several known issues from the previous
> version to improve stability and performance.
This pull request has now been integrated.
Changeset: 4df23263
Author:Jay Bhaskar
URL:
https://git.openjd
On Fri, 18 Apr 2025 12:03:22 GMT, Jay Bhaskar wrote:
> The upgrade is required to address several known issues from the previous
> version to improve stability and performance.
This pull request has now been integrated.
Changeset: 46b36fe4
Author:Jay Bhaskar
URL:
https://git.openjd
> The upgrade is required to address several known issues from the previous
> version to improve stability and performance.
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
Adding license attribute for thirdparty libs
-
C
On Fri, 18 Apr 2025 12:03:22 GMT, Jay Bhaskar wrote:
> The upgrade is required to address several known issues from the previous
> version to improve stability and performance.
The builds ran successfully with these changes.
-
Marked as reviewed by sykora (Author).
PR Review: htt
On Tue, 22 Apr 2025 10:32:41 GMT, Jay Bhaskar wrote:
>> The upgrade is required to address several known issues from the previous
>> version to improve stability and performance.
>
> Jay Bhaskar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> This is a continuation to
> [JDK-8236651](https://bugs.openjdk.org/browse/JDK-8236651) and it aims to
> stabilize the linux glass gtk backend.
>
>
> Overall, it has been made more robust within its scope, particularly in terms
> of sizing, positioning, and state management.
>
> List of chan
> This is a continuation to
> [JDK-8236651](https://bugs.openjdk.org/browse/JDK-8236651) and it aims to
> stabilize the linux glass gtk backend.
>
>
> Overall, it has been made more robust within its scope, particularly in terms
> of sizing, positioning, and state management.
>
> List of chan
On Mon, 14 Apr 2025 23:25:57 GMT, Thiago Milczarek Sayao
wrote:
>> Improve StageStyle Documentation
>>
>> - Update `StageStyle.UTILITY`:
>> Clarified that UTILITY stages may impose platform-specific restrictions on
>> window states, such as preventing maximize, minimize (iconify), and
>> full
56 matches
Mail list logo
