Re: RFR: 8354943: [Linux] Simplify and update glass gtk backend: window sizing, positioning, and state management issues [v3]

2025-04-22 Thread Thiago Milczarek Sayao
> This is a continuation to > [JDK-8236651](https://bugs.openjdk.org/browse/JDK-8236651) and it aims to > stabilize the linux glass gtk backend. > > > Overall, it has been made more robust within its scope, particularly in terms > of sizing, positioning, and state management. > > List of chan

Re: RFR: 8354943: [Linux] Simplify and update glass gtk backend: window sizing, positioning, and state management issues [v2]

2025-04-22 Thread Thiago Milczarek Sayao
> This is a continuation to > [JDK-8236651](https://bugs.openjdk.org/browse/JDK-8236651) and it aims to > stabilize the linux glass gtk backend. > > > Overall, it has been made more robust within its scope, particularly in terms > of sizing, positioning, and state management. > > List of chan

Re: RFR: 8347359: RichTextArea API Tests [v8]

2025-04-22 Thread Kevin Rushforth
On Tue, 22 Apr 2025 22:40:01 GMT, Andy Goryachev wrote: >> modules/jfx.incubator.richtext/src/test/java/test/jfx/incubator/scene/util/TUtil.java >> line 40: >> >>> 38: >>> 39: /** >>> 40: * There should be a common place for module-agnostic test utilities. >> >> javafx.base might eventually

Re: RFR: 8347359: RichTextArea API Tests [v8]

2025-04-22 Thread Kevin Rushforth
On Tue, 22 Apr 2025 21:47:31 GMT, Kevin Rushforth wrote: > Since the actual data is sorted Typo, I meant "stored" - PR Review Comment: https://git.openjdk.org/jfx/pull/1677#discussion_r2055007843

Re: RFR: 8347359: RichTextArea API Tests [v8]

2025-04-22 Thread Andy Goryachev
On Mon, 21 Apr 2025 15:18:02 GMT, Andy Goryachev wrote: >> Additional RichTextArea API tests. > > Andy Goryachev has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 27 commits: > > - rm junit4 > - Merge remote-tracking branch 'origin

Re: RFR: 8347359: RichTextArea API Tests [v8]

2025-04-22 Thread Andy Goryachev
On Tue, 22 Apr 2025 21:46:02 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 27 commits: >> >> - rm junit4 >> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.test

Re: RFR: 8347359: RichTextArea API Tests [v8]

2025-04-22 Thread Andy Goryachev
On Tue, 22 Apr 2025 21:39:27 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 27 commits: >> >> - rm junit4 >> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.test

Re: RFR: 8347359: RichTextArea API Tests [v8]

2025-04-22 Thread Andy Goryachev
On Tue, 22 Apr 2025 20:57:46 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 27 commits: >> >> - rm junit4 >> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.test

Re: RFR: 8347359: RichTextArea API Tests [v8]

2025-04-22 Thread Andy Goryachev
On Tue, 22 Apr 2025 20:36:55 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 27 commits: >> >> - rm junit4 >> - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.test

Re: RFR: 8347359: RichTextArea API Tests [v8]

2025-04-22 Thread Kevin Rushforth
On Mon, 21 Apr 2025 15:18:02 GMT, Andy Goryachev wrote: >> Additional RichTextArea API tests. > > Andy Goryachev has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 27 commits: > > - rm junit4 > - Merge remote-tracking branch 'origin

Re: RFR: 8352162: Update libxml2 to 2.13.8 [v9]

2025-04-22 Thread Kevin Rushforth
On Tue, 22 Apr 2025 10:32:41 GMT, Jay Bhaskar wrote: >> The upgrade is required to address several known issues from the previous >> version to improve stability and performance. > > Jay Bhaskar has updated the pull request incrementally with one additional > commit since the last revision: >

Re: RFR: 8354876: Update SQLite to 3.49.1

2025-04-22 Thread Kevin Rushforth
On Fri, 18 Apr 2025 12:03:22 GMT, Jay Bhaskar wrote: > The upgrade is required to address several known issues from the previous > version to improve stability and performance. Code changes are good. I ran a sanity test and it passed. @tiainen or @johanvos This is now ready for you to review.

Re: RFR: 8354943: [Linux] Simplify and update glass gtk backend: window sizing, positioning, and state management issues

2025-04-22 Thread Kevin Rushforth
On Tue, 22 Apr 2025 12:01:56 GMT, Thiago Milczarek Sayao wrote: > This is a continuation to > [JDK-8236651](https://bugs.openjdk.org/browse/JDK-8236651) and it aims to > stabilize the linux glass gtk backend. > > > Overall, it has been made more robust within its scope, particularly in terms

Re: RFR: 8352162: Update libxml2 to 2.13.8 [v9]

2025-04-22 Thread Kevin Rushforth
On Tue, 22 Apr 2025 10:32:41 GMT, Jay Bhaskar wrote: >> The upgrade is required to address several known issues from the previous >> version to improve stability and performance. > > Jay Bhaskar has updated the pull request incrementally with one additional > commit since the last revision: >

RFR: 8354943: [Linux] Simplify and update glass gtk backend: window sizing, positioning, and state management issues

2025-04-22 Thread Thiago Milczarek Sayao
This is a continuation to [JDK-8236651](https://bugs.openjdk.org/browse/JDK-8236651) and it aims to stabilize the linux glass gtk backend. Overall, it has been made more robust within its scope, particularly in terms of sizing, positioning, and state management. List of changes: 1. It embrace

Re: RFR: 8352162: Update libxml2 to 2.13.8 [v6]

2025-04-22 Thread Jay Bhaskar
On Mon, 21 Apr 2025 18:57:38 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove unused files > > modules/javafx.web/src/main/native/Source/ThirdParty/libxml/linux/config.h > line 67: > >>

Re: RFR: 8352162: Update libxml2 to 2.13.8 [v6]

2025-04-22 Thread Jay Bhaskar
On Mon, 21 Apr 2025 19:10:02 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove unused files > > modules/javafx.web/src/main/native/Source/ThirdParty/libxml/mac/include/xmlversion.h > line

Re: RFR: 8352162: Update libxml2 to 2.13.8 [v9]

2025-04-22 Thread Jay Bhaskar
> The upgrade is required to address several known issues from the previous > version to improve stability and performance. Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision: add quotes - Changes: - all: https://git.openj

Re: RFR: 8352162: Update libxml2 to 2.13.8 [v6]

2025-04-22 Thread Jay Bhaskar
On Mon, 21 Apr 2025 18:59:26 GMT, Kevin Rushforth wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove unused files > > modules/javafx.web/src/main/native/Source/ThirdParty/libxml/linux/include/libxml/xmlversion.h

Re: RFR: 8352162: Update libxml2 to 2.13.8 [v8]

2025-04-22 Thread Jay Bhaskar
> The upgrade is required to address several known issues from the previous > version to improve stability and performance. Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision: fix linux build no need extra code - Changes:

Re: RFR: 8260020: WebView does not render contents of locally stored MarkDown (*.md) files

2025-04-22 Thread Ajit Ghaisas
On Tue, 22 Apr 2025 06:54:31 GMT, Gopal Pattnaik wrote: > Local markdown file mime type support is missing in the current JavaFX > implementation. Hence, I have added a mime type for local Markdown files. > > Verification: > The test program attached to the JBS passes with this change. I will

Re: RFR: 8352162: Update libxml2 to 2.13.8 [v7]

2025-04-22 Thread Jay Bhaskar
> The upgrade is required to address several known issues from the previous > version to improve stability and performance. Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision: remove non required files as by review - Changes

RFR: 8260020: WebView does not render contents of locally stored MarkDown (*.md) files.

2025-04-22 Thread Gopal Pattnaik
Local markdown file mime type support was missing in open source [JDK-8260020], Hence, we added a mime type for local Markdown files display. expected bahaviour: This should display the markdown file content as text in the webview. Verification: The test passes with the rendering of local Markdo