Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v10]

2025-04-07 Thread Ambarish Rapte
On Tue, 8 Apr 2025 03:32:43 GMT, Jay Bhaskar wrote: >> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing >> deprecated APIs, updating assertions, and refactoring test structures to >> align with JUnit 5's improved features. > > Jay Bhaskar has updated the pull request increm

Re: RFR: 8341670: [Text, TextFlow] Public API for Text Layout Info [v23]

2025-04-07 Thread Andy Goryachev
On Sat, 5 Apr 2025 07:53:35 GMT, Michael Strauß wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 48 commits: >> >> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api >> - Merge remote-

Re: RFR: 8341670: [Text, TextFlow] Public API for Text Layout Info [v25]

2025-04-07 Thread Andy Goryachev
> Please refer to > > https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md > > The RichTextArea control > ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom > control that needs non-trivial navigation within complex or wrapped text > needs a p

Re: RFR: 8313424: JavaFX controls in the title bar [v61]

2025-04-07 Thread Andy Goryachev
On Mon, 7 Apr 2025 19:46:23 GMT, Michael Strauß wrote: >> Implementation of >> [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) >> and `EXTENDED_UTILITY` stage style. > > Michael Strauß has updated the pull request incrementally with one additional > commit since th

Re: RFR: 8313424: JavaFX controls in the title bar [v61]

2025-04-07 Thread Andy Goryachev
On Mon, 7 Apr 2025 19:46:23 GMT, Michael Strauß wrote: >> Implementation of >> [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) >> and `EXTENDED_UTILITY` stage style. > > Michael Strauß has updated the pull request incrementally with one additional > commit since th

Re: RFR: 8341670: [Text, TextFlow] Public API for Text Layout Info [v23]

2025-04-07 Thread Michael Strauß
On Mon, 7 Apr 2025 18:39:25 GMT, Andy Goryachev wrote: >> modules/javafx.graphics/src/main/java/javafx/scene/text/CaretInfo.java line >> 62: >> >>> 60: * {@code (index < 0 || index > getSegmentCount())} >>> 61: */ >>> 62: public abstract Rectangle2D getSegmentAt(int index); >>

Re: RFR: 8313424: JavaFX controls in the title bar [v60]

2025-04-07 Thread Michael Strauß
On Mon, 7 Apr 2025 19:41:27 GMT, Andy Goryachev wrote: > Which IDE are you using (if any)? IntelliJ, which doesn't give me code insight into MonkeyTester because it's not part of the Gradle project. I usually don't use an IDE for MonkeyTester, but just edit the text files and compile it on the

Re: RFR: 8313424: JavaFX controls in the title bar [v60]

2025-04-07 Thread Andy Goryachev
On Sun, 6 Apr 2025 09:29:33 GMT, Michael Strauß wrote: >> Implementation of >> [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) >> and `EXTENDED_UTILITY` stage style. > > Michael Strauß has updated the pull request with a new target base due to a > merge or a rebase

Re: RFR: 8313424: JavaFX controls in the title bar [v60]

2025-04-07 Thread Michael Strauß
On Mon, 7 Apr 2025 19:26:58 GMT, Andy Goryachev wrote: > Sorry, I am getting compiler error > > ``` > Description ResourceTypePathLocation > The import com.oracle.tools.fx.monkey.tools.ModalWindow cannot be resolved > MainWindow.java Java Problem/MonkeyTester/src/com/or

Re: RFR: 8313424: JavaFX controls in the title bar [v60]

2025-04-07 Thread Andy Goryachev
On Mon, 7 Apr 2025 19:02:21 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/java/javafx/scene/layout/HeaderBar.java >> line 854: >> >>> 852: return minimum >>> 853: ? computeChildMinAreaHeight(child, -1, margin, width, >>> false) >>> 854:

Re: RFR: 8341670: [Text, TextFlow] Public API for Text Layout Info [v23]

2025-04-07 Thread Michael Strauß
On Mon, 7 Apr 2025 18:30:47 GMT, Andy Goryachev wrote: > > Can this class be sealed? > > Theoretically, yes, but what problem would that solve? > > I can understand when sealing would make the platform more secure, but in > this case I see no value whatsoever. Could you give me an example wher

Re: RFR: 8313424: JavaFX controls in the title bar [v60]

2025-04-07 Thread Andy Goryachev
On Sun, 6 Apr 2025 09:29:33 GMT, Michael Strauß wrote: >> Implementation of >> [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) >> and `EXTENDED_UTILITY` stage style. > > Michael Strauß has updated the pull request with a new target base due to a > merge or a rebase

Re: RFR: 8341670: [Text, TextFlow] Public API for Text Layout Info [v23]

2025-04-07 Thread Andy Goryachev
On Fri, 4 Apr 2025 14:42:20 GMT, Andy Goryachev wrote: >> Please refer to >> >> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md >> >> The RichTextArea control >> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom >> control that needs no

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v9]

2025-04-07 Thread Andy Goryachev
On Mon, 7 Apr 2025 17:23:53 GMT, Jay Bhaskar wrote: >> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing >> deprecated APIs, updating assertions, and refactoring test structures to >> align with JUnit 5's improved features. > > Jay Bhaskar has updated the pull request increm

Re: RFR: 8351878: RichTextArea: copy/paste issues [v5]

2025-04-07 Thread Andy Goryachev
On Wed, 26 Mar 2025 14:36:39 GMT, Andy Goryachev wrote: >> Fixed several issues found in importing RTF text: >> >> - charset translation (brought back removed code) >> - missing font size attribute >> - missing strike-through attribute >> >> Also, HTML copy suffered from the following issues: >

Re: RFR: 8335547: Support multi-line prompt text for TextArea [v4]

2025-04-07 Thread Ziad El Midaoui
On Fri, 28 Mar 2025 20:22:39 GMT, Kevin Rushforth wrote: >> Option 1 is intentionally the status quo, and matches what Swing's >> JComponent does, although @mstr2 is right that this isn't documented. An RFE >> to treat `\r` or `\r\n` as a newline could be considered in the future. We >> wouldn

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v8]

2025-04-07 Thread Jay Bhaskar
> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing > deprecated APIs, updating assertions, and refactoring test structures to > align with JUnit 5's improved features. Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v7]

2025-04-07 Thread Jay Bhaskar
> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing > deprecated APIs, updating assertions, and refactoring test structures to > align with JUnit 5's improved features. Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8234153: [TEST_BUG] Rewrite Popup_parentWindow_Test [v2]

2025-04-07 Thread Lukasz Kostyra
> This change rewrites `Popup_parentWindow_Test` after a-long-time-ago-done > changes to Popup public API. > > Popup used to have an `owner` and `parentWindow` properties. I couldn't track > how far back that change happened so I can't fully say what these Properties > actually were, but to my

Re: RFR: 8234153: [TEST_BUG] Rewrite Popup_parentWindow_Test [v2]

2025-04-07 Thread Lukasz Kostyra
On Mon, 7 Apr 2025 08:09:32 GMT, Lukasz Kostyra wrote: >> This change rewrites `Popup_parentWindow_Test` after a-long-time-ago-done >> changes to Popup public API. >> >> Popup used to have an `owner` and `parentWindow` properties. I couldn't >> track how far back that change happened so I can'

Re: RFR: 8234153: [TEST_BUG] Rewrite Popup_parentWindow_Test

2025-04-07 Thread Lukasz Kostyra
On Sat, 5 Apr 2025 07:36:58 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/test/java/test/javafx/stage/Popup_owner_Test.java >> line 55: >> >>> 53: * Instead we rely on checking this manually. >>> 54: */ >>> 55: public final class Popup_owner_Test { >> >> minor: maybe `Popup_Owner