Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v5]

2025-04-03 Thread Jay Bhaskar
> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing > deprecated APIs, updating assertions, and refactoring test structures to > align with JUnit 5's improved features. Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v3]

2025-04-03 Thread Jay Bhaskar
> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing > deprecated APIs, updating assertions, and refactoring test structures to > align with JUnit 5's improved features. Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v2]

2025-04-03 Thread Jay Bhaskar
> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing > deprecated APIs, updating assertions, and refactoring test structures to > align with JUnit 5's improved features. Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8351867: No UI changes while iconified

2025-04-03 Thread John Hendrikx
On Thu, 13 Mar 2025 10:36:40 GMT, John Hendrikx wrote: > Adds code to trigger a scene update when a Window is restored > > This seems to solve https://bugs.openjdk.org/browse/JDK-8351867 and > https://bugs.openjdk.org/browse/JDK-8146479 This doesn't look like an easy fix; although it fixes the

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5

2025-04-03 Thread Ambarish Rapte
On Thu, 3 Apr 2025 12:34:37 GMT, Jay Bhaskar wrote: > Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing > deprecated APIs, updating assertions, and refactoring test structures to > align with JUnit 5's improved features. Providing a few minor comments. modules/javafx.base/

Re: Feature Request: Support for Transparent Title Bars in JavaFX Stages

2025-04-03 Thread Cormac Redmond
Would really love to see https://github.com/openjdk/jfx/pull/1605 as a preview in JFX 25. Kind Regards, Cormac On Thu, 3 Apr 2025 at 17:01, Bahaa Zaid wrote: > That’s great. Thank you much. > > > On 3 Apr 2025, at 4:59 PM, Michael Strauß > wrote: > > > > Already under way: https://github.com/

JavaFX slides from JavaOne 2025

2025-04-03 Thread Kevin Rushforth
In case anyone is interested, here is the slide deck I presented at JavaOne 2025 for the "JavaFX 24 and Beyond" session. https://cr.openjdk.org/~kcr/presentations/javaone-2025/JavaFX-24-Final.pdf -- Kevin

Integrated: 8351276: Prevent redundant computeValue calls when a chain of mappings becomes observed

2025-04-03 Thread John Hendrikx
On Thu, 6 Mar 2025 15:22:58 GMT, John Hendrikx wrote: > 8351276: Prevent redundant computeValue calls when a chain of mappings > becomes observed This pull request has now been integrated. Changeset: ab94b5e7 Author:John Hendrikx URL: https://git.openjdk.org/jfx/commit/ab94b5e71c17

Re: RFR: 8353668: Rename internal c.s.javafx.text.TextLine class

2025-04-03 Thread Michael Strauß
On Thu, 3 Apr 2025 18:01:07 GMT, Andy Goryachev wrote: > This minor change renames an internal `com.sun.javafx.text.TextLine` to > `PrismTextLine`. > This class implements `com.sun.javafx.scene.text.TextLine` interface, also > internal, for the purpose of reducing confusion and avoiding FQCN. >

Re: RFR: 8351867: No UI changes while iconified

2025-04-03 Thread Kevin Rushforth
On Tue, 18 Mar 2025 15:01:46 GMT, Ambarish Rapte wrote: >> Adds code to trigger a scene update when a Window is restored >> >> This seems to solve https://bugs.openjdk.org/browse/JDK-8351867 and >> https://bugs.openjdk.org/browse/JDK-8146479 > > This does fix the issue on windows. > The issue o

Re: RFR: 8351878: RichTextArea: copy/paste issues [v5]

2025-04-03 Thread Kevin Rushforth
On Wed, 26 Mar 2025 14:36:39 GMT, Andy Goryachev wrote: >> Fixed several issues found in importing RTF text: >> >> - charset translation (brought back removed code) >> - missing font size attribute >> - missing strike-through attribute >> >> Also, HTML copy suffered from the following issues: >

Re: RFR: 8345348: CSS Media Queries

2025-04-03 Thread Michael Strauß
On Mon, 2 Dec 2024 16:19:46 GMT, Michael Strauß wrote: > Implementation of [CSS media > queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7). Let's try this again. - PR Comment: https://git.openjdk.org/jfx/pull/1655#issuecomment-2776685622

RFR: 8353668: Rename internal c.s.javafx.text.TextLine class

2025-04-03 Thread Andy Goryachev
This minor change renames an internal `com.sun.javafx.text.TextLine` to `PrismTextLine`. This class implements `com.sun.javafx.scene.text.TextLine` interface, also internal, for the purpose of reducing confusion and avoiding FQCN. This change is completely transparent to the application develope

Behavior when resizing a window programmatically while it is fullscreen or maximized

2025-04-03 Thread Thiago Milczarek Sayão
Hi, JavaFX allows setting the stage's width, height, and position (X, Y) when it is maximized or in fullscreen mode, without ignoring the values or throwing an exception. The current documentation states the following regarding X, Y, Width, Height, and sizeToScene: Changing this attribute will n

Integrated: 8353620: Make some systems tests robust for Ubuntu 24.04

2025-04-03 Thread Jayathirth D V
On Thu, 3 Apr 2025 18:05:54 GMT, Jayathirth D V wrote: > Under https://bugs.openjdk.org/browse/JDK-8339679 task, we are running full > tests and identifying issues for Ubuntu 24.04. > > As part of above task it is identified that there are 3 tests which fail > intermittently and we need to add

Re: RFR: 8353620: Make some systems tests robust for Ubuntu 24.04

2025-04-03 Thread Kevin Rushforth
On Thu, 3 Apr 2025 18:05:54 GMT, Jayathirth D V wrote: > Under https://bugs.openjdk.org/browse/JDK-8339679 task, we are running full > tests and identifying issues for Ubuntu 24.04. > > As part of above task it is identified that there are 3 tests which fail > intermittently and we need to add

RFR: 8353620: Make some systems tests robust for Ubuntu 24.04

2025-04-03 Thread Jayathirth D V
Under https://bugs.openjdk.org/browse/JDK-8339679 task, we are running full tests and identifying issues for Ubuntu 24.04. As part of above task it is identified that there are 3 tests which fail intermittently and we need to add appropriate delays to make them more robust. Delays are added bet

Integrated: 8353617: Remove deprecated TransitionEvent constructor

2025-04-03 Thread Michael Strauß
On Thu, 3 Apr 2025 08:47:51 GMT, Michael Strauß wrote: > Remove the deprecated `TransitionEvent(EventType, StyleableProperty, > Duration)` constructor. > > A single reviewer should be sufficient. This pull request has now been integrated. Changeset: 1a65f4c3 Author:Michael Strauß URL:

Re: RFR: 8353548: [macOS] DragEvent.getScreenY() returns incorrect value in secondary monitor

2025-04-03 Thread Ambarish Rapte
On Wed, 2 Apr 2025 17:05:58 GMT, Jose Pereda wrote: > This PR fixes an issue when dragEvents occur in a secondary screen which > doesn't have the same height or (macOS) origin as the main screen. > > The calculations for `xAbs, yAbs` are defined from the main screen macOS > absolute origin, an

Re: Feature Request: Support for Transparent Title Bars in JavaFX Stages

2025-04-03 Thread Bahaa Zaid
That’s great. Thank you much. > On 3 Apr 2025, at 4:59 PM, Michael Strauß wrote: > > Already under way: https://github.com/openjdk/jfx/pull/1605

Re: JavaFX slides from JavaOne 2025

2025-04-03 Thread Andy Goryachev
Thank you! Please let us know when the video of your talk becomes available. -andy From: openjfx-dev on behalf of Kevin Rushforth Date: Thursday, April 3, 2025 at 07:45 To: openjfx-dev Subject: JavaFX slides from JavaOne 2025 In case anyone is interested, here is the slide deck I presented

Integrated: 8353548: [macOS] DragEvent.getScreenY() returns incorrect value in secondary monitor

2025-04-03 Thread Jose Pereda
On Wed, 2 Apr 2025 17:05:58 GMT, Jose Pereda wrote: > This PR fixes an issue when dragEvents occur in a secondary screen which > doesn't have the same height or (macOS) origin as the main screen. > > The calculations for `xAbs, yAbs` are defined from the main screen macOS > absolute origin, an

Integrated: 8352982: gradle TEST_SDK_PATH param doesn't work with relative paths

2025-04-03 Thread Ambarish Rapte
On Tue, 1 Apr 2025 06:36:24 GMT, Ambarish Rapte wrote: > Issue: > The test execution fails when a relative path is specified a relative path > for `TEST_SDK_PATH`. > For example: > 1. gradle -PTEST_ONLY=true -PTEST_SDK_PATH=**..**/jfx1/build test > 2. gradle -PTEST_ONLY=true -PTEST_SDK_PATH=**~

RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5

2025-04-03 Thread Jay Bhaskar
Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing deprecated APIs, updating assertions, and refactoring test structures to align with JUnit 5's improved features. - Commit messages: - remove trailing white space - 8340464: [TestBug] Convert parametrized base te

Re: RFR: 8353617: Remove deprecated TransitionEvent constructor

2025-04-03 Thread Kevin Rushforth
On Thu, 3 Apr 2025 08:47:51 GMT, Michael Strauß wrote: > Remove the deprecated `TransitionEvent(EventType, StyleableProperty, > Duration)` constructor. > > A single reviewer should be sufficient. @mstr2 I reviewed the CSR, so you can Finalize it at your convenience. - PR Comment:

Re: RFR: 8353617: Remove deprecated TransitionEvent constructor

2025-04-03 Thread Kevin Rushforth
On Thu, 3 Apr 2025 08:47:51 GMT, Michael Strauß wrote: > Remove the deprecated `TransitionEvent(EventType, StyleableProperty, > Duration)` constructor. > > A single reviewer should be sufficient. Marked as reviewed by kcr (Lead). Since this needs a CSR, a second reviewer is best. I'll do that

Re: RFR: 8353617: Remove deprecated TransitionEvent constructor

2025-04-03 Thread John Hendrikx
On Thu, 3 Apr 2025 08:47:51 GMT, Michael Strauß wrote: > Remove the deprecated `TransitionEvent(EventType, StyleableProperty, > Duration)` constructor. > > A single reviewer should be sufficient. Marked as reviewed by jhendrikx (Reviewer). - PR Review: https://git.openjdk.org/jfx

RFR: 8353617: Remove deprecated TransitionEvent constructor

2025-04-03 Thread Michael Strauß
Remove the deprecated `TransitionEvent(EventType, StyleableProperty, Duration)` constructor. A single reviewer should be sufficient. - Commit messages: - remove TransitionEvent constructor Changes: https://git.openjdk.org/jfx/pull/1758/files Webrev: https://webrevs.openjdk.org/?

Re: RFR: 8351276: Prevent redundant computeValue calls when a chain of mappings becomes observed [v2]

2025-04-03 Thread Michael Strauß
On Wed, 2 Apr 2025 08:36:22 GMT, John Hendrikx wrote: >> 8351276: Prevent redundant computeValue calls when a chain of mappings >> becomes observed > > John Hendrikx has updated the pull request incrementally with one additional > commit since the last revision: > > Fix review comments Mark