Re: RFR: 8352982: gradle TEST_SDK_PATH param doesn't work with relative paths

2025-04-01 Thread Ambarish Rapte
On Tue, 1 Apr 2025 12:31:03 GMT, Kevin Rushforth wrote: >> Issue: >> The test execution fails when a relative path is specified a relative path >> for `TEST_SDK_PATH`. >> For example: >> 1. gradle -PTEST_ONLY=true -PTEST_SDK_PATH=**..**/jfx1/build test >> 2. gradle -PTEST_ONLY=true -PTEST_SDK_P

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v3]

2025-04-01 Thread Kevin Rushforth
On Tue, 1 Apr 2025 21:17:35 GMT, Andy Goryachev wrote: > We might still provide general purpose methods in ScreenCapture (new class) > like That might work. So the idea would be a utility class not tied to a JUnit5 annotation? The usage would then be adding a call to that while debugging a te

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v4]

2025-04-01 Thread Andy Goryachev
> Introduce a facility, in the form of JUnit5 annotation, to allow for > capturing a desktop screenshot of a failed test. > > The primary intent is to be able to debug an intermittent test case, rather > than wholesale addition of the new annotation to all the tests. > > The log contains a base

Integrated: 8351733: Crash when creating too many nested event loops

2025-04-01 Thread Martin Fox
On Fri, 21 Mar 2025 20:56:01 GMT, Martin Fox wrote: > There is an undocumented limit on nesting calls to CFRunLoopRun (or the > equivalent wrapper NSRunLoop methods). When the limit is hit the OS > terminates the Java app. The situation arises when a JavaFX app creates too > many nested event

Re: Reporting a JavaFx bug

2025-04-01 Thread Kevin Rushforth
I just tried a test bug report at bugreport.java.com and it is working for me. Can you try again? If it still fails to work for you, let me know and I can ask someone to take a look at it. -- Kevin On 4/1/2025 3:49 AM, Dahlberg, Magnus wrote: Hi, I'm trying to report a bug with JavaFx 21.0

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v3]

2025-04-01 Thread Andy Goryachev
On Mon, 31 Mar 2025 18:35:03 GMT, Andy Goryachev wrote: >> Introduce a facility, in the form of JUnit5 annotation, to allow for >> capturing a desktop screenshot of a failed test. >> >> The primary intent is to be able to debug an intermittent test case, rather >> than wholesale addition of th

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v3]

2025-04-01 Thread Andy Goryachev
On Tue, 1 Apr 2025 20:11:13 GMT, Kevin Rushforth wrote: > This suggests that the test watcher doesn't get called until after the > @AfterEach method has run. That's entirely possible. I suppose one can register a Thread::uncaughtExceptionHandler and call a static method, something like Scree

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v3]

2025-04-01 Thread Andy Goryachev
On Tue, 1 Apr 2025 19:51:16 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> data url > > tests/system/src/test/java/test/util/ScreenCaptureTestWatcher.java line 59: > >> 57: public void

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v3]

2025-04-01 Thread Kevin Rushforth
On Mon, 31 Mar 2025 16:59:31 GMT, Andy Goryachev wrote: >> Hmm. That isn't what I thought we were doing. I thought the idea was to >> annotate most (if not all all) screen capture tests, qualified by a system >> property, enable that property in our CI test runs, so that when we do get >> inte

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v3]

2025-04-01 Thread Kevin Rushforth
On Mon, 31 Mar 2025 18:35:03 GMT, Andy Goryachev wrote: >> Introduce a facility, in the form of JUnit5 annotation, to allow for >> capturing a desktop screenshot of a failed test. >> >> The primary intent is to be able to debug an intermittent test case, rather >> than wholesale addition of th

Integrated: 8351047: TitledPane should handle titles that are resizable

2025-04-01 Thread John Hendrikx
On Sat, 22 Mar 2025 12:20:17 GMT, John Hendrikx wrote: > This PR will forward more Label calculations to LabeledSkinBase, as they are > quite complex, especially when a Graphic is involved which is a full-fledged > `Node`. More specifically, this solves issues with TitledPane when the > graphi

Re: RFR: 8245602: Ensemble8: HTMLEditor Toolbar gets scrolled out of view

2025-04-01 Thread Andy Goryachev
On Tue, 1 Apr 2025 06:47:59 GMT, Gopal Pattnaik wrote: > There was a scrolling issue with multiline edit control with text controls at > the top of the edit box > [JDK-8245602](https://bugs.openjdk.org/browse/JDK-8245602), > > We replaced the ScrollPane with VBox control as the parent of the h

Re: RFR: 8350976: MenuBarSkin: exception initializing in a background thread [v2]

2025-04-01 Thread Andy Goryachev
On Wed, 5 Mar 2025 18:19:53 GMT, Andy Goryachev wrote: >> Allows MenuBar to be created in a background thread by delaying >> MenuBarSkin::rebuildUI() call until after the MenuBar becomes a part of the >> scene graph. > > Andy Goryachev has updated the pull request with a new target base due to

Re: RFR: 8207333: [linux] Column sorting is triggered always after context menu request on table header

2025-04-01 Thread Andy Goryachev
On Tue, 1 Apr 2025 17:31:14 GMT, Jose Pereda wrote: > Note: The JBS issue > [JDK-8207333](https://bugs.openjdk.org/browse/JDK-8207333) refers to Linux, > but it happens on macOS too. > > When a TableColumn has a ContextMenu, if the user right clicks on the > tableColumnHeader, the ContextMen

Re: RFR: 8350976: MenuBarSkin: exception initializing in a background thread [v2]

2025-04-01 Thread Andy Goryachev
On Wed, 5 Mar 2025 18:19:53 GMT, Andy Goryachev wrote: >> Allows MenuBar to be created in a background thread by delaying >> MenuBarSkin::rebuildUI() call until after the MenuBar becomes a part of the >> scene graph. > > Andy Goryachev has updated the pull request with a new target base due to

Re: RFR: 8352999: [macOS] Conditional behavior by directly querying the Objective-C call stack

2025-04-01 Thread Kevin Rushforth
On Mon, 31 Mar 2025 18:29:21 GMT, Martin Fox wrote: > Before a window is maximized glass records its existing size and location. > This rectangle is stored in native screen coordinates. Compared to Java > screen coordinates native coordinates are flipped along the Y axis. > > When the window i

Re: RFR: 8350976: MenuBarSkin: exception initializing in a background thread [v2]

2025-04-01 Thread Kevin Rushforth
On Tue, 1 Apr 2025 17:51:15 GMT, Andy Goryachev wrote: > The only way this functionality is suppressed is when > glass.disableThreadChecks system property is set to true. There is no easy way to set this, so I'm almost certain that isn't the case here. Jay can confirm, but I think there is a m

Re: RFR: 8207333: [linux] Column sorting is triggered always after context menu request on table header

2025-04-01 Thread Andy Goryachev
On Tue, 1 Apr 2025 17:31:14 GMT, Jose Pereda wrote: > Note: The JBS issue > [JDK-8207333](https://bugs.openjdk.org/browse/JDK-8207333) refers to Linux, > but it happens on macOS too. > > When a TableColumn has a ContextMenu, if the user right clicks on the > tableColumnHeader, the ContextMen

Re: RFR: 8245602: Ensemble8: HTMLEditor Toolbar gets scrolled out of view

2025-04-01 Thread Andy Goryachev
On Tue, 1 Apr 2025 06:47:59 GMT, Gopal Pattnaik wrote: > There was a scrolling issue with multiline edit control with text controls at > the top of the edit box > [JDK-8245602](https://bugs.openjdk.org/browse/JDK-8245602), > > We replaced the ScrollPane with VBox control as the parent of the h

Re: RFR: 8207333: [linux] Column sorting is triggered always after context menu request on table header

2025-04-01 Thread Andy Goryachev
On Tue, 1 Apr 2025 17:31:14 GMT, Jose Pereda wrote: > Note: The JBS issue > [JDK-8207333](https://bugs.openjdk.org/browse/JDK-8207333) refers to Linux, > but it happens on macOS too. > > When a TableColumn has a ContextMenu, if the user right clicks on the > tableColumnHeader, the ContextMen

RFR: 8207333: [linux] Column sorting is triggered always after context menu request on table header

2025-04-01 Thread Jose Pereda
Note: The JBS issue [JDK-8207333](https://bugs.openjdk.org/browse/JDK-8207333) refers to Linux, but it happens on macOS too. When a TableColumn has a ContextMenu, if the user right clicks on the tableColumnHeader, the ContextMenu shows up, but, as described on the issue, on macOS and Linux, th

Re: RFR: 8245602: Ensemble8: HTMLEditor Toolbar gets scrolled out of view

2025-04-01 Thread Andy Goryachev
On Tue, 1 Apr 2025 06:47:59 GMT, Gopal Pattnaik wrote: > There was a scrolling issue with multiline edit control with text controls at > the top of the edit box > [JDK-8245602](https://bugs.openjdk.org/browse/JDK-8245602), > > We replaced the ScrollPane with VBox control as the parent of the h

Re: RFR: 8350009: [XWayland] SwingNodePlatformExitCrashTest hangs on Ubuntu 24.04

2025-04-01 Thread Kevin Rushforth
On Tue, 1 Apr 2025 15:51:07 GMT, Jayathirth D V wrote: > SwingNodePlatformExitCrashTest hangs on Ubuntu 24.04 and wayland when we use > < JDK 24. > > This is happening because of issue identified in > https://bugs.openjdk.org/browse/JDK-8335468 and it is fixed in JDK 24. > So we need to run th

Re: RFR: 8350976: MenuBarSkin: exception initializing in a background thread [v2]

2025-04-01 Thread Andy Goryachev
On Wed, 5 Mar 2025 18:19:53 GMT, Andy Goryachev wrote: >> Allows MenuBar to be created in a background thread by delaying >> MenuBarSkin::rebuildUI() call until after the MenuBar becomes a part of the >> scene graph. > > Andy Goryachev has updated the pull request with a new target base due to

Re: RFR: 8350976: MenuBarSkin: exception initializing in a background thread [v2]

2025-04-01 Thread Jayathirth D V
On Wed, 5 Mar 2025 18:19:53 GMT, Andy Goryachev wrote: >> Allows MenuBar to be created in a background thread by delaying >> MenuBarSkin::rebuildUI() call until after the MenuBar becomes a part of the >> scene graph. > > Andy Goryachev has updated the pull request with a new target base due to

Re: RFR: 8352746: [TestBug] Monkey Tester Application Update 5

2025-04-01 Thread Kevin Rushforth
On Mon, 31 Mar 2025 23:11:42 GMT, Andy Goryachev wrote: > Further additions to the MonkeyTester application: > > - platform preferences monitor > - improved pages: hbox, vbox > - improved css playground > - mouse listener option in some context menus > - additional choices: background > - additi

Re: RFR: 8245602: Ensemble8: HTMLEditor Toolbar gets scrolled out of view

2025-04-01 Thread Kevin Rushforth
On Tue, 1 Apr 2025 06:47:59 GMT, Gopal Pattnaik wrote: > There was a scrolling issue with multiline edit control with text controls at > the top of the edit box > [JDK-8245602](https://bugs.openjdk.org/browse/JDK-8245602), > > We replaced the ScrollPane with VBox control as the parent of the h

Re: RFR: 8350976: MenuBarSkin: exception initializing in a background thread [v2]

2025-04-01 Thread Jayathirth D V
On Wed, 5 Mar 2025 18:19:53 GMT, Andy Goryachev wrote: >> Allows MenuBar to be created in a background thread by delaying >> MenuBarSkin::rebuildUI() call until after the MenuBar becomes a part of the >> scene graph. > > Andy Goryachev has updated the pull request with a new target base due to

Integrated: 8281384: Random chars on paste from Windows clipboard

2025-04-01 Thread Oliver Schmidtmer
On Tue, 25 Feb 2025 13:25:07 GMT, Oliver Schmidtmer wrote: > Windows programs may reuse a clipboard buffer that is larger than the new > content. In this case de NUL terminator is not at the end of the buffer, but > within it. > The current implementation copys the whole buffer into a text fi

RFR: 8352746: [TestBug] Monkey Tester Application Update 5

2025-04-01 Thread Andy Goryachev
Further additions to the MonkeyTester application: - platform preferences monitor - improved pages: hbox, vbox - improved css playground - mouse listener option in some context menus - additional choices: background - additional properties: Node::clip, Region::shape, TextInputControl::textFormatt

RFR: 8350009: [XWayland] SwingNodePlatformExitCrashTest hangs on Ubuntu 24.04

2025-04-01 Thread Jayathirth D V
SwingNodePlatformExitCrashTest hangs on Ubuntu 24.04 and wayland when we use < JDK 24. This is happening because of issue identified in https://bugs.openjdk.org/browse/JDK-8335468 and it is fixed in JDK 24. So we need to run this test on wayland only when we use JDK 24 or later. Test is updated

Re: RFR: 8353163: [XWayland] Disable SwingNodePlatformExitCrashTest on wayland

2025-04-01 Thread Jayathirth D V
On Fri, 28 Mar 2025 08:56:36 GMT, Jayathirth D V wrote: > SwingNodePlatformExitCrashTest hangs while running on wayland, we need to > skip this test on wayland until https://bugs.openjdk.org/browse/JDK-8350009 > is fixed. I ran the test multiple times with wayland and JDK 24 on Ubuntu24.04 and

Re: RFR: 8350976: MenuBarSkin: exception initializing in a background thread [v2]

2025-04-01 Thread Andy Goryachev
On Tue, 1 Apr 2025 14:36:39 GMT, Jayathirth D V wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commi

Re: RFR: 8350976: MenuBarSkin: exception initializing in a background thread [v2]

2025-04-01 Thread Jayathirth D V
On Wed, 5 Mar 2025 18:19:53 GMT, Andy Goryachev wrote: >> Allows MenuBar to be created in a background thread by delaying >> MenuBarSkin::rebuildUI() call until after the MenuBar becomes a part of the >> scene graph. > > Andy Goryachev has updated the pull request with a new target base due to

Re: RFR: 8352982: gradle TEST_SDK_PATH param doesn't work with relative paths

2025-04-01 Thread Kevin Rushforth
On Tue, 1 Apr 2025 06:36:24 GMT, Ambarish Rapte wrote: > Issue: > The test execution fails when a relative path is specified a relative path > for `TEST_SDK_PATH`. > For example: > 1. gradle -PTEST_ONLY=true -PTEST_SDK_PATH=**..**/jfx1/build test > 2. gradle -PTEST_ONLY=true -PTEST_SDK_PATH=**~

Re: RFR: 8281384: Random chars on paste from Windows clipboard [v9]

2025-04-01 Thread duke
On Mon, 31 Mar 2025 17:48:50 GMT, Oliver Schmidtmer wrote: >> Windows programs may reuse a clipboard buffer that is larger than the new >> content. In this case de NUL terminator is not at the end of the buffer, but >> within it. >> The current implementation copys the whole buffer into a tex

Re: RFR: 8351733: Crash when creating too many nested event loops [v7]

2025-04-01 Thread Kevin Rushforth
On Mon, 31 Mar 2025 17:49:59 GMT, Martin Fox wrote: >> There is an undocumented limit on nesting calls to CFRunLoopRun (or the >> equivalent wrapper NSRunLoop methods). When the limit is hit the OS >> terminates the Java app. The situation arises when a JavaFX app creates too >> many nested ev

Re: RFR: 8281384: Random chars on paste from Windows clipboard [v9]

2025-04-01 Thread Lukasz Kostyra
On Mon, 31 Mar 2025 17:48:50 GMT, Oliver Schmidtmer wrote: >> Windows programs may reuse a clipboard buffer that is larger than the new >> content. In this case de NUL terminator is not at the end of the buffer, but >> within it. >> The current implementation copys the whole buffer into a tex