Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests

2025-03-31 Thread Andy Goryachev
On Fri, 28 Mar 2025 21:00:47 GMT, Kevin Rushforth wrote: >> Introduce a facility, in the form of JUnit5 annotation, to allow for >> capturing a desktop screenshot of a failed test. >> >> The primary intent is to be able to debug an intermittent test case, rather >> than wholesale addition of t

Re: RFR: 8352999: [macOS] Conditional behavior by directly querying the Objective-C call stack

2025-03-31 Thread Andy Goryachev
On Mon, 31 Mar 2025 18:29:21 GMT, Martin Fox wrote: > Before a window is maximized glass records its existing size and location. > This rectangle is stored in native screen coordinates. Compared to Java > screen coordinates native coordinates are flipped along the Y axis. > > When the window i

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v2]

2025-03-31 Thread Andy Goryachev
On Fri, 28 Mar 2025 21:10:46 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - testing: inject a failure >> - review comments > > tests/system/src/test/java/test/util/ScreenCaptureTestWatche

Re: RFR: 8281384: Random chars on paste from Windows clipboard [v9]

2025-03-31 Thread Kevin Rushforth
On Mon, 31 Mar 2025 17:48:50 GMT, Oliver Schmidtmer wrote: >> Windows programs may reuse a clipboard buffer that is larger than the new >> content. In this case de NUL terminator is not at the end of the buffer, but >> within it. >> The current implementation copys the whole buffer into a tex

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests [v3]

2025-03-31 Thread Andy Goryachev
> Introduce a facility, in the form of JUnit5 annotation, to allow for > capturing a desktop screenshot of a failed test. > > The primary intent is to be able to debug an intermittent test case, rather > than wholesale addition of the new annotation to all the tests. > > A possible improvement

Re: RFR: 8351733: Crash when creating too many nested event loops [v7]

2025-03-31 Thread Kevin Rushforth
On Mon, 31 Mar 2025 17:49:59 GMT, Martin Fox wrote: >> There is an undocumented limit on nesting calls to CFRunLoopRun (or the >> equivalent wrapper NSRunLoop methods). When the limit is hit the OS >> terminates the Java app. The situation arises when a JavaFX app creates too >> many nested ev

RFR: 8352999: [macOS] Conditional behavior by directly querying the Objective-C call stack

2025-03-31 Thread Martin Fox
Before a window is maximized glass records its existing size and location. This rectangle is stored in native screen coordinates. Compared to Java screen coordinates native coordinates are flipped along the Y axis. When the window is un-maximized that native rectangle is passed to a routine tha

Re: RFR: 8319555: [TestBug] Utility for creating instruction window for manual tests

2025-03-31 Thread Andy Goryachev
On Mon, 31 Mar 2025 17:53:01 GMT, Martin Fox wrote: > It would be nice if all the manual tests did this Good idea. I might need some help with this though - this command line `java @build/testrun.args ./tests/manual/text/EmojiTest.java` fails because it cannot find ./tests/manual/text/Emoj

Re: RFR: 8351733: Crash when creating too many nested event loops [v7]

2025-03-31 Thread Andy Goryachev
On Mon, 31 Mar 2025 17:49:59 GMT, Martin Fox wrote: >> There is an undocumented limit on nesting calls to CFRunLoopRun (or the >> equivalent wrapper NSRunLoop methods). When the limit is hit the OS >> terminates the Java app. The situation arises when a JavaFX app creates too >> many nested ev

Re: RFR: 8319555: [TestBug] Utility for creating instruction window for manual tests

2025-03-31 Thread Martin Fox
On Fri, 28 Mar 2025 23:06:47 GMT, Andy Goryachev wrote: > The following command line expectedly fails because it can't find > `com.oracle.util.testing.ManualTestWindow`: > > ``` > java --module-path=build/sdk/lib --add-modules=javafx.controls > ./tests/manual/text/EmojiTest.java > ``` When I

Re: RFR: 8351733: Crash when creating too many nested event loops [v7]

2025-03-31 Thread Martin Fox
> There is an undocumented limit on nesting calls to CFRunLoopRun (or the > equivalent wrapper NSRunLoop methods). When the limit is hit the OS > terminates the Java app. The situation arises when a JavaFX app creates too > many nested event loops from within Platform.runLater runnables. > > T

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests

2025-03-31 Thread Andy Goryachev
On Fri, 28 Mar 2025 21:31:45 GMT, Kevin Rushforth wrote: >> tests/system/src/test/java/test/util/ScreenCaptureTestWatcher.java line 77: >> >>> 75: public void testFailed(ExtensionContext extensionContext, Throwable >>> err) { >>> 76: err.printStackTrace(); >>> 77: System.err

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests

2025-03-31 Thread Andy Goryachev
On Fri, 28 Mar 2025 21:04:00 GMT, Kevin Rushforth wrote: >> Introduce a facility, in the form of JUnit5 annotation, to allow for >> capturing a desktop screenshot of a failed test. >> >> The primary intent is to be able to debug an intermittent test case, rather >> than wholesale addition of t

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests

2025-03-31 Thread Kevin Rushforth
On Mon, 31 Mar 2025 14:58:11 GMT, Andy Goryachev wrote: >> tests/system/src/test/java/test/util/ScreenCaptureTestWatcher.java line 47: >> >>> 45: * >>> 46: * This facility takes a screenshot of any failed test, then logs the >>> base64-encoded screenshot >>> 47: * to {@code stderr}. >> >>

Re: RFR: 8328716: [TestBug] Screen capturing utility for failed tests

2025-03-31 Thread Andy Goryachev
On Fri, 28 Mar 2025 21:07:21 GMT, Kevin Rushforth wrote: >> Introduce a facility, in the form of JUnit5 annotation, to allow for >> capturing a desktop screenshot of a failed test. >> >> The primary intent is to be able to debug an intermittent test case, rather >> than wholesale addition of t

Re: RFR: 8351047: TitledPane should handle titles that are resizable [v2]

2025-03-31 Thread Andy Goryachev
On Sat, 29 Mar 2025 09:10:51 GMT, John Hendrikx wrote: >> This PR will forward more Label calculations to LabeledSkinBase, as they are >> quite complex, especially when a Graphic is involved which is a full-fledged >> `Node`. More specifically, this solves issues with TitledPane when the >> gr

Re: RFR: 8353163: [XWayland] Disable SwingNodePlatformExitCrashTest on wayland

2025-03-31 Thread Kevin Rushforth
On Fri, 28 Mar 2025 08:56:36 GMT, Jayathirth D V wrote: > SwingNodePlatformExitCrashTest hangs while running on wayland, we need to > skip this test on wayland until https://bugs.openjdk.org/browse/JDK-8350009 > is fixed. The hang we are seeing on Wayland Linux when running on some systems is