Re: RFR: 8351733: Crash when creating too many nested event loops [v3]

2025-03-27 Thread Michael Strauß
On Thu, 27 Mar 2025 22:19:29 GMT, Martin Fox wrote: > The docs on `canStartNestedEventLoop` describe its behavior already. I'm not > sure what further information would be useful. Would it be enough to add a > see also link? The exception being thrown is a behavior of `enterNestedEventLoop()`,

Re: RFR: 8351733: Crash when creating too many nested event loops [v3]

2025-03-27 Thread Martin Fox
On Wed, 26 Mar 2025 08:34:06 GMT, Michael Strauß wrote: >> Martin Fox has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Lower limit on run loop nesting > > In any case, this PR should at least add the following bits of information to > `P

Re: RFR: 8351733: Crash when creating too many nested event loops [v6]

2025-03-27 Thread Andy Goryachev
On Thu, 27 Mar 2025 21:59:52 GMT, Martin Fox wrote: >> There is an undocumented limit on nesting calls to CFRunLoopRun (or the >> equivalent wrapper NSRunLoop methods). When the limit is hit the OS >> terminates the Java app. The situation arises when a JavaFX app creates too >> many nested ev

Re: RFR: 8351733: Crash when creating too many nested event loops [v6]

2025-03-27 Thread Martin Fox
> There is an undocumented limit on nesting calls to CFRunLoopRun (or the > equivalent wrapper NSRunLoop methods). When the limit is hit the OS > terminates the Java app. The situation arises when a JavaFX app creates too > many nested event loops from within Platform.runLater runnables. > > T

Re: RFR: 8351733: Crash when creating too many nested event loops [v5]

2025-03-27 Thread Andy Goryachev
On Thu, 27 Mar 2025 19:39:23 GMT, Martin Fox wrote: >> modules/javafx.graphics/src/main/java/javafx/application/Platform.java line >> 305: >> >>> 303: * other than the JavaFX Application Thread. >>> 304: * >>> 305: * @throws RuntimeException if this call would exceed the maximum

Re: RFR: 8351733: Crash when creating too many nested event loops [v5]

2025-03-27 Thread Martin Fox
On Thu, 27 Mar 2025 17:33:23 GMT, Kevin Rushforth wrote: >> Martin Fox has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Removed unnecessary import >> - The max nested event loop constant is no longer public > > modules/javafx.graphics/

Re: RFR: 8351733: [macos] Crash when creating too many nested event loops [v5]

2025-03-27 Thread Kevin Rushforth
On Thu, 27 Mar 2025 15:21:09 GMT, Martin Fox wrote: >> There is an undocumented limit on nesting calls to CFRunLoopRun (or the >> equivalent wrapper NSRunLoop methods). When the limit is hit the OS >> terminates the Java app. The situation arises when a JavaFX app creates too >> many nested ev

Re: RFR: 8351733: [macos] Crash when creating too many nested event loops [v5]

2025-03-27 Thread Andy Goryachev
On Thu, 27 Mar 2025 15:21:09 GMT, Martin Fox wrote: >> There is an undocumented limit on nesting calls to CFRunLoopRun (or the >> equivalent wrapper NSRunLoop methods). When the limit is hit the OS >> terminates the Java app. The situation arises when a JavaFX app creates too >> many nested ev

Re: RFR: 8351733: [macos] Crash when creating too many nested event loops [v5]

2025-03-27 Thread Martin Fox
> There is an undocumented limit on nesting calls to CFRunLoopRun (or the > equivalent wrapper NSRunLoop methods). When the limit is hit the OS > terminates the Java app. The situation arises when a JavaFX app creates too > many nested event loops from within Platform.runLater runnables. > > T

Re: RFR: 8347359: RichTextArea API Tests [v5]

2025-03-27 Thread Andy Goryachev
On Wed, 26 Mar 2025 14:46:07 GMT, Andy Goryachev wrote: >> Additional RichTextArea API tests. > > Andy Goryachev has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 23 commits: > > - Merge remote-tracking branch 'origin/master' into 8

Re: RFR: 8350149: VBox ignores bias of child controls when fillWidth is set to false [v4]

2025-03-27 Thread Kevin Rushforth
On Mon, 24 Mar 2025 21:30:50 GMT, Andy Goryachev wrote: >> Yes, sorry, this was addressed in the larger discussion. I've left this >> as-is to keep the PR focus'd on one thing. >> >> The calculation here is using 3 snapped values, and one can reasonably >> assume the result is "nearly" snappe

Re: RFR: 8281384: Random chars on paste from Windows clipboard [v7]

2025-03-27 Thread Oliver Schmidtmer
On Thu, 27 Mar 2025 10:06:02 GMT, Lukasz Kostyra wrote: >> Oliver Schmidtmer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> readding flavors with changed mapping > > modules/javafx.graphics/src/main/native-glass/win/GlassClipboard.cpp l

JavaFX Metal: Second EA build available for Testing

2025-03-27 Thread Ambarish Rapte
Hello, The second Early Access(EA) build of JavaFX with the macOS Metal rendering pipeline is now available at: https://jdk.java.net/javafxmetal An important change in this release is that the ES2 and SW pipeline are now available for selection, though metal remains the default pipeline.

Re: RFR: 8281384: Random chars on paste from Windows clipboard [v7]

2025-03-27 Thread Lukasz Kostyra
On Wed, 26 Mar 2025 20:20:36 GMT, Oliver Schmidtmer wrote: >> Windows programs may reuse a clipboard buffer that is larger than the new >> content. In this case de NUL terminator is not at the end of the buffer, but >> within it. >> The current implementation copys the whole buffer into a tex