Re: RFR: 8351733: [macos] Crash when creating too many nested event loops

2025-03-21 Thread Andy Goryachev
On Fri, 21 Mar 2025 21:30:28 GMT, Andy Goryachev wrote: >> There is an undocumented limit on nesting calls to CFRunLoopRun (or the >> equivalent wrapper NSRunLoop methods). When the limit is hit the OS >> terminates the Java app. The situation arises when a JavaFX app creates too >> many neste

Re: RFR: 8335547: Support multi-line prompt text for TextArea

2025-03-21 Thread Ziad El Midaoui
On Tue, 18 Mar 2025 15:41:00 GMT, Ziad El Midaoui wrote: >> Added multi line prompt support for TextArea this will provide the ability >> to have multiple lines in textArea as expected, >> Also fixed tests to meet the new changes > > I did test the mentioned line separators without filtering an

Re: How to use jfx.incubator mdoules?

2025-03-21 Thread q
Hello, Thanks for the detailed answer! I completely forgot that JDK builds with JavaFX included exist, and that Zulu JDK has everything I need. Best Regards пт, 21 мар. 2025 г. в 21:05, Kevin Rushforth : > Hi, > > Johan can answer your question about publishing to maven central. I can > confirm

Re: RFR: 8351733: [macos] Crash when creating too many nested event loops

2025-03-21 Thread Jay Bhaskar
On Fri, 21 Mar 2025 20:56:01 GMT, Martin Fox wrote: > There is an undocumented limit on nesting calls to CFRunLoopRun (or the > equivalent wrapper NSRunLoop methods). When the limit is hit the OS > terminates the Java app. The situation arises when a JavaFX app creates too > many nested event

Re: RFR: 8351733: [macos] Crash when creating too many nested event loops

2025-03-21 Thread Andy Goryachev
On Fri, 21 Mar 2025 20:56:01 GMT, Martin Fox wrote: > There is an undocumented limit on nesting calls to CFRunLoopRun (or the > equivalent wrapper NSRunLoop methods). When the limit is hit the OS > terminates the Java app. The situation arises when a JavaFX app creates too > many nested event

Re: RFR: 8351733: [macos] Crash when creating too many nested event loops

2025-03-21 Thread Andy Goryachev
On Fri, 21 Mar 2025 20:56:01 GMT, Martin Fox wrote: > There is an undocumented limit on nesting calls to CFRunLoopRun (or the > equivalent wrapper NSRunLoop methods). When the limit is hit the OS > terminates the Java app. The situation arises when a JavaFX app creates too > many nested event

Re: RFR: 8351733: [macos] Crash when creating too many nested event loops

2025-03-21 Thread Kevin Rushforth
On Fri, 21 Mar 2025 20:56:01 GMT, Martin Fox wrote: > There is an undocumented limit on nesting calls to CFRunLoopRun (or the > equivalent wrapper NSRunLoop methods). When the limit is hit the OS > terminates the Java app. The situation arises when a JavaFX app creates too > many nested event

Re: RFR: 8347937: Canvas pattern test fails and crashes on WebKit 620.1

2025-03-21 Thread Kevin Rushforth
On Fri, 21 Mar 2025 08:17:39 GMT, Jay Bhaskar wrote: > Issue: > Ref: Webkit 619.1 > javafx.web/src/main/native/Source/WebCore/platform/graphics/ImageSource.cpp > refactoring in 620.1 > In the case of the canvas pattern using a transform property filled with an > SVGMatrix() > created by an SV

Re: RFR: 8347937: Canvas pattern test fails and crashes on WebKit 620.1

2025-03-21 Thread Kevin Rushforth
On Fri, 21 Mar 2025 08:17:39 GMT, Jay Bhaskar wrote: > Issue: > Ref: Webkit 619.1 > javafx.web/src/main/native/Source/WebCore/platform/graphics/ImageSource.cpp > refactoring in 620.1 > In the case of the canvas pattern using a transform property filled with an > SVGMatrix() > created by an SV

RFR: 8351733: [macos] Crash when creating too many nested event loops

2025-03-21 Thread Martin Fox
There is an undocumented limit on nesting calls to CFRunLoopRun (or the equivalent wrapper NSRunLoop methods). When the limit is hit the OS terminates the Java app. The situation arises when a JavaFX app creates too many nested event loops from within Platform.runLater runnables. This PR doesn

Re: RFR: 8335547: Support multi-line prompt text for TextArea [v2]

2025-03-21 Thread Andy Goryachev
On Fri, 21 Mar 2025 14:37:56 GMT, Ziad El Midaoui wrote: >> Added multi line prompt support for TextArea this will provide the ability >> to have multiple lines in textArea as expected, >> Also fixed tests to meet the new changes > > Ziad El Midaoui has updated the pull request incrementally wi

[jfx24u] Integrated: Merge jfx:jfx24

2025-03-21 Thread Kevin Rushforth
On Fri, 21 Mar 2025 17:47:48 GMT, Kevin Rushforth wrote: > Clean merge from `jfx:jfx24` branch to `jfx24u:master`. This is the final > merge to pick up the release notes for JavaFX 24. This pull request has now been integrated. Changeset: 4b94e821 Author:Kevin Rushforth URL: https:

Re: RFR: 8347937: Canvas pattern test fails on WebKit 620.1

2025-03-21 Thread Sergey Nazarkin
On Thu, 13 Mar 2025 18:17:53 GMT, Sergey Nazarkin wrote: > Hi! > > This is my desperate fix for what I believe to be a critical bug. Since my > knowledge of the codebase is minimal, and the class structure is a bit > controversial, my fix is mostly based on historical excavation. > > # What

[jfx24u] RFR: Merge jfx:jfx24

2025-03-21 Thread Kevin Rushforth
Clean merge from `jfx:jfx24` branch to `jfx24u:master`. This is the final merge to pick up the release notes for JavaFX 24. - Commit messages: - Merge remote-tracking branch 'jfx/jfx24' into merge-jfx-jfx24-to-master-2025-03-21 - 8350136: Create release notes for JavaFX 24 The me

Re: RFR: 8347937: Canvas pattern test fails and crashes on WebKit 620.1

2025-03-21 Thread Sergey Nazarkin
On Fri, 21 Mar 2025 12:40:21 GMT, Kevin Rushforth wrote: > > I see CanvasTest failure. But I guess it is unrelated > > ``` > > CanvasTest > testCanvasPattern() FAILED > > org.opentest4j.AssertionFailedError: First rect top-left ==> expected: > > <255> but was: <0> > > ``` > > @snazarkin Thi

Re: How to use jfx.incubator mdoules?

2025-03-21 Thread Kevin Rushforth
Hi, Johan can answer your question about publishing to maven central. I can confirm that the jar files for publication are being generated. Incubator modules are not in the list of transitive dependencies for any existing module -- nor should they be, since incubator modules must be explicit

How to use jfx.incubator mdoules?

2025-03-21 Thread quizy...@gmail.com
Hello, I'm very excited to try the recent incubated features. Thank you all for the great job! Could someone please explain how to use them? They are separate modules, but I don't see them published to Maven Central, and they aren't included as transitive dependencies for existing modules either.

Re: RFR: 8335547: Support multi-line prompt text for TextArea [v2]

2025-03-21 Thread Ziad El Midaoui
On Thu, 20 Mar 2025 20:03:54 GMT, Andy Goryachev wrote: >> In tests, and especially for assertions, wildcard imports are usually >> accepted. We use them all over the place. However, I would agree that >> symbols other than assertions should usually be fully qualified. > > good point I kept th

Re: RFR: 8347937: Canvas pattern test fails and crashes on WebKit 620.1

2025-03-21 Thread Sergey Nazarkin
On Fri, 21 Mar 2025 08:17:39 GMT, Jay Bhaskar wrote: > Issue: > Ref: Webkit 619.1 > javafx.web/src/main/native/Source/WebCore/platform/graphics/ImageSource.cpp > refactoring in 620.1 > In the case of the canvas pattern using a transform property filled with an > SVGMatrix() > created by an SV

Withdrawn: 8347937: Canvas pattern test fails on WebKit 620.1

2025-03-21 Thread Sergey Nazarkin
On Thu, 13 Mar 2025 18:17:53 GMT, Sergey Nazarkin wrote: > Hi! > > This is my desperate fix for what I believe to be a critical bug. Since my > knowledge of the codebase is minimal, and the class structure is a bit > controversial, my fix is mostly based on historical excavation. > > # What

Re: RFR: 8335547: Support multi-line prompt text for TextArea

2025-03-21 Thread Michael Strauß
On Wed, 19 Feb 2025 16:50:02 GMT, Ziad El Midaoui wrote: > Added multi line prompt support for TextArea this will provide the ability to > have multiple lines in textArea as expected, > Also fixed tests to meet the new changes I think that we should treat all _usual_ line separators in the sam

RFR: 8347937: Canvas pattern test fails and crashes on WebKit 620.1

2025-03-21 Thread Jay Bhaskar
Issue: Ref: Webkit 619.1 javafx.web/src/main/native/Source/WebCore/platform/graphics/ImageSource.cpp refactoring in 620.1 In the case of the canvas pattern using a transform property filled with an SVGMatrix() created by an SVG element, `frame.m_nativeImage->size()` calls `NativeImage::size()`