[jfx24u] RFR: 8351653: Webkit debug build failure after update to 620.1

2025-03-17 Thread Jay Bhaskar
A clean backport to jfx24u. This fixes debug build error on mac platform. - Commit messages: - Backport 99ee34fe6f82dddc554a32d09e88b9e43329045e Changes: https://git.openjdk.org/jfx24u/pull/13/files Webrev: https://webrevs.openjdk.org/?repo=jfx24u&pr=13&range=00 Issue: https://b

Re: RFR: 8313424: JavaFX controls in the title bar [v56]

2025-03-17 Thread Michael Strauß
On Mon, 17 Mar 2025 21:00:42 GMT, Andy Goryachev wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> enable preview features in tests > > modules/javafx.base/src/main/java/com/sun/javafx/PreviewFeature.java line 79:

Re: RFR: 8313424: JavaFX controls in the title bar [v56]

2025-03-17 Thread Andy Goryachev
On Mon, 17 Mar 2025 18:54:27 GMT, Michael Strauß wrote: >> Implementation of >> [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) >> and `EXTENDED_UTILITY` stage style. > > Michael Strauß has updated the pull request incrementally with one additional > commit since t

Re: RFR: 8313424: JavaFX controls in the title bar [v56]

2025-03-17 Thread Michael Strauß
> Implementation of > [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) > and `EXTENDED_UTILITY` stage style. Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: enable preview features in tests ---

Re: RFR: 8313424: JavaFX controls in the title bar [v54]

2025-03-17 Thread Michael Strauß
> Implementation of > [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) > and `EXTENDED_UTILITY` stage style. Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 70 commits: - add preview featu

Integrated: 8349373: Support JavaFX preview features

2025-03-17 Thread Michael Strauß
On Wed, 7 Feb 2024 20:05:01 GMT, Michael Strauß wrote: > This PR contains a definition of preview features for JavaFX, as well as a > helper class to verify that an application has opted into preview features. This pull request has now been integrated. Changeset: f5bdec5a Author:Michael St

Re: RFR: 8351264: Some images don't load with WebKit 620.1

2025-03-17 Thread Kevin Rushforth
On Mon, 17 Mar 2025 06:38:18 GMT, Jay Bhaskar wrote: > Issue: Some images don't load with WebKit 620.1 > > WebKit Image Decoding Failure Due to Unintended WebP Format Delivery > WebKit encounters image decoding failures when certain servers respond with > WebP images instead of the intended JPE

Re: RFR: 8351878: RichTextArea: Pasting from RTF doesn't apply formatting [v3]

2025-03-17 Thread Andy Goryachev
On Mon, 17 Mar 2025 15:21:14 GMT, Andy Goryachev wrote: >> Fixed two issues found in importing RTF text: >> >> - charset translation (brought back removed code) >> - missing font size attribute >> - missing strike-through attribute >> >> The charset issue was caused by my removal of the charact

Re: RFR: 8335547: Support multi-line prompt text for TextArea

2025-03-17 Thread Ziad El Midaoui
On Mon, 17 Mar 2025 14:58:16 GMT, Andy Goryachev wrote: > 3. cr \u000d --- Yes , this approach do not handle all the line Seperators only "\n" , I will change it to handle it all - PR Comment: https://git.openjdk.org/jfx/pull/1716#issuecomment-2730127082

Re: RFR: 8335547: Support multi-line prompt text for TextArea

2025-03-17 Thread Andy Goryachev
On Mon, 17 Mar 2025 16:23:11 GMT, Ziad El Midaoui wrote: >>> What happens if the text contains line breaks other than `\n` >> >> This is a good question. >> I guess it depends on what other characters cause line break in JavaFX. >> Wikipedia (https://en.wikipedia.org/wiki/Newline) specifies a fe

Re: RFR: 8351878: RichTextArea: Pasting from RTF doesn't apply formatting [v3]

2025-03-17 Thread Andy Goryachev
On Mon, 17 Mar 2025 15:21:14 GMT, Andy Goryachev wrote: >> Fixed two issues found in importing RTF text: >> >> - charset translation (brought back removed code) >> - missing font size attribute >> - missing strike-through attribute >> >> The charset issue was caused by my removal of the charact

Integrated: 8351264: Some images don't load with WebKit 620.1

2025-03-17 Thread Jay Bhaskar
On Mon, 17 Mar 2025 06:38:18 GMT, Jay Bhaskar wrote: > Issue: Some images don't load with WebKit 620.1 > > WebKit Image Decoding Failure Due to Unintended WebP Format Delivery > WebKit encounters image decoding failures when certain servers respond with > WebP images instead of the intended JPE

Re: RFR: 8351264: Some images don't load with WebKit 620.1

2025-03-17 Thread Jose Pereda
On Mon, 17 Mar 2025 15:08:00 GMT, Kevin Rushforth wrote: >> modules/javafx.web/src/main/native/Source/WebCore/loader/cache/CachedResourceRequest.cpp >> line 151: >> >>> 149: StringBuilder builder; >>> 150: // Java platform failing to decode webp image data already disabled in >>> 619.1

Re: RFR: 8351264: Some images don't load with WebKit 620.1

2025-03-17 Thread Jose Pereda
On Mon, 17 Mar 2025 06:38:18 GMT, Jay Bhaskar wrote: > Issue: Some images don't load with WebKit 620.1 > > WebKit Image Decoding Failure Due to Unintended WebP Format Delivery > WebKit encounters image decoding failures when certain servers respond with > WebP images instead of the intended JPE

Re: RFR: 8351264: Some images don't load with WebKit 620.1

2025-03-17 Thread Kevin Rushforth
On Mon, 17 Mar 2025 15:15:59 GMT, Jay Bhaskar wrote: >> Issue: Some images don't load with WebKit 620.1 >> >> WebKit Image Decoding Failure Due to Unintended WebP Format Delivery >> WebKit encounters image decoding failures when certain servers respond with >> WebP images instead of the intende

Re: RFR: 8351878: RichTextArea: Pasting from RTF doesn't apply formatting [v3]

2025-03-17 Thread Andy Goryachev
> Fixed two issues found in importing RTF text: > > - charset translation (brought back removed code) > - missing font size attribute > - missing strike-through attribute > > The charset issue was caused by my removal of the character decoder code > present in the original JDK RTF parser/reader.

Re: RFR: 8351264: Some images don't load with WebKit 620.1

2025-03-17 Thread Jay Bhaskar
On Mon, 17 Mar 2025 06:38:18 GMT, Jay Bhaskar wrote: > Issue: Some images don't load with WebKit 620.1 > > WebKit Image Decoding Failure Due to Unintended WebP Format Delivery > WebKit encounters image decoding failures when certain servers respond with > WebP images instead of the intended JPE

Re: RFR: 8351264: Some images don't load with WebKit 620.1

2025-03-17 Thread Kevin Rushforth
On Mon, 17 Mar 2025 13:46:06 GMT, Jose Pereda wrote: >> Issue: Some images don't load with WebKit 620.1 >> >> WebKit Image Decoding Failure Due to Unintended WebP Format Delivery >> WebKit encounters image decoding failures when certain servers respond with >> WebP images instead of the intende

Re: RFR: 8351264: Some images don't load with WebKit 620.1

2025-03-17 Thread Kevin Rushforth
On Mon, 17 Mar 2025 06:38:18 GMT, Jay Bhaskar wrote: > Issue: Some images don't load with WebKit 620.1 > > WebKit Image Decoding Failure Due to Unintended WebP Format Delivery > WebKit encounters image decoding failures when certain servers respond with > WebP images instead of the intended JPE

Re: RFR: 8351264: Some images don't load with WebKit 620.1

2025-03-17 Thread Jose Pereda
On Mon, 17 Mar 2025 06:38:18 GMT, Jay Bhaskar wrote: > Issue: Some images don't load with WebKit 620.1 > > WebKit Image Decoding Failure Due to Unintended WebP Format Delivery > WebKit encounters image decoding failures when certain servers respond with > WebP images instead of the intended JPE

Re: RFR: 8349373: Support JavaFX preview features [v6]

2025-03-17 Thread Andy Goryachev
On Sat, 15 Mar 2025 03:41:29 GMT, Michael Strauß wrote: >> This PR contains a definition of preview features for JavaFX, as well as a >> helper class to verify that an application has opted into preview features. > > Michael Strauß has updated the pull request incrementally with one additional

Re: RFR: 8351264: Some images don't load with WebKit 620.1

2025-03-17 Thread Kevin Rushforth
On Mon, 17 Mar 2025 06:38:18 GMT, Jay Bhaskar wrote: > Issue: Some images don't load with WebKit 620.1 > > WebKit Image Decoding Failure Due to Unintended WebP Format Delivery > WebKit encounters image decoding failures when certain servers respond with > WebP images instead of the intended JPE

Re: Resizing stage while it is maximized breaks scene size on Linux

2025-03-17 Thread Christopher Schnick
So on Windows at least, it will change the width temporarily and then revert back to the original width value. So you will receive two width change events if you listen to the stage width property. The maximized property is not changed. I guess this also not optimal handling of this. Ideally,

Re: Resizing stage while it is maximized breaks scene size on Linux

2025-03-17 Thread Thiago Milczarek Sayão
Hi Christopher, It seems like a simple fix. How does it behave on other platforms? Does it ignore the resize, restore the window to its unmaximized state before resizing, or keep it maximized while adjusting the unmaximized size. -- Thiago Em dom., 16 de mar. de 2025 às 05:25, Christopher

Re: RFR: 8350917: Allow parent nodes to provide CSS styleable properties for child nodes

2025-03-17 Thread John Hendrikx
On Mon, 17 Mar 2025 06:29:28 GMT, Michael Strauß wrote: > Your approach for this enhancement looks good. Do you plan to add styleable > properties for the other layout containers too? I would like to, I was thinking of doing that in a separate PR as there are quite a few (and I think they woul

Re: RFR: 8350917: Allow parent nodes to provide CSS styleable properties for child nodes

2025-03-17 Thread Michael Strauß
On Sun, 16 Mar 2025 21:29:31 GMT, John Hendrikx wrote: >> modules/javafx.graphics/src/main/java/javafx/css/Styleable.java line 101: >> >>> 99: * only for its direct children! >>> 100: * >>> 101: * @return an immutable list of CSS meta data, never {@code null} >> >> Since we don't