On Wed, 5 Mar 2025 07:01:42 GMT, Gopal Pattnaik wrote:
>> There was no test included with the fix for
>> [JDK-8326989](https://bugs.openjdk.org/browse/JDK-8326989),
>>
>> Hence we are adding a system test now.
>>
>> Test is written as
>> 1. Load html content in web view.
>> 2. pick the color
On Wed, 5 Mar 2025 18:27:29 GMT, John Hendrikx wrote:
>> This provides and uses a new implementation of `ExpressionHelper`, called
>> `ListenerManager` with improved semantics.
>>
>> # Behavior
>>
>> |Listener...|ExpressionHelper|ListenerManager|
>> |---|---|---|
>> |Invocation Order|In order
On Mon, 2 Dec 2024 14:34:08 GMT, Alexander Zvegintsev
wrote:
>> Thanks @azvegint. If the `int`-based dimensions are coupled with
>> `com.sun.javafx.geom.Rectangle` (and from the code, that's the only place
>> they are used at), would you object to making `Dimension` an inner class of
>> `Rect
On Wed, 5 Mar 2025 17:12:36 GMT, Alexander Zuev wrote:
>> Create implementation for Slider and Stepper accessibility protocols.
>> Fix mapping.
>> Fix performAction parameter type in declaration.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wrapped text
> needs a p
- synchronized `EventType::register()` method
- simplified internal constructor which is only used for `EventType.ROOT`
There should negligent impact on performance when `EventTypes` are created in
the FX Application Thread.
There might be a distant potential for a deadlock if the application wr
On Wed, 5 Mar 2025 18:16:11 GMT, danielpeintner wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Throw StackOverflowError if non-converging listener changes are detected
>
> modules/javafx.base/src/main/java/com/su
On Wed, 5 Mar 2025 18:06:26 GMT, John Hendrikx wrote:
>> This provides and uses a new implementation of `ExpressionHelper`, called
>> `ListenerManager` with improved semantics.
>>
>> # Behavior
>>
>> |Listener...|ExpressionHelper|ListenerManager|
>> |---|---|---|
>> |Invocation Order|In order
> This provides and uses a new implementation of `ExpressionHelper`, called
> `ListenerManager` with improved semantics.
>
> # Behavior
>
> |Listener...|ExpressionHelper|ListenerManager|
> |---|---|---|
> |Invocation Order|In order they were registered, invalidation listeners
> always before ch
On Wed, 5 Mar 2025 18:06:26 GMT, John Hendrikx wrote:
>> This provides and uses a new implementation of `ExpressionHelper`, called
>> `ListenerManager` with improved semantics.
>>
>> # Behavior
>>
>> |Listener...|ExpressionHelper|ListenerManager|
>> |---|---|---|
>> |Invocation Order|In order
> - enforced fx application thread
> - clarify doc where an `IllegalStateException` can get thrown, such as hide()
> and show()
> - clarified `ComboBoxBase::show`
> - added a headful test `TestThreadingRestrictions`
Andy Goryachev has updated the pull request with a new target base due to a
merg
> Allows MenuBar to be created in a background thread by delaying
> MenuBarSkin::rebuildUI() call until after the MenuBar becomes a part of the
> scene graph.
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrel
On Thu, 6 Feb 2025 19:26:25 GMT, Andy Goryachev wrote:
> Root Cause:
> (Multiple) properties are getting bound to the global
> `Platform.accessibilityActive` property. Binding (and I say, accessing) of
> properties is not thread-safe.
>
> I also changed the design a bit. Originally, every sym
On Wed, 5 Mar 2025 17:33:01 GMT, Andy Goryachev wrote:
> @hjohn thank you for help with `Subscription`. Do you have any other comments?
No, but admittedly I did not look beyond the subscription issue. I think Kevin
and Alexander have got you covered on this one :)
-
PR Comment: h
On Wed, 5 Mar 2025 17:12:36 GMT, Alexander Zuev wrote:
>> Create implementation for Slider and Stepper accessibility protocols.
>> Fix mapping.
>> Fix performAction parameter type in declaration.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the
> This provides and uses a new implementation of `ExpressionHelper`, called
> `ListenerManager` with improved semantics.
>
> # Behavior
>
> |Listener...|ExpressionHelper|ListenerManager|
> |---|---|---|
> |Invocation Order|In order they were registered, invalidation listeners
> always before ch
On Wed, 5 Mar 2025 15:47:30 GMT, Andy Goryachev wrote:
>> Yes, using a custom property, or a wrapper, would solve this particular
>> synchronization problem, although that wouldn't solve all of the problems.
>>
>> We would then be left with the problem that if the accessibility change
>> list
On Wed, 5 Mar 2025 17:12:36 GMT, Alexander Zuev wrote:
>> Create implementation for Slider and Stepper accessibility protocols.
>> Fix mapping.
>> Fix performAction parameter type in declaration.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the
On Tue, 4 Mar 2025 19:32:51 GMT, Andy Goryachev wrote:
>> Root Cause:
>> (Multiple) properties are getting bound to the global
>> `Platform.accessibilityActive` property. Binding (and I say, accessing) of
>> properties is not thread-safe.
>>
>> I also changed the design a bit. Originally, eve
On Wed, 5 Mar 2025 16:48:22 GMT, Andy Goryachev wrote:
> so the remaining question is whether it should announce "percent" of the
> slider position or the actual value?
Unfortunately we do not have any control on that. There is no way to tell
VoiceOver if it is percent or the raw value - VO de
Hi Glavo,
On 05/03/2025 17:09, Glavo wrote:
> Hi John,
>
> The above feedback is all for Windows, and we have not tested on other
> platforms yet.
Thanks for clarifying. I may be able to help a bit better then as I have
a similar setup.
>
> On Windows I really don't expect that
> setting
> Create implementation for Slider and Stepper accessibility protocols.
> Fix mapping.
> Fix performAction parameter type in declaration.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Remove duplicate code make accessibilityLabel
On Mon, 3 Mar 2025 16:54:08 GMT, Alexander Zuev wrote:
> Also, for Spinner, it says "Stepper", is this expected?
On macOS the control we call Spinner is called Stepper, there's no Spinner.
>From macOS UI guide: "A stepper is a two-segment control that people use to
>increase or decrease an inc
On Wed, 5 Mar 2025 16:47:06 GMT, Alexander Zuev wrote:
> Spinner is called Stepper
yep, that's what I suspected. thanks!
-
PR Comment: https://git.openjdk.org/jfx/pull/1226#issuecomment-2701509394
On Tue, 4 Mar 2025 19:32:51 GMT, Andy Goryachev wrote:
>> Root Cause:
>> (Multiple) properties are getting bound to the global
>> `Platform.accessibilityActive` property. Binding (and I say, accessing) of
>> properties is not thread-safe.
>>
>> I also changed the design a bit. Originally, eve
Hi John,
The above feedback is all for Windows, and we have not tested on other
platforms yet.
On Windows I really don't expect that
> setting pulse higher will do much (I posted this a few days ago on this
> list in response to your earlier inquiry)
In fact, setting the pulse higher does have
> Changed the StubTextLayout to use product PrismTextLayout with much
> simplified glyph layout (via stubbed fonts). The new layout assumes all the
> glyphs are squares of font size, while the bold type face produces wider
> glyphs (by 1 pixel). The default font size has changed from 10 to 12
On Wed, 26 Feb 2025 22:00:47 GMT, Andy Goryachev wrote:
>> Changed the StubTextLayout to use product PrismTextLayout with much
>> simplified glyph layout (via stubbed fonts). The new layout assumes all the
>> glyphs are squares of font size, while the bold type face produces wider
>> glyphs (
On Wed, 5 Mar 2025 00:26:12 GMT, Kevin Rushforth wrote:
>> Of course for a generic solution, we could provide a wrapper for properties,
>> or custom synchronized properties.
>
> Yes, using a custom property, or a wrapper, would solve this particular
> synchronization problem, although that woul
On Wed, 5 Mar 2025 07:01:42 GMT, Gopal Pattnaik wrote:
>> There was no test included with the fix for
>> [JDK-8326989](https://bugs.openjdk.org/browse/JDK-8326989),
>>
>> Hence we are adding a system test now.
>>
>> Test is written as
>> 1. Load html content in web view.
>> 2. pick the color
On Wed, 5 Mar 2025 07:01:42 GMT, Gopal Pattnaik wrote:
>> There was no test included with the fix for
>> [JDK-8326989](https://bugs.openjdk.org/browse/JDK-8326989),
>>
>> Hence we are adding a system test now.
>>
>> Test is written as
>> 1. Load html content in web view.
>> 2. pick the color
Hi Glavo,
On which platform is this? On Windows I really don't expect that
setting pulse higher will do much (I posted this a few days ago on this
list in response to your earlier inquiry). It may trigger more frames
to be rendered, but their animation times will not use correct values
resulting
On Wed, 5 Mar 2025 03:05:25 GMT, Nir Lisker wrote:
> Not really, except for maybe the first edge case where your opinion differs
> from the current behavior.
You mean the one where I said: "this PR should probably not silently allow this
but instead throw an exception" ?
I think that's worth
On Wed, 5 Mar 2025 07:41:50 GMT, Johan Vos wrote:
> mainly clean backport of
> https://github.com/openjdk/jfx/commit/6ec588c5635964769b354bce37e68d7a6c00985a
> (JDK-8315873)
>
> Reason for being non-clean:
> * we already applied 8350437
> * we don't have aarch64-mac
> * we don't have TEST_ONLY
On Wed, 5 Mar 2025 09:19:01 GMT, Johan Vos wrote:
> Hi all,
>
> This pull request contains a backport of commit f38ab33b from the openjdk/jfx
> repository.
>
> The commit being backported was authored by Jay Bhaskar on 25 Feb 2025 and
> was reviewed by Kevin Rushforth and Joeri Sykora.
>
> T
Hi all,
This pull request contains a backport of commit f38ab33b from the openjdk/jfx
repository.
The commit being backported was authored by Jay Bhaskar on 25 Feb 2025 and was
reviewed by Kevin Rushforth and Joeri Sykora.
Thanks!
-
Commit messages:
- Backport f38ab33b296de7b0bf
On Wed, 5 Mar 2025 08:42:31 GMT, Johan Vos wrote:
> Hi all,
>
> This pull request contains a backport of commit 065548d0 from the openjdk/jfx
> repository.
>
> The commit being backported was authored by Jay Bhaskar on 18 Feb 2025 and
> was reviewed by Kevin Rushforth.
>
> Thanks!
This pull
Hi all,
This pull request contains a backport of commit 065548d0 from the openjdk/jfx
repository.
The commit being backported was authored by Jay Bhaskar on 18 Feb 2025 and was
reviewed by Kevin Rushforth.
Thanks!
-
Commit messages:
- Backport 065548d09dd4909137343e7e9eb2d25a336
On Wed, 5 Mar 2025 08:17:16 GMT, Johan Vos wrote:
> Almost clean backport of JDK-8340322
> Manually changed:
>
> * build.gradle minor change
> *
> modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLElementStack.cpp
> because JDK-8344899 is not backported
> * modules/javafx.web/s
On Wed, 5 Mar 2025 08:17:16 GMT, Johan Vos wrote:
> Almost clean backport of JDK-8340322
> Manually changed:
>
> * build.gradle minor change
> *
> modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLElementStack.cpp
> because JDK-8344899 is not backported
> * modules/javafx.web/s
Almost clean backport of JDK-8340322
Manually changed:
* build.gradle minor change
*
modules/javafx.web/src/main/native/Source/WebCore/html/parser/HTMLElementStack.cpp
because JDK-8344899 is not backported
* modules/javafx.web/src/test/java/test/javafx/scene/web/CanvasTest.java
because JDK-8339
On Wed, 5 Mar 2025 07:41:50 GMT, Johan Vos wrote:
> mainly clean backport of
> https://github.com/openjdk/jfx/commit/6ec588c5635964769b354bce37e68d7a6c00985a
> (JDK-8315873)
>
> Reason for being non-clean:
> * we already applied 8350437
> * we don't have aarch64-mac
> * we don't have TEST_ONLY
42 matches
Mail list logo
