Integrated: 8349924: Additional WebKit 620.1 fixes from WebKitGTK 2.46.6

2025-02-24 Thread Jay Bhaskar
On Sat, 22 Feb 2025 02:31:58 GMT, Jay Bhaskar wrote: > WebkitGTK 2.46.6 has additional fixes for crash and rendering issue, the > crash fix is related to Skia CPU rendering which does not apply to JavaFX > Webkit. > This patch has been tested on Jenkins and there is no side effects introduced.

Re: RFR: 8349924: Additional WebKit 620.1 fixes from WebKitGTK 2.46.6 [v2]

2025-02-24 Thread Kevin Rushforth
On Mon, 24 Feb 2025 06:49:13 GMT, Jay Bhaskar wrote: >> WebkitGTK 2.46.6 has additional fixes for crash and rendering issue, the >> crash fix is related to Skia CPU rendering which does not apply to JavaFX >> Webkit. >> This patch has been tested on Jenkins and there is no side effects >> int

Re: RFR: 8350149: VBox ignores bias of child controls when fillWidth is set to false [v2]

2025-02-24 Thread Kevin Rushforth
On Mon, 24 Feb 2025 20:30:17 GMT, John Hendrikx wrote: >> Fixes the case where `VBox` will ignore the (horizontal) bias of a child >> when its fill width property is set to `false`. This manifests itself with >> labels that have their wrap text property set to `true`, and the container >> is

Re: RFR: 8349091: Charts: exception initializing in a background thread [v4]

2025-02-24 Thread Kevin Rushforth
On Thu, 20 Feb 2025 23:04:15 GMT, Andy Goryachev wrote: >> Root Cause: >> (Multiple) properties are getting bound to the global >> `Platform.accessibilityActive` property. Binding (and I say, accessing) of >> properties is not thread-safe. >> >> I also changed the design a bit. Originally, ev

Re: RFR: 8349091: Charts: exception initializing in a background thread [v2]

2025-02-24 Thread Kevin Rushforth
On Mon, 10 Feb 2025 18:41:07 GMT, Andy Goryachev wrote: >> tests/system/src/test/java/test/robot/javafx/scene/NodeInitializationStressTest.java >> line 186: >> >>> 184: accessChart(c); >>> 185: c.getData().setAll(createNumberSeries()); >>> 186: c.getData().se

Integrated: 8349472: Update copyright header for files modified in 2025

2025-02-24 Thread Ambarish Rapte
On Fri, 21 Feb 2025 17:39:03 GMT, Ambarish Rapte wrote: > Update copyright year in files updated in the year 2025. This pull request has now been integrated. Changeset: 0555fb25 Author:Ambarish Rapte URL: https://git.openjdk.org/jfx/commit/0555fb25a16b6b6705a42c6d8592cf1c6ddccc67 St

Re: RFR: 8350149: VBox ignores bias of child controls when fillWidth is set to false [v2]

2025-02-24 Thread Andy Goryachev
On Mon, 24 Feb 2025 20:30:17 GMT, John Hendrikx wrote: >> Fixes the case where `VBox` will ignore the (horizontal) bias of a child >> when its fill width property is set to `false`. This manifests itself with >> labels that have their wrap text property set to `true`, and the container >> is

Re: RFR: 8350149: VBox ignores bias of child controls when fillWidth is set to false [v2]

2025-02-24 Thread Andy Goryachev
On Mon, 24 Feb 2025 20:41:29 GMT, John Hendrikx wrote: >> modules/javafx.graphics/src/main/java/javafx/scene/layout/Region.java line >> 2044: >> >>> 2042: * # content width/heights: >>> 2043: * >>> 2044: * The space allocated to a child, minus its margins. These are >>> never -1

Re: RFR: 8349472: Update copyright header for files modified in 2025 [v2]

2025-02-24 Thread Andy Goryachev
On Mon, 24 Feb 2025 13:51:59 GMT, Ambarish Rapte wrote: >> Update copyright year in files updated in the year 2025. > > Ambarish Rapte has updated the pull request incrementally with two additional > commits since the last revision: > > - cp year 2025/2024 > - Revert "8349472: Update copyrigh

Re: RFR: 8349472: Update copyright header for files modified in 2025 [v2]

2025-02-24 Thread Kevin Rushforth
On Mon, 24 Feb 2025 13:51:59 GMT, Ambarish Rapte wrote: >> Update copyright year in files updated in the year 2025. > > Ambarish Rapte has updated the pull request incrementally with two additional > commits since the last revision: > > - cp year 2025/2024 > - Revert "8349472: Update copyrigh

Re: RFR: 8350149: VBox ignores bias of child controls when fillWidth is set to false [v2]

2025-02-24 Thread Andy Goryachev
On Mon, 24 Feb 2025 20:39:01 GMT, John Hendrikx wrote: >> modules/javafx.graphics/src/main/java/javafx/scene/layout/Region.java line >> 2020: >> >>> 2018: double baseline = child.getBaselineOffset(); >>> 2019: if (child.isResizable() && baseline == >>> BASELINE_OFFSET_S

Re: RFR: 8350149: VBox ignores bias of child controls when fillWidth is set to false [v2]

2025-02-24 Thread John Hendrikx
On Mon, 24 Feb 2025 17:19:58 GMT, Andy Goryachev wrote: >> John Hendrikx has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >> commi

Re: RFR: 8350149: VBox ignores bias of child controls when fillWidth is set to false [v2]

2025-02-24 Thread John Hendrikx
> Fixes the case where `VBox` will ignore the (horizontal) bias of a child when > its fill width property is set to `false`. This manifests itself with labels > that have their wrap text property set to `true`, and the container is not > wide enough to hold the text on a single line (in other w

Re: RFR: 8350149: VBox ignores bias of child controls when fillWidth is set to false

2025-02-24 Thread Andy Goryachev
On Sat, 22 Feb 2025 15:57:28 GMT, John Hendrikx wrote: > Fixes the case where `VBox` will ignore the (horizontal) bias of a child when > its fill width property is set to `false`. This manifests itself with labels > that have their wrap text property set to `true`, and the container is not >

Re: RFR: 8350149: VBox ignores bias of child controls when fillWidth is set to false

2025-02-24 Thread Andy Goryachev
On Sat, 22 Feb 2025 15:57:28 GMT, John Hendrikx wrote: > Fixes the case where `VBox` will ignore the (horizontal) bias of a child when > its fill width property is set to `false`. This manifests itself with labels > that have their wrap text property set to `true`, and the container is not >

[jfx21u] RFR: 8346228: Update GStreamer to 1.24.10

2025-02-24 Thread Sergey Nazarkin
8346228: Update GStreamer to 1.24.10 - Commit messages: - Backport 22035dec470756e03d254aa12c088876ae20497d Changes: https://git.openjdk.org/jfx21u/pull/89/files Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=89&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346228

Re: RFR: 8350048: Enforce threading restrictions for show and hide methods in Window, Control, and Skin

2025-02-24 Thread Kevin Rushforth
On Wed, 19 Feb 2025 20:39:19 GMT, Andy Goryachev wrote: > - enforced fx application thread > - added a headful test `TestThreadingRestrictions` > > ## Note to the Reviewers > > To avoid merge conflicts, the preferred order of integrations: > > #1697 > #1713 > #1717 Reviewers: @kevinrushfort

Re: RFR: 8349472: Update copyright header for files modified in 2025

2025-02-24 Thread Ambarish Rapte
On Fri, 21 Feb 2025 18:24:49 GMT, Kevin Rushforth wrote: > And we need to make sure that for those 5 commits, all of the files touched > have (at least) a 2024 date as the last modified year. > > @arapte will update. Thank you Kevin, Please review the updated files. As you guided, the files mo

Re: RFR: 8349472: Update copyright header for files modified in 2025 [v2]

2025-02-24 Thread Ambarish Rapte
> Update copyright year in files updated in the year 2025. Ambarish Rapte has updated the pull request incrementally with two additional commits since the last revision: - cp year 2025/2024 - Revert "8349472: Update copyright header for files modified in 2025" This reverts commit b3e048

Re: RFR: 8349924: Additional WebKit 620.1 fixes from WebKitGTK 2.46.6 [v2]

2025-02-24 Thread Joeri Sykora
On Mon, 24 Feb 2025 06:49:13 GMT, Jay Bhaskar wrote: >> WebkitGTK 2.46.6 has additional fixes for crash and rendering issue, the >> crash fix is related to Skia CPU rendering which does not apply to JavaFX >> Webkit. >> This patch has been tested on Jenkins and there is no side effects >> int