Re: RFR: 8349758: Memory leak in TreeTableView

2025-02-16 Thread Ambarish Rapte
On Tue, 11 Feb 2025 21:16:32 GMT, Andy Goryachev wrote: > ## Root Cause > > An event handler was installed on the root property without removing it when > the root changes. > > ## Solution > > Replaced the weak parts with a change listener to the root property to ensure > correct handling of

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v3]

2025-02-16 Thread John Hendrikx
On Sat, 1 Feb 2025 12:57:34 GMT, John Hendrikx wrote: >> This provides and uses a new implementation of `ExpressionHelper`, called >> `ListenerManager` with improved semantics. >> >> # Behavior >> >> |Listener...|ExpressionHelper|ListenerManager| >> |---|---|---| >> |Invocation Order|In order

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v3]

2025-02-16 Thread Nir Lisker
On Sat, 1 Feb 2025 12:57:34 GMT, John Hendrikx wrote: >> This provides and uses a new implementation of `ExpressionHelper`, called >> `ListenerManager` with improved semantics. >> >> # Behavior >> >> |Listener...|ExpressionHelper|ListenerManager| >> |---|---|---| >> |Invocation Order|In order

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v3]

2025-02-16 Thread Nir Lisker
On Sat, 1 Feb 2025 12:57:34 GMT, John Hendrikx wrote: >> This provides and uses a new implementation of `ExpressionHelper`, called >> `ListenerManager` with improved semantics. >> >> # Behavior >> >> |Listener...|ExpressionHelper|ListenerManager| >> |---|---|---| >> |Invocation Order|In order

Re: Styling HBox/VBox/GridPane child properties (hgrow, margin, columnIndex, etc)

2025-02-16 Thread Michael Strauß
> I took a bit of a closer look. Although I think I can provide real > properties, there will likely be quite a lot of edge cases with > properties created on demand, and which only should exist while a Node > lives under a certain Parent. I think this is the wrong framing of what these propertie

Re: Styling HBox/VBox/GridPane child properties (hgrow, margin, columnIndex, etc)

2025-02-16 Thread John Hendrikx
I took a bit of a closer look.  Although I think I can provide real properties, there will likely be quite a lot of edge cases with properties created on demand, and which only should exist while a Node lives under a certain Parent.  So, I think for an initial version, it would be best NOT to expos