Re: [External] : Re: Focus delegation API

2025-02-06 Thread Michael Strauß
> This PR uses an event dispatcher to provide a cleaner way of channeling > keyboard events to another node. I haven’t prototyped the code but I suspect > a Control could do this using the existing API without any changes to the > Node class. > This PR also provides an API to query a node’s dele

Re: RFR: 8349105: Pagination: exception initializing in a background thread

2025-02-06 Thread Kevin Rushforth
On Thu, 6 Feb 2025 20:43:54 GMT, Andy Goryachev wrote: > ## Root Cause > Animation gets started in a background thread, which causes the animation > handler to run in the FX application thread, thus creating simultaneous > access to the control's fields (list of children in this case). > > ##

Re: RFR: 8347392: Thread-unsafe implementation of c.s.j.scene.control.skin.Utils

2025-02-06 Thread Kevin Rushforth
On Thu, 30 Jan 2025 23:35:05 GMT, Andy Goryachev wrote: > Thread-safe and re-entrant implementation of Utils. > > The new code still uses the static instances of Text and TextLayout for > performance reasons, but adds a thread-safe mechanism to keep track of > whether any of the instances is i

RFR: 8349098: TabPane: exception initializing in a background thread

2025-02-06 Thread Andy Goryachev
## Root Cause Animation gets started in a background thread, which causes the animation handler to run in the FX application thread, thus creating simultaneous access to the control's fields (list of children in this case). ## Solution Skip the animation. The fix is similar to https://github.co

Re: RFR: 8347392: Thread-unsafe implementation of c.s.j.scene.control.skin.Utils

2025-02-06 Thread Andy Goryachev
On Thu, 30 Jan 2025 23:35:05 GMT, Andy Goryachev wrote: > Thread-safe and re-entrant implementation of Utils. > > The new code still uses the static instances of Text and TextLayout for > performance reasons, but adds a thread-safe mechanism to keep track of > whether any of the instances is i

RFR: 8349105: Pagination: exception initializing in a background thread

2025-02-06 Thread Andy Goryachev
## Root Cause Animation gets started in a background thread, which causes the animation handler to run in the FX application thread, thus creating simultaneous access to the control's fields (list of children in this case). ## Solution Postpone the animation unless running in the FX application

Re: RFR: 8349091: Charts: exception initializing in a background thread

2025-02-06 Thread Kevin Rushforth
On Thu, 6 Feb 2025 19:26:25 GMT, Andy Goryachev wrote: > Root Cause: > (Multiple) properties are getting bound to the global > `Platform.accessibilityActive` property. Binding (and I say, accessing) of > properties is not thread-safe. > > I also changed the design a bit. Originally, every sym

Bug: Impossible to load 2+ independent applications if both are using the same JFX version (Windows, JFX 23.0.2+3)

2025-02-06 Thread Cormac Redmond
Hi, I have found a "serious" bug, where two completely independent JFX applications, both with their own embedded runtime (built with jlink & jpackage) & using the same JavaFX version, are unable to run simultaneously, because of the JFX cache -- at least on Windows. When trying to run any applic

RFR: 8349091: Charts: exception initializing in a background thread

2025-02-06 Thread Andy Goryachev
Root Cause: (Multiple) properties are getting bound to the global `Platform.accessibilityActive` property. Binding (and I say, accessing) of properties is not thread-safe. I also changed the design a bit. Originally, every symbol in a chart had its `focusTraversableProperty` bound to `Platform

Re: RFR: 8337960: Improve performance of mfwrapper by reusing GStreamer media buffers for decoded video

2025-02-06 Thread Kevin Rushforth
On Wed, 5 Feb 2025 03:00:17 GMT, Alexander Matveev wrote: > - Added new class `CMFGSTBuffer` which can allocate memory internally or > provide GStreamer allocated memory to Media Foundation. > - Added `GstBufferPool` to limit allocation of output buffers used for > rendering (memory will not be

RFR: 8348100: Tooltips cannot be instantiated on background thread

2025-02-06 Thread Andy Goryachev
Navigating up the parent hierarchy during CSS processing in a background thread encounters a null parent, causing a NPE. - Commit messages: - Merge remote-tracking branch 'origin/master' into 8348100.tootlip.thread.safety - cleanup - tooltip test - Merge branch '8348423.node.thr

Re: [External] : Re: Focus delegation API

2025-02-06 Thread Martin Fox
Michael, I’m (finally) looking at how this proposal could be extended to cover InputMethod events and have a few questions. In particular I want to verify that focus delegation needs to be in Node and not in, say, Control. This PR uses an event dispatcher to provide a cleaner way of channeling

JavaFX 24 is in Rampdown Phase Two (RDP2)

2025-02-06 Thread Kevin Rushforth
To: JavaFX Developers As a reminder, JavaFX 24 is now in Rampdown Phase Two (RDP2). [1] P1-P2 bug fixes, and test or doc fixes of any priority, can be fixed during RDP2. Explicit approval is needed for all bug fixes and enhancements (except for doc and test fixes) to go in to the jfx24 branch

Re: RFR: 8277000: Tree-/TableRowSkin: replace listener to fixedCellSize by live lookup [v3]

2025-02-06 Thread Marius Hanl
> This PR improves the `Tree-/TableRowSkin` code by doing a normal live lookup > for the `fixedCellSize` instead of adding listener just to update > variables(`fixedCellSizeEnabled` and `fixedCellSize`) which can otherwise be > also just lookup'd without the hassle of listeners. > > While this

[jfx21u] Integrated: 8336940: Update GStreamer to 1.24.6

2025-02-06 Thread Johan Vos
On Thu, 6 Feb 2025 07:55:06 GMT, Johan Vos wrote: > Hi all, > > This pull request contains a backport of commit b88ac049 from the openjdk/jfx > repository. > > The commit being backported was authored by Alexander Matveev on 23 Aug 2024 > and was reviewed by Kevin Rushforth and Joeri Sykora.