Re: RFR: 8185887: TableRowSkinBase fails to correctly virtualize cells in horizontal direction [v4]

2025-01-21 Thread Andy Goryachev
On Sun, 19 Jan 2025 12:43:51 GMT, henrykdz wrote: > The only thing I can do is reupload it somewhere. If the video is small enough it can be added to the ticket. Alternatively, you could attach two frame grabs - one with and one without the problem. Otherwise no one can see what you were tal

Re: MacOS: Title bar flickering when animation is playing

2025-01-21 Thread Andy Goryachev
Dear Pascal: I cannot see the flicker (macOS 15.1.1 M1, using the laptop retina monitor with scale=2 or the external monitor at scale=1), running the latest JFX master branch. Actually, I don't see much change except for the button - the inner shadow of the window background looks unchanged. C

[jfx17u] Integrated: Merge 509b8695024b6d1e26bbb0360a41365bf19ac3e9

2025-01-21 Thread Johan Vos
On Tue, 21 Jan 2025 17:19:28 GMT, Johan Vos wrote: > The patch for dshowwrapper for 17u requires one different line compared to > the one for 21u. I accidentally pushed the wrong branch first. This PR fixes > that. This pull request has now been integrated. Changeset: d95ee3b8 Author:Joha

Re: [jfx17u] RFR: Merge 509b8695024b6d1e26bbb0360a41365bf19ac3e9 [v2]

2025-01-21 Thread Kevin Rushforth
On Tue, 21 Jan 2025 17:28:53 GMT, Johan Vos wrote: >> The patch for dshowwrapper for 17u requires one different line compared to >> the one for 21u. I accidentally pushed the wrong branch first. This PR fixes >> that. > > Johan Vos has updated the pull request with a new target base due to a me

Re: [jfx17u] RFR: Merge 509b8695024b6d1e26bbb0360a41365bf19ac3e9 [v2]

2025-01-21 Thread Johan Vos
> The patch for dshowwrapper for 17u requires one different line compared to > the one for 21u. I accidentally pushed the wrong branch first. This PR fixes > that. Johan Vos has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrel

[jfx17u] RFR: Merge 509b8695024b6d1e26bbb0360a41365bf19ac3e9

2025-01-21 Thread Johan Vos
The patch for dshowwrapper for 17u requires one different line compared to the one for 21u. I accidentally pushed the wrong branch first. This PR fixes that. - Commit messages: - fix windows compiling issue The merge commit only contains trivial merges, so no merge-specific webrevs

[jfx24] Integrated: Merge ecec2645a99a9c1343ddf08c4009df578d5b2165

2025-01-21 Thread Kevin Rushforth
On Tue, 21 Jan 2025 14:59:01 GMT, Kevin Rushforth wrote: > Clean merge of January CPU content into ~~jfx:master~~ `jfx:jfx24`. > > Reviewer: @johanvos This pull request has now been integrated. Changeset: 0759447b Author:Kevin Rushforth URL: https://git.openjdk.org/jfx/commit/07594

[jfx23u] Integrated: 8347616: Create release notes for JavaFX 23.0.2

2025-01-21 Thread Kevin Rushforth
On Mon, 13 Jan 2025 19:02:33 GMT, Kevin Rushforth wrote: > Release notes for JavaFX 23.0.2. > > Notes to reviewers: > > I used the following filter to pick the issues: > > https://bugs.openjdk.org/issues/?filter=47027 > > The original filter, with the backport IDs, is here: > > https://bugs.

Re: [jfx24] RFR: Merge ecec2645a99a9c1343ddf08c4009df578d5b2165 [v2]

2025-01-21 Thread Kevin Rushforth
On Tue, 21 Jan 2025 15:57:12 GMT, Andy Goryachev wrote: > > I messed up the target branch > > please also force push the master branch. No. This PR has been intentionally retargeted to `jfx24` branch. It now has nothing to do with `master`. > (I guess this merge was the reason github greeted

Re: [jfx23u] RFR: 8347616: Create release notes for JavaFX 23.0.2 [v2]

2025-01-21 Thread Johan Vos
On Tue, 21 Jan 2025 15:05:29 GMT, Kevin Rushforth wrote: >> Release notes for JavaFX 23.0.2. >> >> Notes to reviewers: >> >> I used the following filter to pick the issues: >> >> https://bugs.openjdk.org/issues/?filter=47027 >> >> The original filter, with the backport IDs, is here: >> >> ht

Re: [jfx24] RFR: Merge ecec2645a99a9c1343ddf08c4009df578d5b2165 [v2]

2025-01-21 Thread Andy Goryachev
On Tue, 21 Jan 2025 15:48:31 GMT, Kevin Rushforth wrote: > I messed up the target branch please also force push the master branch. (I guess this merge was the reason github greeted me with the label "11 commits behind" message this morning) - PR Comment: https://git.openjdk.org/jf

Re: [jfx24] RFR: Merge ecec2645a99a9c1343ddf08c4009df578d5b2165 [v2]

2025-01-21 Thread Kevin Rushforth
On Tue, 21 Jan 2025 15:44:23 GMT, Johan Vos wrote: >> Kevin Rushforth has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 11 additional >> commits s

Re: [jfx24] RFR: Merge ecec2645a99a9c1343ddf08c4009df578d5b2165 [v2]

2025-01-21 Thread Kevin Rushforth
> Clean merge of January CPU content into ~~jfx:master~~ `jfx:jfx24`. > > Reviewer: @johanvos Kevin Rushforth has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request co

Re: [jfx24] RFR: Merge ecec2645a99a9c1343ddf08c4009df578d5b2165 [v2]

2025-01-21 Thread Johan Vos
On Tue, 21 Jan 2025 15:50:52 GMT, Kevin Rushforth wrote: >> Clean merge of January CPU content into ~~jfx:master~~ `jfx:jfx24`. >> >> Reviewer: @johanvos > > Kevin Rushforth has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unr

Re: RFR: Merge ecec2645a99a9c1343ddf08c4009df578d5b2165

2025-01-21 Thread Johan Vos
On Tue, 21 Jan 2025 14:59:01 GMT, Kevin Rushforth wrote: > Clean merge of January CPU content into `jfx:master`. > > Reviewer: @johanvos Marked as reviewed by jvos (Reviewer). - PR Review: https://git.openjdk.org/jfx/pull/1680#pullrequestreview-2565025178

[jfx21u] Integrated: Merge 69f4bd3cf86f3dead821352850de205594a368e2

2025-01-21 Thread Johan Vos
On Tue, 21 Jan 2025 15:15:11 GMT, Johan Vos wrote: > 2025-jan cpu content for jfx21u > Reviewer: @kevinrushforth This pull request has now been integrated. Changeset: 5ad44274 Author:Johan Vos URL: https://git.openjdk.org/jfx21u/commit/5ad442749972f73caf4aa320106d9a25e866addc Stats:

Re: [jfx21u] Integrated: Merge 69f4bd3cf86f3dead821352850de205594a368e2

2025-01-21 Thread Kevin Rushforth
On Tue, 21 Jan 2025 15:15:11 GMT, Johan Vos wrote: > 2025-jan cpu content for jfx21u > Reviewer: @kevinrushforth The content looks good. You'll need to change the title of your merge request to one of the following: `Merge 69f4bd3cf86f3dead821352850de205594a368e2` -- if you want the two merge

[jfx21u] Integrated: Merge 69f4bd3cf86f3dead821352850de205594a368e2

2025-01-21 Thread Johan Vos
2025-jan cpu content for jfx21u Reviewer: @kevinrushforth - Commit messages: The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jfx21u/pull/86/files Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0

Re: [jfx17u] Integrated: Merge 3093c30cdb37f862d7855dd766125f871717e3b3

2025-01-21 Thread Kevin Rushforth
On Tue, 21 Jan 2025 15:12:10 GMT, Johan Vos wrote: > 2025-jan cpu content for jfx17u > Reviewer: @kevinrushforth The content looks good. You'll need to change the title of your merge request to one of the following: `Merge 8def0626d411b8cada4a11cd44da386251c0dd43` -- if you want the two merge

[jfx17u] Integrated: Merge 3093c30cdb37f862d7855dd766125f871717e3b3

2025-01-21 Thread Johan Vos
On Tue, 21 Jan 2025 15:12:10 GMT, Johan Vos wrote: > 2025-jan cpu content for jfx17u > Reviewer: @kevinrushforth This pull request has now been integrated. Changeset: 53cc2693 Author:Johan Vos URL: https://git.openjdk.org/jfx17u/commit/53cc2693e8a7a779383001928955e65fbd33eca2 Stats:

[jfx17u] Integrated: Merge 3093c30cdb37f862d7855dd766125f871717e3b3

2025-01-21 Thread Johan Vos
2025-jan cpu content for jfx17u Reviewer: @kevinrushforth - Commit messages: - Merge branch 'master' into cpu-25-01 - Merge branch 'master' into cpu-25-01 - 8335715: Improve Direct Show support - [PATCH] 8335714: Enhance playing MP3s The merge commit only contains trivial merges,

Re: [jfx23u] RFR: 8347616: Create release notes for JavaFX 23.0.2 [v2]

2025-01-21 Thread Kevin Rushforth
On Tue, 21 Jan 2025 15:05:29 GMT, Kevin Rushforth wrote: >> Release notes for JavaFX 23.0.2. >> >> Notes to reviewers: >> >> I used the following filter to pick the issues: >> >> https://bugs.openjdk.org/issues/?filter=47027 >> >> The original filter, with the backport IDs, is here: >> >> ht

[jfx23u] Integrated: Merge 397d3c3548a584927c334bc214e216fff2317f5b

2025-01-21 Thread Kevin Rushforth
On Tue, 21 Jan 2025 15:00:07 GMT, Kevin Rushforth wrote: > Clean merge of January CPU content into `jfx23u:master`. > > Reviewer: @johanvos This pull request has now been integrated. Changeset: aa2fcda7 Author:Kevin Rushforth URL: https://git.openjdk.org/jfx23u/commit/aa2fcda70b18f

Re: [jfx23u] RFR: Merge 397d3c3548a584927c334bc214e216fff2317f5b [v2]

2025-01-21 Thread Kevin Rushforth
> Clean merge of January CPU content into `jfx23u:master`. > > Reviewer: @johanvos Kevin Rushforth has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. - Changes: - a

Integrated: Merge ecec2645a99a9c1343ddf08c4009df578d5b2165

2025-01-21 Thread Kevin Rushforth
On Tue, 21 Jan 2025 14:59:04 GMT, Kevin Rushforth wrote: > Clean merge of January CPU content into `jfx:jfx24`. > > Reviewer: @johanvos This pull request has now been integrated. Changeset: f2f5639c Author:Kevin Rushforth URL: https://git.openjdk.org/jfx/commit/f2f5639c243dada1a25f

Re: RFR: Merge ecec2645a99a9c1343ddf08c4009df578d5b2165

2025-01-21 Thread Johan Vos
On Tue, 21 Jan 2025 14:59:04 GMT, Kevin Rushforth wrote: > Clean merge of January CPU content into `jfx:jfx24`. > > Reviewer: @johanvos content looks ok - Marked as reviewed by jvos (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/1681#pullrequestreview-2564926374

Re: [jfx23u] RFR: Merge 397d3c3548a584927c334bc214e216fff2317f5b

2025-01-21 Thread Johan Vos
On Tue, 21 Jan 2025 15:00:07 GMT, Kevin Rushforth wrote: > Clean merge of January CPU content into `jfx23u:master`. > > Reviewer: @johanvos Marked as reviewed by jvos (Reviewer). - PR Review: https://git.openjdk.org/jfx23u/pull/36#pullrequestreview-2564927855

Re: [jfx23u] RFR: Merge 397d3c3548a584927c334bc214e216fff2317f5b

2025-01-21 Thread Kevin Rushforth
On Tue, 21 Jan 2025 15:00:07 GMT, Kevin Rushforth wrote: > Clean merge of January CPU content into `jfx23u:master`. > > Reviewer: @johanvos @johanvos I'll add the 23.0.2 tags shortly after I integrate this PR. - PR Comment: https://git.openjdk.org/jfx23u/pull/36#issuecomment-26049

[jfx23u] RFR: Merge 397d3c3548a584927c334bc214e216fff2317f5b

2025-01-21 Thread Kevin Rushforth
Clean merge of January CPU content into `jfx23u:master`. Reviewer: @johanvos - Commit messages: - Merge - Merge - Merge - Merge - Merge - Merge - 8335714: Enhance playing MP3s - 8335715: Improve Direct Show support - Merge - 8336631: Update JavaFX release version for Jan 20

Re: [jfx23u] RFR: 8347616: Create release notes for JavaFX 23.0.2

2025-01-21 Thread Kevin Rushforth
On Mon, 13 Jan 2025 19:02:33 GMT, Kevin Rushforth wrote: > Release notes for JavaFX 23.0.2. > > Notes to reviewers: > > I used the following filter to pick the issues: > > https://bugs.openjdk.org/issues/?filter=47027 > > The original filter, with the backport IDs, is here: > > https://bugs.

Re: [jfx23u] RFR: 8347616: Create release notes for JavaFX 23.0.2 [v2]

2025-01-21 Thread Kevin Rushforth
> Release notes for JavaFX 23.0.2. > > Notes to reviewers: > > I used the following filter to pick the issues: > > https://bugs.openjdk.org/issues/?filter=47027 > > The original filter, with the backport IDs, is here: > > https://bugs.openjdk.org/issues/?filter=47026 > > As usual, I excluded

RFR: Merge ecec2645a99a9c1343ddf08c4009df578d5b2165

2025-01-21 Thread Kevin Rushforth
Clean merge of January CPU content into `jfx:master`. Reviewer: @johanvos - Commit messages: - Merge branch 'jfx25-cpu-2501' into merge-jfx25-cpu-2501 - Merge - Merge - Merge - Merge - Merge - Merge - Merge - Merge - 8335714: Enhance playing MP3s - ... and 1 more: https://

RFR: Merge ecec2645a99a9c1343ddf08c4009df578d5b2165

2025-01-21 Thread Kevin Rushforth
Clean merge of January CPU content into `jfx:jfx24`. Reviewer: @johanvos - Commit messages: - Merge branch 'jfx24-cpu-2501' into merge-jfx24-cpu-2501 - Merge - Merge - Merge - Merge - Merge - Merge - Merge - Merge - 8335714: Enhance playing MP3s - ... and 1 more: https://g