Re: RFR: 8313424: JavaFX controls in the title bar [v37]

2025-01-14 Thread Michael Strauß
> Implementation of > [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) > and `EXTENDED_UTILITY` stage style. Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 46 commits: - Merge branch 'mas

RFR: 8347753: VetoableListDecorator doesn't accept its own sublists for bulk operations

2025-01-14 Thread Michael Strauß
Passing a `VetoableListDecorator.subList()` to any of its bulk operations (`addAll`, `setAll`, `removeAll`, `retainAll`) throws `ConcurrentModificationException`. The reason is that the `VetoableListDecorator.modCount` field is incremented before the underlying list's bulk operation is invoked,

RFR: 8347752: Running RichTextArea demos via ant on JDK 24 prints warnings

2025-01-14 Thread Andy Goryachev
added --enable-native-access=javafx.graphics --sun-misc-unsafe-memory-access=allow flags to the command line which starts the demos. - Commit messages: - 8347752: Running RichTextArea demos via ant on JDK 24 prints warnings Changes: https://git.openjdk.org/jfx/pull/1678/files We

Re: RFR: 8185887: TableRowSkinBase fails to correctly virtualize cells in horizontal direction [v4]

2025-01-14 Thread Andy Goryachev
On Thu, 19 Dec 2024 16:03:02 GMT, Marius Hanl wrote: >> This PR fixes the horizontal virtualization performed in the >> `TableRowSkinBase`, which significantly improves performance with many >> columns (and thus many cells). Scrolling up and down as well as scrolling >> left and right feels mu

Integrated: 8288893: Popup and its subclasses cannot input text from InputMethod

2025-01-14 Thread Martin Fox
On Mon, 11 Nov 2024 17:57:30 GMT, Martin Fox wrote: > Input methods don’t work for text controls inside Popups. This PR fixes that. > > Some background: > > A PopupWindow always has an owner. The owner of the first Popup is a standard > Window; I’ll refer to that as the root window. But a popu

Re: RFR: 8347715: RichTextArea Follow-up: Minor Bugs [v2]

2025-01-14 Thread Kevin Rushforth
On Tue, 14 Jan 2025 16:10:00 GMT, Andy Goryachev wrote: >> Found during writing the API tests: >> >> - setUseContentHeight/Width (true -> on) > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > revert nullable change LGTM.

Re: RFR: 8347715: RichTextArea Follow-up: Minor Bugs [v2]

2025-01-14 Thread Andy Goryachev
> Found during writing the API tests: > > - setUseContentHeight/Width (true -> on) Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision: revert nullable change - Changes: - all: https://git.openjdk.org/jfx/pull/1676/files

Re: RFR: 8347715: RichTextArea Follow-up: Minor Bugs [v2]

2025-01-14 Thread Andy Goryachev
On Tue, 14 Jan 2025 15:50:49 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> revert nullable change > > modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/RichT

Re: RFR: 8347715: RichTextArea Follow-up: Minor Bugs

2025-01-14 Thread Kevin Rushforth
On Tue, 14 Jan 2025 15:41:38 GMT, Andy Goryachev wrote: > Found during writing the API tests: > > - setUseContentHeight/Width (true -> on) > - remove unnecessary non-nullable limitation for caretBlinkProperty The change to setUseContentWidth / Height is an obviously correct fix. I am not in fa

RFR: 8347715: RichTextArea Follow-up: Minor Bugs

2025-01-14 Thread Andy Goryachev
Found during writing the API tests: - setUseContentHeight/Width (true -> on) - remove unnecessary non-nullable limitation for caretBlinkProperty - Commit messages: - 8347715: RichTextArea Follow-up: Minor Bugs Changes: https://git.openjdk.org/jfx/pull/1676/files Webrev: https://w

Re: RFR: 8288893: Popup and its subclasses cannot input text from InputMethod [v3]

2025-01-14 Thread Kevin Rushforth
On Fri, 22 Nov 2024 22:14:12 GMT, Martin Fox wrote: >> I'll take a look at it after Thanksgiving. >> >> Somewhat related questions (sorry if totally unrelated): >> >> Q1. shouldn't the input method be tied to the `Scene.focusOwner` property >> somehow? >> Q2. given the fact that there could be

Re: [jfx23u] RFR: 8347616: Create release notes for JavaFX 23.0.2

2025-01-14 Thread Kevin Rushforth
On Tue, 14 Jan 2025 07:25:52 GMT, Abhinay Agarwal wrote: > Is https://bugs.openjdk.org/browse/JDK-8341686 not a part of the release > notes as it is a "Task" and doesn't fall under "Bug" or "Enhancement"? Correct. - PR Comment: https://git.openjdk.org/jfx23u/pull/35#issuecomment-2