Re: RFR: 8301121: RichTextArea Control (Incubator) [v65]

2024-12-18 Thread Ambarish Rapte
On Tue, 17 Dec 2024 21:06:16 GMT, Andy Goryachev wrote: >> Incubating a new feature - rich text control, **RichTextArea**, intended to >> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. >> The main design goal is to provide a control that is complete enough to be >> u

Re: RFR: 8343398: Add reducedData preference [v8]

2024-12-18 Thread Michael Strauß
> The `reducedData` preference instructs applications to minimize internet > traffic, as users might be on a metered network or a limited data plan. > > This corresponds to the following OS settings: > > Windows: Settings -> Network and Internet -> Ethernet/WiFi -> Metered > connection > macOS:

Re: RFR: 8343398: Add reducedData preference [v7]

2024-12-18 Thread Kevin Rushforth
On Wed, 18 Dec 2024 20:52:59 GMT, Michael Strauß wrote: >> The `reducedData` preference instructs applications to minimize internet >> traffic, as users might be on a metered network or a limited data plan. >> >> This corresponds to the following OS settings: >> >> Windows: Settings -> Network

Re: RFR: 8343398: Add reducedData preference [v7]

2024-12-18 Thread Andy Goryachev
On Wed, 18 Dec 2024 20:52:59 GMT, Michael Strauß wrote: >> The `reducedData` preference instructs applications to minimize internet >> traffic, as users might be on a metered network or a limited data plan. >> >> This corresponds to the following OS settings: >> >> Windows: Settings -> Network

Re: RFR: 8343398: Add reducedData preference [v7]

2024-12-18 Thread Kevin Rushforth
On Wed, 18 Dec 2024 20:52:59 GMT, Michael Strauß wrote: >> The `reducedData` preference instructs applications to minimize internet >> traffic, as users might be on a metered network or a limited data plan. >> >> This corresponds to the following OS settings: >> >> Windows: Settings -> Network

Re: RFR: 8343398: Add reducedData preference [v7]

2024-12-18 Thread Michael Strauß
On Wed, 18 Dec 2024 20:52:59 GMT, Michael Strauß wrote: >> The `reducedData` preference instructs applications to minimize internet >> traffic, as users might be on a metered network or a limited data plan. >> >> This corresponds to the following OS settings: >> >> Windows: Settings -> Network

Re: RFR: 8343398: Add reducedData preference [v7]

2024-12-18 Thread Michael Strauß
> The `reducedData` preference instructs applications to minimize internet > traffic, as users might be on a metered network or a limited data plan. > > This corresponds to the following OS settings: > > Windows: Settings -> Network and Internet -> Ethernet/WiFi -> Metered > connection > macOS:

Re: RFR: 8343398: Add reducedData preference [v6]

2024-12-18 Thread Kevin Rushforth
On Thu, 12 Dec 2024 01:03:26 GMT, Michael Strauß wrote: >> The `reducedData` preference instructs applications to minimize internet >> traffic, as users might be on a metered network or a limited data plan. >> >> This corresponds to the following OS settings: >> >> Windows: Settings -> Network

Re: RFR: 8343398: Add reducedData preference [v6]

2024-12-18 Thread Kevin Rushforth
On Thu, 12 Dec 2024 01:03:26 GMT, Michael Strauß wrote: >> The `reducedData` preference instructs applications to minimize internet >> traffic, as users might be on a metered network or a limited data plan. >> >> This corresponds to the following OS settings: >> >> Windows: Settings -> Network

Re: RFR: 8343398: Add reducedData preference [v6]

2024-12-18 Thread Kevin Rushforth
On Thu, 12 Dec 2024 01:03:26 GMT, Michael Strauß wrote: >> The `reducedData` preference instructs applications to minimize internet >> traffic, as users might be on a metered network or a limited data plan. >> >> This corresponds to the following OS settings: >> >> Windows: Settings -> Network

Re: RFR: 8346227: Seal Paint and Material [v2]

2024-12-18 Thread Andy Goryachev
On Wed, 18 Dec 2024 17:55:12 GMT, Michael Strauß wrote: >> this is not what I am asking though: in more than one place we have >> _callers_ like this >> >> peer.setFillPaint(getFill() == null ? null : tk.getPaint(getFill())); >> >> >> it could be changed to >> >> peer.setFillPaint(tk.getPai

Re: RFR: 8346227: Seal Paint and Material [v2]

2024-12-18 Thread Andy Goryachev
On Sat, 14 Dec 2024 17:16:20 GMT, Michael Strauß wrote: >> The `Paint` and `Material` classes can't be extended by user code, because >> their implementations require special support in internal JavaFX code. The >> classes should be sealed. > > Michael Strauß has updated the pull request increm

Re: RFR: 8346227: Seal Paint and Material [v2]

2024-12-18 Thread Michael Strauß
On Tue, 17 Dec 2024 18:18:00 GMT, Andy Goryachev wrote: >> `null` is not a valid argument for this method, and has never been. >> `acc_getPlatformPaint()` previously asserted that the return value is not >> `null`. > > this is not what I am asking though: in more than one place we have _callers

Integrated: 8345136: Update JDK_DOCS property to point to JDK 23 docs

2024-12-18 Thread Kevin Rushforth
On Fri, 13 Dec 2024 00:52:00 GMT, Kevin Rushforth wrote: > Update the docs bundle to point to the JDK 23 docs (we're currently pointing > to JDK 21). > > I will need to also download and host a zip bundle and add its checksum to > gradle/verification-metadata.xml to avoid breaking our internal

Integrated: 8345127: Add --sun-misc-unsafe-memory-access=allow when running tests until JDK-8334137 is fixed

2024-12-18 Thread Kevin Rushforth
On Wed, 27 Nov 2024 19:27:55 GMT, Kevin Rushforth wrote: > Add the `--sun-misc-unsafe-memory-access=allow` flag until > [JDK-8334137](https://bugs.openjdk.org/browse/JDK-8334137) is fixed to avoid > warnings when running tests (automated and manual) with JDK 24. > > I've tested this using a bo