Re: RFR: 8345136: Update JDK_DOCS property to point to JDK 23 docs

2024-12-15 Thread Ambarish Rapte
On Fri, 13 Dec 2024 00:52:00 GMT, Kevin Rushforth wrote: > Update the docs bundle to point to the JDK 23 docs (we're currently pointing > to JDK 21). > > I will need to also download and host a zip bundle and add its checksum to > gradle/verification-metadata.xml to avoid breaking our internal

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v31]

2024-12-15 Thread Thiago Milczarek Sayao
On Sun, 15 Dec 2024 20:57:14 GMT, Martin Fox wrote: >> I modified it to no longer rely on pre-edit calls, but I'm not sure if it's >> working as expected yet. > > When fcitx is configured this way we never receive pre-editing signals AND > we're not filtering a key event when the commit comes i

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v33]

2024-12-15 Thread Thiago Milczarek Sayao
> This replaces obsolete XIM and uses gtk api for IME. > Gtk uses [ibus](https://github.com/ibus/ibus) > > Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative > positioning on `InputMethodRequest`. > > [Screencast from 17-09-2023 > 21:59:04.webm](https://github.com/openj

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v31]

2024-12-15 Thread Martin Fox
On Sun, 15 Dec 2024 20:26:22 GMT, Thiago Milczarek Sayao wrote: >> This option sets if editing happens on the application or in the IME window. >> >> Application: >> ![image](https://github.com/user-attachments/assets/d44364ad-4090-4e1d-9fcf-5fa7fbd8a306) >> >> >> IME Window: >> ![image](http

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v31]

2024-12-15 Thread Thiago Milczarek Sayao
On Sun, 15 Dec 2024 19:09:29 GMT, Thiago Milczarek Sayao wrote: >> Anyway, current solution without checking `im_ctx.on_preedit` can work well. >> I backported it to `jfx22` and it worked well. Thanks again. And hope for >> the final solution. > > This option sets if editing happens on the app

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v32]

2024-12-15 Thread Thiago Milczarek Sayao
> This replaces obsolete XIM and uses gtk api for IME. > Gtk uses [ibus](https://github.com/ibus/ibus) > > Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative > positioning on `InputMethodRequest`. > > [Screencast from 17-09-2023 > 21:59:04.webm](https://github.com/openj

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v31]

2024-12-15 Thread Thiago Milczarek Sayao
On Thu, 12 Dec 2024 23:53:55 GMT, Helly Guo wrote: >> @hellyguo Thanks so much for tracking this down and providing all the >> details. I would like to better understand what that checkbox does but I >> might not be able to get to that until next week. >> >> JavaFX handles keyboard entry using