Withdrawn: 8301761: The sorting of the SortedList can become invalid

2024-12-11 Thread duke
On Sun, 28 Jul 2024 04:13:30 GMT, Loay Ghreeb wrote: > Fix an issue in `SortedList` where the sorting became incorrect when adding > new items that are equal to existing items according to the comparator. The > `SortedList` should consider the insertion index of these items to maintain > the c

Re: RFR: 8313424: JavaFX controls in the title bar [v36]

2024-12-11 Thread Michael Strauß
On Tue, 10 Dec 2024 22:12:29 GMT, Michael Strauß wrote: >> Implementation of >> [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) >> and `EXTENDED_UTILITY` stage style. > > Michael Strauß has updated the pull request incrementally with one additional > commit since t

Re: RFR: 8343398: Add reducedData preference [v6]

2024-12-11 Thread Michael Strauß
> The `reducedData` preference instructs applications to minimize internet > traffic, as users might be on a metered network or a limited data plan. > > This corresponds to the following OS settings: > > Windows: Settings -> Network and Internet -> Ethernet/WiFi -> Metered > connection > macOS:

Re: RFR: 8343398: Add reducedData preference [v5]

2024-12-11 Thread Michael Strauß
> The `reducedData` preference instructs applications to minimize internet > traffic, as users might be on a metered network or a limited data plan. > > This corresponds to the following OS settings: > > Windows: Settings -> Network and Internet -> Ethernet/WiFi -> Metered > connection > macOS:

Re: RFR: 8301121: RichTextArea Control (Incubator) [v61]

2024-12-11 Thread Andy Goryachev
> Incubating a new feature - rich text control, **RichTextArea**, intended to > bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The > main design goal is to provide a control that is complete enough to be useful > out-of-the box, as well as open to extension by the appl

Re: RFR: 8343398: Add reducedData preference [v4]

2024-12-11 Thread Kevin Rushforth
On Wed, 11 Dec 2024 20:33:43 GMT, Andy Goryachev wrote: > BTW, I've updated the Monkey Tester to highlight changes in Tools -> Platform > Preferences Monitor. > > https://github.com/andy-goryachev-oracle/MonkeyTest That seems useful. Thanks. > tested on macOS. needs testing on linux and windo

Re: RFR: 8343398: Add reducedData preference [v4]

2024-12-11 Thread Andy Goryachev
On Wed, 11 Dec 2024 16:31:06 GMT, Michael Strauß wrote: >> The `reducedData` preference instructs applications to minimize internet >> traffic, as users might be on a metered network or a limited data plan. >> >> This corresponds to the following OS settings: >> >> Windows: Settings -> Network

Re: RFR: 8343398: Add reducedData preference [v4]

2024-12-11 Thread Andy Goryachev
On Wed, 11 Dec 2024 16:31:06 GMT, Michael Strauß wrote: >> The `reducedData` preference instructs applications to minimize internet >> traffic, as users might be on a metered network or a limited data plan. >> >> This corresponds to the following OS settings: >> >> Windows: Settings -> Network

Re: RFR: 8343398: Add reducedData preference [v3]

2024-12-11 Thread Kevin Rushforth
On Wed, 11 Dec 2024 20:08:50 GMT, Andy Goryachev wrote: > > I feel this wouldn't age well, considering that the particular UI used by > > the different operating systems has often changed over the years. > > I think it has merit. Now that we need to re-test the functionality, it would > have h

Re: RFR: 8343398: Add reducedData preference [v3]

2024-12-11 Thread Andy Goryachev
On Wed, 11 Dec 2024 18:14:40 GMT, Michael Strauß wrote: > I feel this wouldn't age well, considering that the particular UI used by the > different operating systems has often changed over the years. I think it has merit. Now that we need to re-test the functionality, it would have helped. E

Re: RFR: 8343398: Add reducedData preference [v4]

2024-12-11 Thread Michael Strauß
On Wed, 11 Dec 2024 18:33:10 GMT, Andy Goryachev wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains seven additional >> co

Re: RFR: 8343398: Add reducedData preference [v4]

2024-12-11 Thread Andy Goryachev
On Wed, 11 Dec 2024 16:31:06 GMT, Michael Strauß wrote: >> The `reducedData` preference instructs applications to minimize internet >> traffic, as users might be on a metered network or a limited data plan. >> >> This corresponds to the following OS settings: >> >> Windows: Settings -> Network

Re: RFR: 8343398: Add reducedData preference [v3]

2024-12-11 Thread Michael Strauß
On Wed, 11 Dec 2024 16:17:04 GMT, Andy Goryachev wrote: > I might suggest adding the instructions on how to control the platform > settings as comments somewhere in the implementation. > > ``` > Windows: Settings -> Network and Internet -> Ethernet/WiFi -> Metered > connection > macOS: Setting

Re: RFR: 8343398: Add reducedData preference [v4]

2024-12-11 Thread Michael Strauß
On Wed, 11 Dec 2024 17:58:01 GMT, Andy Goryachev wrote: > Update: I was getting interference from the VPN application. Getting off the > VPN helped - I see the property and `macOS.*.currentPathConstrained` key > being toggled. > > (`macOS.*.currentPathExpensive` remains false). That's the exp

Re: RFR: 8343398: Add reducedData preference [v4]

2024-12-11 Thread Andy Goryachev
On Wed, 11 Dec 2024 16:31:06 GMT, Michael Strauß wrote: >> The `reducedData` preference instructs applications to minimize internet >> traffic, as users might be on a metered network or a limited data plan. >> >> This corresponds to the following OS settings: >> >> Windows: Settings -> Network

Re: RFR: 8343398: Add reducedData preference [v3]

2024-12-11 Thread Michael Strauß
On Wed, 11 Dec 2024 16:15:05 GMT, Michael Strauß wrote: > Does not seem to work on macOS 15.1.1 M1: It also works on 15.1.1 on my machine. Just to check the obvious: did you close the WiFi Details window? The settings are only applied when you click OK. - PR Comment: https://git.o

Re: RFR: 8288893: Popup and its subclasses cannot input text from InputMethod [v3]

2024-12-11 Thread Martin Fox
On Wed, 4 Dec 2024 14:39:55 GMT, Martin Fox wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/scene/InputMethodStateManager.java >> line 48: >> >>> 46: * PopupWindow. >>> 47: */ >>> 48: public class InputMethodStateManager { >> >> All this feels overly complicated - >> >> Why d

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v31]

2024-12-11 Thread Martin Fox
On Tue, 10 Dec 2024 09:52:38 GMT, Helly Guo wrote: >> @hellyguo Could you provide more details on which Linux distribution, input >> method, and fcitx version you're using? >> >> I just tested this on Ubuntu 24.10. For Chinese I'm using Intelligent Pinyin >> and for Japanese I'm using Mozc. Ev

Re: RFR: 8343398: Add reducedData preference [v4]

2024-12-11 Thread Michael Strauß
> The `reducedData` preference instructs applications to minimize internet > traffic, as users might be on a metered network or a limited data plan. > > This corresponds to the following OS settings: > > Windows: Settings -> Network and Internet -> Ethernet/WiFi -> Metered > connection > macOS:

Re: RFR: 8343398: Add reducedData preference [v3]

2024-12-11 Thread Andy Goryachev
On Wed, 4 Dec 2024 15:55:20 GMT, Michael Strauß wrote: >> The `reducedData` preference instructs applications to minimize internet >> traffic, as users might be on a metered network or a limited data plan. >> >> This corresponds to the following OS settings: >> >> Windows: Settings -> Network

Re: RFR: 8343398: Add reducedData preference [v3]

2024-12-11 Thread Michael Strauß
On Wed, 11 Dec 2024 16:02:27 GMT, Andy Goryachev wrote: > Does not seem to work on macOS 15.1.1 M1: It works on my 14.6 machine. Let me try upgrading and testing again... - PR Comment: https://git.openjdk.org/jfx/pull/1656#issuecomment-2536440408

Re: RFR: 8343398: Add reducedData preference [v3]

2024-12-11 Thread Andy Goryachev
On Wed, 4 Dec 2024 15:55:20 GMT, Michael Strauß wrote: >> The `reducedData` preference instructs applications to minimize internet >> traffic, as users might be on a metered network or a limited data plan. >> >> This corresponds to the following OS settings: >> >> Windows: Settings -> Network

Integrated: 8335470: [XWayland] JavaFX tests that use AWT Robot fail on Wayland

2024-12-11 Thread Alexander Zvegintsev
On Tue, 10 Dec 2024 14:10:23 GMT, Alexander Zvegintsev wrote: > This PR enables several previously disabled test cases for Wayland, as the > required fixes are already in the promoted build. > ([JDK-8335469](https://bugs.openjdk.org/browse/JDK-8335469), > [JDK-8335468](https://bugs.openjdk.or