On Mon, 9 Dec 2024 23:23:59 GMT, Marius Hanl wrote:
>> This PR fixes the horizontal virtualization performed in the
>> `TableRowSkinBase`, which significantly improves performance with many
>> columns (and thus many cells). Scrolling up and down as well as scrolling
>> left and right feels muc
On Sat, 7 Dec 2024 03:10:28 GMT, pe-3-6n wrote:
> This PR fixes a bug where the can't switch input method in GTK3.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jfx/pull/1660
On Sat, 7 Dec 2024 03:10:28 GMT, pe-3-6n wrote:
> This PR fixes a bug where the can't switch input method in GTK3.
Thank you for your comment.
I read the PR to replace the obsolete XIM input method editor.
I will close my PR.
-
PR Comment: https://git.openjdk.org/jfx/pull/1660#issu
> Yep, this seems unnecessary and counterproductive to me. All we need is to
> drop the target field from the event.
I can't image that we would ever do this, considering that events have
been there almost from the beginning. We'd break half of the JavaFX
world if we changed the API of events.
I
> Yes, each step of the event dispatch chain gets its own event
instance.
Yep, this seems unnecessary and counterproductive to me. All we need is to
drop the target field from the event.
> 2. ComboBox's skin has installed an event filter on ComboBox
So we have another scenario where different
> This PR improves the `Tree-/TableRowSkin` code by doing a normal live lookup
> for the `fixedCellSize` instead of adding listener just to update
> variables(`fixedCellSizeEnabled` and `fixedCellSize`) which can otherwise be
> also just lookup'd without the hassle of listeners.
>
> While this
> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not
> modify the layout of `VirtualFlow`.
>
> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`,
> which made many calculations leading to floating point errors.
> Interestingly I found out, that `g
On Thu, 5 Dec 2024 15:32:33 GMT, Andy Goryachev wrote:
> By the way, a Tree/TableView with 500 columns is barely usable - locks up the
> UI giving me a macOS spinning beach ball quite often. Not that it's a
> reasonable use case. 200 is ok. May be the 500 case can be used for profiling?
With f
> This PR fixes the horizontal virtualization performed in the
> `TableRowSkinBase`, which significantly improves performance with many
> columns (and thus many cells). Scrolling up and down as well as scrolling
> left and right feels much more snappy.
>
> In order to do that, there are multipl
On Thu, 5 Dec 2024 09:24:13 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableRowSkin.java
>> line 228:
>>
>>> 226: if (disclosureNodeDirty) {
>>> 227: updateDisclosureNodeAndGraphic();
>>> 228: disclosureNodeDirt
Getting back to prioritized event handlers.
> I think it would most likely be the latter, i.e. a separate "wave" for
each priority where the event first tunnels down to the target, and
then bubbles back up.
Forgive me, this makes no sense. The point of adding priority to event
handling is to re
Hi Andy, your example highlights the observable defect that I've been
trying to explain. Answers to your questions below.
On Mon, Dec 9, 2024 at 10:27 PM Andy Goryachev
wrote:
>
> OK, let's backtrack a bit.
>
> consider this example
> https://github.com/andy-goryachev-oracle/Test/blob/main/src/g
OK, let's backtrack a bit.
consider this example
https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/research/ComboBox_Events.java
it's a single combo box with application-level filters and handlers attached to
scene, combo box, and the combo box editor.
pressing and releasing
On Mon, 9 Dec 2024 17:25:58 GMT, Martin Fox wrote:
>> modules/javafx.graphics/src/main/native-glass/gtk/glass_window_ime.cpp line
>> 100:
>>
>>> 98:
>>> 99: void WindowContextBase::commitIME(gchar *str) {
>>> 100: if (im_ctx.on_preedit) {
>>
>> Through `LOG0`/`LOG1`, I found that the valu
Hi Michael,
Yes, this works! I wrote up a quick test app and it worked fine on the Mac.
I’ll try to write up a more comprehensive app but might not get around to it
for a few weeks.
Thanks,
Martin
> On Dec 6, 2024, at 8:40 AM, Michael Strauß wrote:
>
> Hi Martin,
>
> I've added the `HeaderB
On Thu, 5 Dec 2024 07:12:20 GMT, Helly Guo wrote:
>> Thiago Milczarek Sayao has updated the pull request with a new target base
>> due to a merge or a rebase. The pull request now contains 114 commits:
>>
>> - Merge branch 'master' into new_ime
>> - Set IBUS_ENABLE_SYNC_MODE=1
>> - Revert "S
On Mon, 9 Dec 2024 13:37:25 GMT, Lukasz Kostyra wrote:
>> This PR removes obsolete permission checks from javafx.graphics _minus_ Font
>> classes (handled by a separate PR).
>>
>> The only part I did not remove from methods/fields listed in the issue is
>> `WindowStage.fullScreenFromUserEvent`
On Mon, 9 Dec 2024 13:36:02 GMT, Lukasz Kostyra wrote:
>> This PR removes obsolete permission check methods and fields from
>> Font-related classes.
>>
>> Verified the changes on Windows, did not see any regressions.
>
> Lukasz Kostyra has updated the pull request incrementally with one additio
On Mon, 9 Dec 2024 13:37:25 GMT, Lukasz Kostyra wrote:
>> This PR removes obsolete permission checks from javafx.graphics _minus_ Font
>> classes (handled by a separate PR).
>>
>> The only part I did not remove from methods/fields listed in the issue is
>> `WindowStage.fullScreenFromUserEvent`
On Mon, 9 Dec 2024 13:36:02 GMT, Lukasz Kostyra wrote:
>> This PR removes obsolete permission check methods and fields from
>> Font-related classes.
>>
>> Verified the changes on Windows, did not see any regressions.
>
> Lukasz Kostyra has updated the pull request incrementally with one additio
> This PR removes obsolete permission checks from javafx.graphics _minus_ Font
> classes (handled by a separate PR).
>
> The only part I did not remove from methods/fields listed in the issue is
> `WindowStage.fullScreenFromUserEvent`. This flag seems quite extensively used
> and did not seem t
> This PR removes obsolete permission check methods and fields from
> Font-related classes.
>
> Verified the changes on Windows, did not see any regressions.
Lukasz Kostyra has updated the pull request incrementally with one additional
commit since the last revision:
Review fixes
--
On Mon, 9 Dec 2024 12:45:56 GMT, Lukasz Kostyra wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/font/PrismFontFactory.java
>> line 1375:
>>
>>> 1373: if (FontFileWriter.hasTempPermission()) {
>>> 1374: return loadEmbeddedFont0(name, fontStream, size,
>>> regi
On Fri, 6 Dec 2024 16:51:48 GMT, Kevin Rushforth wrote:
>> This PR removes obsolete permission check methods and fields from
>> Font-related classes.
>>
>> Verified the changes on Windows, did not see any regressions.
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/font/PrismFontFactor
On Fri, 6 Dec 2024 18:01:05 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/WindowStage.java
>> line 597:
>>
>>> 595: // event handler.
>>> 596: // If not notify the stageListener to reset fullscreen
>>> to false.
>
25 matches
Mail list logo
