RFR: 8286831: WebView can't switch to Chinese input method in GTK3

2024-12-06 Thread pe-3-6n
This PR fixes a bug where the can't switch input method in GTK3. - Commit messages: - 8286831: Fixed so that input method can be switched in GTK3 Changes: https://git.openjdk.org/jfx/pull/1660/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1660&range=00 Issue: https://bu

Re: Focus delegation API

2024-12-06 Thread Andy Goryachev
Returning to this discussion. Consider the following scenario: a compound control such as ComboBox, which has an editable TextField control as a part of its skin. It might be expected that the ComboBox shows the focused border instead of its TextField even when the latter has the input focus.

Re: RFR: 8344114: Remove obsolete permission check methods from Font classes

2024-12-06 Thread Andy Goryachev
On Fri, 6 Dec 2024 16:40:14 GMT, Lukasz Kostyra wrote: > This PR removes obsolete permission check methods and fields from > Font-related classes. > > Verified the changes on Windows, did not see any regressions. apart from one spot with `loadEmbeddedFont0`, lgtm (code review only) --

Re: RFR: 8344111: Remove obsolete permission check methods from javafx.graphics

2024-12-06 Thread Kevin Rushforth
On Fri, 6 Dec 2024 17:47:07 GMT, Andy Goryachev wrote: >> This PR removes obsolete permission checks from javafx.graphics _minus_ Font >> classes (handled by a separate PR). >> >> The only part I did not remove from methods/fields listed in the issue is >> `WindowStage.fullScreenFromUserEvent`

Re: RFR: 8344111: Remove obsolete permission check methods from javafx.graphics

2024-12-06 Thread Andy Goryachev
On Fri, 6 Dec 2024 16:38:14 GMT, Lukasz Kostyra wrote: > This PR removes obsolete permission checks from javafx.graphics _minus_ Font > classes (handled by a separate PR). > > The only part I did not remove from methods/fields listed in the issue is > `WindowStage.fullScreenFromUserEvent`. Thi

Re: RFR: 8344111: Remove obsolete permission check methods from javafx.graphics

2024-12-06 Thread Kevin Rushforth
On Fri, 6 Dec 2024 16:38:14 GMT, Lukasz Kostyra wrote: > This PR removes obsolete permission checks from javafx.graphics _minus_ Font > classes (handled by a separate PR). > > The only part I did not remove from methods/fields listed in the issue is > `WindowStage.fullScreenFromUserEvent`. Thi

Re: RFR: 8344114: Remove obsolete permission check methods from Font classes

2024-12-06 Thread Kevin Rushforth
On Fri, 6 Dec 2024 16:40:14 GMT, Lukasz Kostyra wrote: > This PR removes obsolete permission check methods and fields from > Font-related classes. > > Verified the changes on Windows, did not see any regressions. I spotted what looks like a bug in `loadEmbeddedFont`. The rest looks good. modu

RFR: 8344114: Remove obsolete permission check methods from Font classes

2024-12-06 Thread Lukasz Kostyra
This PR removes obsolete permission check methods and fields from Font-related classes. Verified the changes on Windows, did not see any regressions. - Commit messages: - Cleanup unused security functions from Font classes Changes: https://git.openjdk.org/jfx/pull/1659/files Web

RFR: 8344111: Remove obsolete permission check methods from javafx.graphics

2024-12-06 Thread Lukasz Kostyra
This PR removes obsolete permission checks from javafx.graphics _minus_ Font classes (handled by a separate PR). The only part I did not remove from methods/fields listed in the issue is `WindowStage.fullScreenFromUserEvent`. This flag seems quite extensively used and did not seem to have anyth

Re: JEP: JavaFX controls in the title bar

2024-12-06 Thread Michael Strauß
Hi Martin, I've added the `HeaderBar.overlappingSystemInset` property, which controls whether the window buttons take up space in the layout. Setting this property effectively ignores the system inset for layout purposes. In your example, you could now place one layout container in the "leading"

Re: RFR: 8313424: JavaFX controls in the title bar [v32]

2024-12-06 Thread Michael Strauß
> Implementation of [`EXTENDED` stage > style](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09). Michael Strauß has updated the pull request incrementally with two additional commits since the last revision: - StyleableBooleanProperty -> BooleanProperty - Add HeaderBar.overlapp

Re: RFR: 8344367: Fix mistakes in FX API docs

2024-12-06 Thread Michael Strauß
On Sun, 17 Nov 2024 21:35:44 GMT, Nir Lisker wrote: > A batch of typo and grammar fixes that were found by the spellchecker. > > Integration can wait until RDP 1/2. cssref.html L2038: ` apples when the mnemonic affordance (typically an underscore)` - PR Comment: https://g