Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v19]

2024-11-28 Thread Twig6943
On Thu, 28 Nov 2024 19:11:39 GMT, Thiago Milczarek Sayao wrote: >> Would be cool if this got merged. X is slowly dying and should be avoided if >> possible. > >> Would be cool if this got merged. X is slowly dying and should be avoided if >> possible. > > The Wayland backend is not implemente

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v19]

2024-11-28 Thread Thiago Milczarek Sayao
On Sun, 24 Nov 2024 13:44:20 GMT, Twig6943 wrote: > Would be cool if this got merged. X is slowly dying and should be avoided if > possible. The Wayland backend is not implemented here, as it would be a significantly larger task. - PR Comment: https://git.openjdk.org/jfx/pull/138

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v19]

2024-11-28 Thread Twig6943
On Wed, 9 Oct 2024 13:27:02 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >> >> >> See: >> [Switching the

Integrated: 8338000: [macos] Remove GlassFullscreenWindow

2024-11-28 Thread Martin Fox
On Sun, 17 Nov 2024 20:18:28 GMT, Martin Fox wrote: > The GlassFullscreenWindow class hasn't been instantiated since applet support > was removed (JDK-8201538). This PR removes the class and the one (unused) > member variable of that type. This pull request has now been integrated. Changeset:

Re: RFR: 8344899: Map RT-nnnn bug IDs to JDK-mmmmmmm in JavaFX sources [v3]

2024-11-28 Thread Kevin Rushforth
On Thu, 28 Nov 2024 12:52:33 GMT, Marius Hanl wrote: >> This PR changes all `RT-` references to `JDK-XXX`. >> It also removes all `http://javafx-jira.kenai.com/browse/` occurrences. >> >> As discussed, this will help a lot when looking up old issues, especially >> since not everybody kn

Re: RFR: 8338000: [macos] Remove GlassFullscreenWindow

2024-11-28 Thread Michael Strauß
On Sun, 17 Nov 2024 20:18:28 GMT, Martin Fox wrote: > The GlassFullscreenWindow class hasn't been instantiated since applet support > was removed (JDK-8201538). This PR removes the class and the one (unused) > member variable of that type. The code changes look good. I built and tested the cha

RFR: 8345188: Set :root pseudo-class on root node

2024-11-28 Thread Michael Strauß
The CSS Selectors specification defines the `:root` pseudo-class that matches root nodes: https://www.w3.org/TR/selectors-4/#the-root-pseudo JavaFX uses the non-standard `.root` style class for the same purpose. We should also support the `:root` pseudo-class for increased compatibility of Java

Re: RFR: 8344899: Map RT-nnnn bug IDs to JDK-mmmmmmm in JavaFX sources [v2]

2024-11-28 Thread Marius Hanl
On Wed, 27 Nov 2024 14:52:51 GMT, Kevin Rushforth wrote: > Looks good except for a few changes in `StylesheetTest.java` where the > `RT-n` refers to a filename and thus should be reverted. Checked the whole project with: `JDK-[\d]*.[\w]` and `JDK-[\d]*-`. No other occurrences found other t

Re: RFR: 8344899: Map RT-nnnn bug IDs to JDK-mmmmmmm in JavaFX sources [v3]

2024-11-28 Thread Marius Hanl
> This PR changes all `RT-` references to `JDK-XXX`. > It also removes all `http://javafx-jira.kenai.com/browse/` occurrences. > > As discussed, this will help a lot when looking up old issues, especially > since not everybody know how to do a lookup with the `RT-` number in the > JI

Re: RFR: 8344899: Map RT-nnnn bug IDs to JDK-mmmmmmm in JavaFX sources [v2]

2024-11-28 Thread Marius Hanl
On Wed, 27 Nov 2024 14:49:43 GMT, Kevin Rushforth wrote: >> Marius Hanl has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8344899: Remove occurrences of old JIRA tickets >> >> Including: >> - JFXC >> - DTL >> - JMY > > modules/j

Integrated: 8342461: Remove calls to doPrivileged in javafx.web/{android,ios}

2024-11-28 Thread Jose Pereda
On Wed, 27 Nov 2024 22:54:01 GMT, Jose Pereda wrote: > Removes `doPrivileged` remaining calls in the `javafx.web` module included in > {android,ios} code. This pull request has now been integrated. Changeset: a45e33c1 Author:Jose Pereda URL: https://git.openjdk.org/jfx/commit/a45e3