Re: RFR: 8343196: Add build property to identify experimental builds of JavaFX [v2]

2024-11-14 Thread Ambarish Rapte
> Introduce a new build property `jfx.experimental.release.suffix` to be used > for the early access builds of an under development feature in JavaFX. > This property would be set to a value ONLY in a branch specific to an > experiment in [jfx-sandbox](https://github.com/openjdk/jfx-sandbox) repo

Re: RFR: 8335469: [XWayland] crash when an AWT ScreenCast session overlaps with an FX ScreenCast session [v2]

2024-11-14 Thread Alexander Zvegintsev
> This is the FX counterpart of the > [openjdk/jdk/pull/22131](https://github.com/openjdk/jdk/pull/22131) / > `b.`(aka crash prevention part) > > It does not crash without the > [openjdk/jdk/pull/22131](https://github.com/openjdk/jdk/pull/22131) / `a.` > part. > > The crash prevention part i

RFR: 8335469: [XWayland] crash when an AWT ScreenCast session overlaps with an FX ScreenCast session

2024-11-14 Thread Alexander Zvegintsev
This is the FX counterpart of the [openjdk/jdk/pull/22131](https://github.com/openjdk/jdk/pull/22131) / `b.`(aka crash prevention part) It does not crash without the [openjdk/jdk/pull/22131](https://github.com/openjdk/jdk/pull/22131) / `a.` part. The crash prevention part is the same for the

Re: RFR: 8342993: Remove uses of AccessController and AccessControlContext from JavaFX [v2]

2024-11-14 Thread Andy Goryachev
On Thu, 14 Nov 2024 22:53:06 GMT, Kevin Rushforth wrote: >> This PR removes all remaining uses of `AccessController` and >> `AccessControlContext`, which represent the last remaining uses of the >> terminally deprecated security APIs except for those in the `/ios/` or >> `/android/` directorie

Re: RFR: 8342993: Remove uses of AccessController and AccessControlContext from JavaFX [v2]

2024-11-14 Thread Andy Goryachev
On Thu, 14 Nov 2024 23:45:51 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/Toolkit.java line 98: >> >>> 96: >>> 97: // Used as the (dummy) value for the various listener maps >>> 98: private static final Object dummyObj = new Object(); >> >> mino

Re: RFR: 8342993: Remove uses of AccessController and AccessControlContext from JavaFX [v2]

2024-11-14 Thread Michael Strauß
On Thu, 14 Nov 2024 23:11:23 GMT, Andy Goryachev wrote: >> Kevin Rushforth has updated the pull request incrementally with one >> additional commit since the last revision: >> >> additional comments > > modules/javafx.graphics/src/main/java/com/sun/javafx/tk/Toolkit.java line 98: > >> 96: >

Re: RFR: 8342993: Remove uses of AccessController and AccessControlContext from JavaFX [v2]

2024-11-14 Thread Michael Strauß
On Thu, 14 Nov 2024 22:53:06 GMT, Kevin Rushforth wrote: >> This PR removes all remaining uses of `AccessController` and >> `AccessControlContext`, which represent the last remaining uses of the >> terminally deprecated security APIs except for those in the `/ios/` or >> `/android/` directorie

Re: RFR: 8343336: Add persistentScrollBars preference [v4]

2024-11-14 Thread Andy Goryachev
On Fri, 1 Nov 2024 23:39:51 GMT, Michael Strauß wrote: >> This PR adds another accessibility preference that is available on all >> supported desktop platforms: >> >> 1. **Windows**: Settings -> Accessibility -> Visual Effects -> Always show >> scroll bars >> 2. **macOS**: System Settings -> A

Re: RFR: 8342993: Remove uses of AccessController and AccessControlContext from JavaFX [v2]

2024-11-14 Thread Kevin Rushforth
> This PR removes all remaining uses of `AccessController` and > `AccessControlContext`, which represent the last remaining uses of the > terminally deprecated security APIs except for those in the `/ios/` or > `/android/` directories. > > With the removal of doPrivileged and the `if (System.ge

Re: RFR: 8342993: Remove uses of AccessController and AccessControlContext from JavaFX

2024-11-14 Thread Kevin Rushforth
On Thu, 14 Nov 2024 20:59:16 GMT, Kevin Rushforth wrote: > This PR removes all remaining uses of `AccessController` and > `AccessControlContext`, which represent the last remaining uses of the > terminally deprecated security APIs except for those in the `/ios/` or > `/android/` directories. >

RFR: 8342993: Remove uses of AccessController and AccessControlContext from JavaFX

2024-11-14 Thread Kevin Rushforth
This PR removes all remaining uses of `AccessController` and `AccessControlContext`, which represent the last remaining uses of the terminally deprecated security APIs except for those in the `/ios/` or `/android/` directories. With the removal of doPrivileged and the `if (System.getSecurityMan

[jfx23u] Integrated: 8343630: Pass AccessControlContext to/from WebKit as opaque object

2024-11-14 Thread Kevin Rushforth
On Thu, 14 Nov 2024 00:34:26 GMT, Kevin Rushforth wrote: > Clean backport, needed to keep the native WebKit in sync. I have tested this > with and without a Security Manager. This pull request has now been integrated. Changeset: ea0ffaaa Author:Kevin Rushforth URL: https://git.open

Re: RFR: 8218745: TableView: visual glitch at borders on horizontal scrolling [v6]

2024-11-14 Thread Marius Hanl
> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not > modify the layout of `VirtualFlow`. > > This PR fixes the glitching by removing the code in `NGNode.renderRectClip`, > which made many calculations leading to floating point errors. > Interestingly I found out, that `g

Re: RFR: 8313424: JavaFX controls in the title bar [v30]

2024-11-14 Thread Michael Strauß
> Implementation of [`EXTENDED` stage > style](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09). Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 38 commits: - Merge branch 'master' into feature/extended

[jfx23u] Integrated: 8343760: GHA: macOS / aarch64 builds depend on Xcode 14 which will be removed

2024-11-14 Thread Kevin Rushforth
On Thu, 14 Nov 2024 12:22:15 GMT, Kevin Rushforth wrote: > Clean backport of fix to avoid spurious GHA build failures. This pull request has now been integrated. Changeset: 2e057b76 Author:Kevin Rushforth URL: https://git.openjdk.org/jfx23u/commit/2e057b76e80051387d7dbf8990d5e7e8597

Re: RFR: 8301121: RichTextArea Control (Incubator) [v43]

2024-11-14 Thread Andy Goryachev
> Incubating a new feature - rich text control, **RichTextArea**, intended to > bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The > main design goal is to provide a control that is complete enough to be useful > out-of-the box, as well as open to extension by the appl

Integrated: 8342997: Remove use of System::getSecurityManager and SecurityManager from JavaFX

2024-11-14 Thread Kevin Rushforth
On Fri, 8 Nov 2024 21:46:38 GMT, Kevin Rushforth wrote: > Ths PR removes all remaining calls to `System::getSecurityManager` and the > `SecurityManager` class along with the `System.getGecurityManager() != null` > code paths. > > As part of doing this, the last uses of `PermissionHelper` and

Re: Class ButtonAccessibility is implemented twice in JFX 17.0.13

2024-11-14 Thread Kevin Rushforth
This does look like JDK-8311806. Gluon maintains jfx17u, so Johan can comment on your request. -- Kevin On 11/14/2024 2:29 AM, Glavo wrote: Hi, We received a JVM crash report[1] for our JavaFX application and I noticed it contained these lines: objc[71933]: Class ButtonAccessibility i

Re: RFR: 8313424: JavaFX controls in the title bar [v29]

2024-11-14 Thread Michael Strauß
On Thu, 14 Nov 2024 19:03:50 GMT, Andy Goryachev wrote: >> `WindowControlsOverlayTest.activePseudoClassCorrespondsToStageFocusedProperty()` >> requires `opens javafx.stage`. > > the question is about `java.desktop/javax.imageio` not > `javafx.graphics/javafx.stage` or am I missing something? N

Re: RFR: 8313424: JavaFX controls in the title bar [v29]

2024-11-14 Thread Andy Goryachev
On Thu, 14 Nov 2024 18:59:09 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/test/addExports line 59: >> >>> 57: --add-opens javafx.graphics/javafx.scene.paint=ALL-UNNAMED >>> 58: --add-opens javafx.graphics/javafx.stage=ALL-UNNAMED >>> 59: --add-opens java.desktop/javax.imageio=ALL-UN

Re: RFR: 8313424: JavaFX controls in the title bar [v29]

2024-11-14 Thread Michael Strauß
On Thu, 14 Nov 2024 18:19:14 GMT, Andy Goryachev wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> macOS: double-click action + fullscreen toolbar > > modules/javafx.graphics/src/test/addExports line 59: > >> 57:

Re: [jfx23u] RFR: 8343630: Pass AccessControlContext to/from WebKit as opaque object

2024-11-14 Thread Kevin Rushforth
On Thu, 14 Nov 2024 00:34:26 GMT, Kevin Rushforth wrote: > Clean backport, needed to keep the native WebKit in sync. I have tested this > with and without a Security Manager. @johanvos can you approve this backport request - PR Comment: https://git.openjdk.org/jfx23u/pull/29#issue

Integrated: 8344067: TableCell indices may not match the TableRow index

2024-11-14 Thread Marius Hanl
On Tue, 12 Nov 2024 21:11:56 GMT, Marius Hanl wrote: > This PR fixes a bug where the `TableCell` indices can be outdated (not > synchronized) with the `TableRow` index. > > What normally happens is: > - Index is changed: Cell update is requested when the row is empty (otherwise > noop) > - Ite

Re: RFR: 8313424: JavaFX controls in the title bar [v29]

2024-11-14 Thread Andy Goryachev
On Thu, 14 Nov 2024 17:51:54 GMT, Michael Strauß wrote: >> Implementation of [`EXTENDED` stage >> style](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09). > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > ma

Re: RFR: 8313424: JavaFX controls in the title bar [v27]

2024-11-14 Thread Michael Strauß
On Thu, 14 Nov 2024 15:43:53 GMT, Martin Fox wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 34 commits: >> >> - Merge branch 'master' into feature/extended-window >> - Merge branch 'master' into feature

Re: RFR: 8313424: JavaFX controls in the title bar [v27]

2024-11-14 Thread Michael Strauß
On Thu, 14 Nov 2024 15:53:50 GMT, Martin Fox wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 34 commits: >> >> - Merge branch 'master' into feature/extended-window >> - Merge branch 'master' into feature

Re: RFR: 8313424: JavaFX controls in the title bar [v29]

2024-11-14 Thread Michael Strauß
> Implementation of [`EXTENDED` stage > style](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09). Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: macOS: double-click action + fullscreen toolbar - Changes

Re: RFR: 8313424: JavaFX controls in the title bar [v28]

2024-11-14 Thread Michael Strauß
> Implementation of [`EXTENDED` stage > style](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09). Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 36 commits: - remove unneeded dll - Merge branch 'master

Re: RFR: 8313424: JavaFX controls in the title bar [v27]

2024-11-14 Thread Martin Fox
On Sat, 9 Nov 2024 07:45:19 GMT, Michael Strauß wrote: >> Implementation of [`EXTENDED` stage >> style](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09). > > Michael Strauß has updated the pull request with a new target base due to a > merge or a rebase. The pull request now cont

Re: RFR: 8343196: Add build property to identify experimental builds of JavaFX

2024-11-14 Thread Kevin Rushforth
On Thu, 14 Nov 2024 12:02:02 GMT, Ambarish Rapte wrote: >> Introduce a new build property `jfx.experimental.release.suffix` to be used >> for the early access builds of an under development feature in JavaFX. >> This property would be set to a value ONLY in a branch specific to an >> experiment

Integrated: 8344155: Add missing @Override annotation to GIFImageLoader2

2024-11-14 Thread Michael Strauß
On Wed, 13 Nov 2024 23:56:55 GMT, Michael Strauß wrote: > The method `load(...)` is missing an `@Override` annotation. > > A single reviewer is sufficient. This pull request has now been integrated. Changeset: 286c3a87 Author:Michael Strauß URL: https://git.openjdk.org/jfx/commit/2

Re: RFR: 8342997: Remove use of System::getSecurityManager and SecurityManager [v6]

2024-11-14 Thread Lukasz Kostyra
On Wed, 13 Nov 2024 22:06:12 GMT, Kevin Rushforth wrote: >> Ths PR removes all remaining calls to `System::getSecurityManager` and the >> `SecurityManager` class along with the `System.getGecurityManager() != null` >> code paths. >> >> As part of doing this, the last uses of `PermissionHelper`

Re: RFR: 8343196: Add build property to identify experimental builds of JavaFX

2024-11-14 Thread Kevin Rushforth
On Thu, 14 Nov 2024 12:01:29 GMT, Ambarish Rapte wrote: > Introduce a new build property `jfx.experimental.release.suffix` to be used > for the early access builds of an under development feature in JavaFX. > This property would be set to a value ONLY in a branch specific to an > experiment in

Re: [jfx23u] RFR: 8343760: GHA: macOS / aarch64 builds depend on Xcode 14 which will be removed

2024-11-14 Thread Kevin Rushforth
On Thu, 14 Nov 2024 12:22:15 GMT, Kevin Rushforth wrote: > Clean backport of fix to avoid spurious GHA build failures. @johanvos can you approve this backport request - PR Comment: https://git.openjdk.org/jfx23u/pull/30#issuecomment-2476709972

RFR: 8343196: Add build property to identify experimental builds of JavaFX

2024-11-14 Thread Ambarish Rapte
Introduce a new build property `jfx.experimental.release.suffix` to be used for the early access builds of an under development feature in JavaFX. This property would be set to a value ONLY in a branch specific to an experiment in [jfx-sandbox](https://github.com/openjdk/jfx-sandbox) repo. For ex

Re: RFR: 8343196: Add build property to identify experimental builds of JavaFX

2024-11-14 Thread Ambarish Rapte
On Thu, 14 Nov 2024 12:01:29 GMT, Ambarish Rapte wrote: > Introduce a new build property `jfx.experimental.release.suffix` to be used > for the early access builds of an under development feature in JavaFX. > This property would be set to a value ONLY in a branch specific to an > experiment in

[jfx23u] RFR: 8343760: GHA: macOS / aarch64 builds depend on Xcode 14 which will be removed

2024-11-14 Thread Kevin Rushforth
Clean backport of fix to avoid spurious GHA build failures. - Commit messages: - Backport d0011b21959abdcc0ee9c969e7bd5fbbccb5d4ce Changes: https://git.openjdk.org/jfx23u/pull/30/files Webrev: https://webrevs.openjdk.org/?repo=jfx23u&pr=30&range=00 Issue: https://bugs.openjdk.or

Re: RFR: 8309381: Support JavaFX incubator modules

2024-11-14 Thread Kevin Rushforth
On Thu, 14 Nov 2024 09:32:33 GMT, Johan Vos wrote: >> This PR add the necessary support for [JavaFX Incubator >> Modules](https://github.com/kevinrushforth/jfx/blob/jfx.incubator/INCUBATOR-MODULES.md). >> It includes the following: >> >> 1. Changes to the build scripts `build.gradle` and `sett

Class ButtonAccessibility is implemented twice in JFX 17.0.13

2024-11-14 Thread Glavo
Hi, We received a JVM crash report[1] for our JavaFX application and I noticed it contained these lines: objc[71933]: Class ButtonAccessibility is implemented in both > /Library/Java/JavaVirtualMachines/jdk-22.jdk/Contents/Home/lib/libawt_lwawt.dylib > (0x100d6caa0) and /Users/lolimaster/.openjfx

Re: RFR: 8309381: Support JavaFX incubator modules

2024-11-14 Thread Johan Vos
On Tue, 29 Oct 2024 22:23:35 GMT, Kevin Rushforth wrote: > This PR add the necessary support for [JavaFX Incubator > Modules](https://github.com/kevinrushforth/jfx/blob/jfx.incubator/INCUBATOR-MODULES.md). > It includes the following: > > 1. Changes to the build scripts `build.gradle` and `set

Re: RFR: 8309381: Support JavaFX incubator modules

2024-11-14 Thread Ambarish Rapte
On Tue, 29 Oct 2024 22:23:35 GMT, Kevin Rushforth wrote: > This PR add the necessary support for [JavaFX Incubator > Modules](https://github.com/kevinrushforth/jfx/blob/jfx.incubator/INCUBATOR-MODULES.md). > It includes the following: > > 1. Changes to the build scripts `build.gradle` and `set