On Fri, 1 Nov 2024 16:59:50 GMT, Kevin Rushforth wrote:
> 2. This patch causes a failure in one of our closed white-box tests,
> which depends on internal API that has changed. It will be easy for us to fix
> it, but it will mean that down the road, when this is ready to go in, we will
> n
On 12/11/2024 18:31, Andy Goryachev wrote:
I am not sure this is the best solution, since it does not solve the
problem of multiple actors adding their event handlers. I do like the
idea of prioritized event handlers, because it solves the problem
**reliably**.
I think there is no way arou
John,
The issue occurs inside the event dispatchers. An event is passed into
dispatchEvent which may return a separate event. What state is carried over
from the incoming event to the outgoing event? If there are unconsumed event
handlers attached to the incoming event are they also attached to
> Incubating a new feature - rich text control, **RichTextArea**, intended to
> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The
> main design goal is to provide a control that is complete enough to be useful
> out-of-the box, as well as open to extension by the appl
> Incubating a new feature - rich text control, **RichTextArea**, intended to
> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The
> main design goal is to provide a control that is complete enough to be useful
> out-of-the box, as well as open to extension by the appl
On Wed, 6 Nov 2024 17:49:59 GMT, Andy Goryachev wrote:
> Public focus traversal API for use in custom controls.
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>
> This is a lightweight change that only adds the public API for focus
> travers
On Tue, 12 Nov 2024 21:11:56 GMT, Marius Hanl wrote:
> This PR fixes a bug where the `TableCell` indices can be outdated (not
> synchronized) with the `TableRow` index.
>
> What normally happens is:
> - Index is changed: Cell update is requested when the row is empty (otherwise
> noop)
> - Ite
This PR fixes a bug where the `TableCell` indices can be outdated (not
synchronized) with the `TableRow` index.
What normally happens is:
- Index is changed: Cell update is requested when the row is empty (otherwise
noop)
- Item is changed: Cell update is requested, which will now update the ind
Vote: yes
-phil.
I'd like to understand that too, though the question here might be a slightly
different topic (maybe for a separate mail thread).
The way I look at the problem of using controls as part of other controls (e.g.
a TextField inside a Spinner) is that the inner is no longer a fully functional
contr
Responding to Nir's questions in this thread.
> I'd like to understand the focus and event handling problem better. If I have
> a focused TextField, all key events go to it. If I have a Spinner, which is a
> TextField with 2 Buttons, it is focused as a single unit and consumes key
> events whet
I would encourage to continue this discussion in the focus delegation
thread, not in the prioritized event handlers thread.
On Tue, Nov 12, 2024 at 8:13 PM Nir Lisker wrote:
>
> I'd like to understand the focus and event handling problem better. If I have
> a focused TextField, all key events
On 12/11/2024 19:46, Nir Lisker wrote:
I'd like to understand the focus and event handling problem better. If
I have a focused TextField, all key events go to it. If I have a
Spinner, which is a TextField with 2 Buttons, it is focused as a
single unit and consumes key events whether they are ai
Hi Martin,
I'm still unsure how this exactly is supposed to go wrong.
Whenever you dispatch a new event, you should always follow-up and check
if it was consumed after the dispatch finishes. If it is, then you mark
the triggering event also as consumed. If this is done consistently
everywhe
Vote: YES
On 12/11/2024 17:22, Kevin Rushforth wrote:
I hereby nominate Lukasz Kostyra [1] to OpenJFX Reviewer.
Lukasz is a member of JavaFX team at Oracle, who has contributed 35
commits [2] to OpenJFX. Lukasz consistently participates in code
reviews of various pull requests, especially in
I'd like to understand the focus and event handling problem better. If I
have a focused TextField, all key events go to it. If I have a Spinner,
which is a TextField with 2 Buttons, it is focused as a single unit and
consumes key events whether they are aimed at the text field or the buttons
(I ass
(Here’s hoping this e-mail makes it out to the list. If this is an ongoing
problem I might have to switch to using my gmail address.)
I’m writing up some notes to improve the documentation on event dispatch. There
seems to be only one rule governing dispatchers and that is “return null from
dis
I think this is a good discussion to continue. I have a a couple quick
comments:
The first question I would like to resolve is to determine whether the
problem exists globally, or only at the controls level. If even once
scenario exists that does not involve controls, we must find a
solution
On Sat, 9 Nov 2024 07:45:19 GMT, Michael Strauß wrote:
>> Implementation of [`EXTENDED` stage
>> style](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now cont
I am not sure this is the best solution, since it does not solve the problem of
multiple actors adding their event handlers. I do like the idea of prioritized
event handlers, because it solves the problem *reliably*.
I think there is no way around it - we need different priorities. It may be a
Vote: Yes.-- MariusAm 08.11.24, 14:50 schrieb Kevin Rushforth :
I hereby nominate Jayathirth D V [1] to OpenJFX Committer.
Jay is a member of the JavaFX team at Oracle who has contributed 12
commits [2] to OpenJFX. He has contributed an additional 5 commits to
the OpenJFX jfx-tests repo [3].
Vo
Vote: YES
On Tue, Nov 12, 2024 at 6:24 PM Andy Goryachev
wrote:
> Vote: YES
>
>
>
> -andy
>
>
>
>
>
>
>
> *From: *openjfx-dev on behalf of Kevin
> Rushforth
> *Date: *Tuesday, November 12, 2024 at 08:23
> *To: *openjfx-dev , Lukasz Kostyra <
> lukasz.kost...@oracle.com>
> *Subject: *CFV: New O
Vote: YES
-andy
From: openjfx-dev on behalf of Kevin Rushforth
Date: Tuesday, November 12, 2024 at 08:23
To: openjfx-dev , Lukasz Kostyra
Subject: CFV: New OpenJFX Reviewer: Lukasz Kostyra
I hereby nominate Lukasz Kostyra [1] to OpenJFX Reviewer.
Lukasz is a member of JavaFX team at Oracl
Thank you Michael for answering my questions!
I get from your answers that:
1. the priorities are still needed, in one form or the other. Adding a
different type of the EH (ifUnconsumed) seems to me like a different priority.
2. the problem seems to exist only at the controls level - nothing wa
Vote: YES
-- Kevin
On 11/12/2024 8:22 AM, Kevin Rushforth wrote:
I hereby nominate Lukasz Kostyra [1] to OpenJFX Reviewer.
I hereby nominate Lukasz Kostyra [1] to OpenJFX Reviewer.
Lukasz is a member of JavaFX team at Oracle, who has contributed 35
commits [2] to OpenJFX. Lukasz consistently participates in code reviews
of various pull requests, especially in the graphics area.
Votes are due by Nov 26, 2024 at 17
> Input methods don’t work for text controls inside Popups. This PR fixes that.
>
> Some background:
>
> A PopupWindow always has an owner. The owner of the first Popup is a standard
> Window; I’ll refer to that as the root window. But a popup can show another
> popup (for example, a popup may
This is now visible here:
https://bugs.openjdk.org/browse/JDK-8344037
-- Kevin
On 11/12/2024 7:07 AM, PavelTurk wrote:
Hello everyone,
I submitted a bug report on November 6, but I still haven’t received any notification about it.
Review ID - 9077800. The bug was about Font.loadFont()
B
On Mon, 11 Nov 2024 19:34:04 GMT, Martin Fox wrote:
>> Input methods don’t work for text controls inside Popups. This PR fixes that.
>>
>> Some background:
>>
>> A PopupWindow always has an owner. The owner of the first Popup is a
>> standard Window; I’ll refer to that as the root window. But
Hello everyone,
I submitted a bug report on November 6, but I still haven’t received any
notification about it.
Review ID - 9077800. The bug was about Font.loadFont()
Best regards, Pavel
I think `discardUnconsumedEventHandlers` is still a bit unpredictable,
as it would depend on handler order.
The user handler would need to be called *after* Skin/Behavior handlers
for it to be able to always discard any ifUnconsumed callbacks. If the
Skin is replaced, then it will re-register
31 matches
Mail list logo
