Re: JEP: JavaFX controls in the title bar

2024-10-22 Thread Michael Strauß
Hi Thiago! If you use gtk_window_set_decorated() to remove the server-side title bar, you also invariably lose the resizable window borders as they are considered to be part of the "decoration". We need the EXTENDED window style because it is materially different from all of the other styles. The

Re: JEP: JavaFX controls in the title bar

2024-10-22 Thread Thiago Milczarek Sayão
Hi Michael, Thank you for this effort. It would be nice to have a TRANSPARENT window type with the HeaderBar so it would be possible to have rounded corners on Linux. I was going to suggest to not have a special window type (EXTENDED) at all but then remembered the resize grips. Maybe they can b

JEP: JavaFX controls in the title bar

2024-10-22 Thread Michael Strauß
Hi everyone, the discussion in PR #1605 has shown that the proposed feature needs a better presentation in a JEP-like format, so here it is: https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09

RFR: 8091673: Public focus traversal API for use in custom controls

2024-10-22 Thread Andy Goryachev
Public focus traversal API for use in custom controls https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md This work is loosely based on the patch https://cr.openjdk.org/~jgiles/8061673/ And is a scaled down version (with the public traversal policy API

Re: Proposal: Focus Traversal API

2024-10-22 Thread Andy Goryachev
Updated the API and the JEP per feedback comments: https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md https://github.com/openjdk/jfx/pull/1604 Thanks, -andy From: Andy Goryachev Date: Tuesday, October 22, 2024 at 12:22 To: John Hendrikx , openjfx-

Re: RFR: 8218745: TableView: visual glitch at borders on horizontal scrolling [v2]

2024-10-22 Thread Marius Hanl
On Tue, 4 Jun 2024 12:33:06 GMT, Marius Hanl wrote: >> you are right: I see the focus rectangle jitter at 175% scale on win 11 (w/o >> the fix), so it must be a different issue. At this scale, it merely shows a >> thinner line, perhaps that's why I did not notice it earlier. > >> you are right

Re: RFR: 8218745: TableView: visual glitch at borders on horizontal scrolling [v5]

2024-10-22 Thread Marius Hanl
> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not > modify the layout of `VirtualFlow`. > > This PR fixes the glitching by removing the code in `NGNode.renderRectClip`, > which made many calculations leading to floating point errors. > Interestingly I found out, that `g

Re: RFR: 8285893: Hiding dialog and showing new one causes dialog to be frozen [v10]

2024-10-22 Thread Marius Hanl
> This PR fixes the dialog freeze problem once and for all. > > This one is a bit tricky to understand, here is how it works: > This bug happens on every platform, although the implementation of nested > event loops differs on every platform. > E.g. on Linux we use `gtk_main` and `gtk_main_quit`

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-22 Thread Michael Strauß
On Tue, 22 Oct 2024 20:42:13 GMT, Michael Strauß wrote: >> Another aspect is whether this should be a conditional feature. >> If not, how will it be supported on Android/iOS? RaspPI? > >> Another aspect is whether this should be a conditional feature. If not, how >> will it be supported on Andr

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-22 Thread Andy Goryachev
On Tue, 22 Oct 2024 20:42:13 GMT, Michael Strauß wrote: >> Another aspect is whether this should be a conditional feature. >> If not, how will it be supported on Android/iOS? RaspPI? > >> Another aspect is whether this should be a conditional feature. If not, how >> will it be supported on Andr

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-22 Thread Michael Strauß
On Tue, 22 Oct 2024 17:44:08 GMT, Andy Goryachev wrote: > Continuing on window attributes. I would like to know what is and is not > supported by platform, by feature. > > For example: > > Windows > > * translucency > * color gradient > * system menu on right click, on the toolbar and on the

Re: Proposal: Focus Traversal API

2024-10-22 Thread Andy Goryachev
Thank you. I completely disagree with the idea of adding a single method to Node and introducing 6 way enum, for the reasons provided earlier. Having said that, I am more interested in moving forward. If everyone feels more comfortable with Node + enum combo, I'll make the change. Thank you f

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-22 Thread Andy Goryachev
On Sun, 20 Oct 2024 01:23:01 GMT, Michael Strauß wrote: >> This PR is a new take on a highly requested feature: JavaFX controls in the >> header bar (see also #594 for an earlier iteration). >> >> This is a feature with many possible ways to skin the cat, and it has taken >> quite a bit of eff

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-22 Thread Thiago Milczarek Sayao
On Sun, 20 Oct 2024 01:23:01 GMT, Michael Strauß wrote: >> This PR is a new take on a highly requested feature: JavaFX controls in the >> header bar (see also #594 for an earlier iteration). >> >> This is a feature with many possible ways to skin the cat, and it has taken >> quite a bit of eff

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-22 Thread Andy Goryachev
On Sun, 20 Oct 2024 01:23:01 GMT, Michael Strauß wrote: >> This PR is a new take on a highly requested feature: JavaFX controls in the >> header bar (see also #594 for an earlier iteration). >> >> This is a feature with many possible ways to skin the cat, and it has taken >> quite a bit of eff

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-22 Thread Andy Goryachev
On Sun, 20 Oct 2024 01:23:01 GMT, Michael Strauß wrote: >> This PR is a new take on a highly requested feature: JavaFX controls in the >> header bar (see also #594 for an earlier iteration). >> >> This is a feature with many possible ways to skin the cat, and it has taken >> quite a bit of eff

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-22 Thread Andy Goryachev
On Sun, 20 Oct 2024 01:23:01 GMT, Michael Strauß wrote: >> This PR is a new take on a highly requested feature: JavaFX controls in the >> header bar (see also #594 for an earlier iteration). >> >> This is a feature with many possible ways to skin the cat, and it has taken >> quite a bit of eff

Integrated: 8341514: Add reducedMotion and reducedTransparency preferences

2024-10-22 Thread Michael Strauß
On Sat, 5 Oct 2024 03:44:27 GMT, Michael Strauß wrote: > This PR adds the `Platform.Preferences.reducedMotion` and > `Platform.Preferences.reducedTransparency` accessibility preferences: > > interface Preferences { > /** > * Specifies whether applications should minimize the amount of

Re: RFR: 8306707: Support pluggable image loading via javax.imageio [v6]

2024-10-22 Thread Michael Strauß
On Tue, 22 Oct 2024 15:13:05 GMT, Andy Goryachev wrote: >> `scanlineStride` is useful for all the `ImageFrame` constructors, or do you >> think recomputing it (with the risk of it being different) is still the best >> course of action given that AWT supplies it and might be using some other >>

Re: RFR: 8306707: Support pluggable image loading via javax.imageio [v6]

2024-10-22 Thread Michael Strauß
On Tue, 22 Oct 2024 15:55:20 GMT, Michael Strauß wrote: >>> `var` helps the writer of the code, but almost never helps the reader of >>> the code >> >> I fully agree with John on this. > >> `scanlineStride` is useful for all the `ImageFrame` constructors, or do you >> think recomputing it (wit

Re: RFR: 8306707: Support pluggable image loading via javax.imageio [v7]

2024-10-22 Thread Michael Strauß
> This PR is an improved version of #1093. > > JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image > loaders. It has been a long-standing request to support more image formats, > most notably (but not limited to) SVG. However, adding more built-in image > loaders is a signifi

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-22 Thread Michael Strauß
On Sun, 20 Oct 2024 01:23:01 GMT, Michael Strauß wrote: >> This PR is a new take on a highly requested feature: JavaFX controls in the >> header bar (see also #594 for an earlier iteration). >> >> This is a feature with many possible ways to skin the cat, and it has taken >> quite a bit of eff

Re: RFR: 8340852: ScrollPane should not consume navigation keys when it doesn't have direct focus [v5]

2024-10-22 Thread Andy Goryachev
On Tue, 22 Oct 2024 05:21:47 GMT, John Hendrikx wrote: >> This change modifies `ScrollPaneBehavior` to only consume keys that are >> targetted at it. As `KeyEvent`s are in almost all cases only intended for >> the targetted node (as visually that's where the user expects the keyboard >> input

Re: RFR: 8306707: Support pluggable image loading via javax.imageio [v6]

2024-10-22 Thread Andy Goryachev
On Tue, 22 Oct 2024 05:54:28 GMT, John Hendrikx wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/iio/javax/XImageLoader.java >> line 209: >> >>> 207: : ImageStorage.ImageType.PALETTE; >>> 208: >>> 209: var scanlineStride = switch(image.getSampl

Re: RFR: 8329098: Support "@1x" image naming convention as fallback [v4]

2024-10-22 Thread Kevin Rushforth
On Mon, 21 Oct 2024 11:28:23 GMT, Lukasz Kostyra wrote: >> This PR adds a title-mentioned fallback to `ImageStorage.java` and a test >> for that specific scenario. >> >> In `ImageStorage.loadAll()` we still prefer the Image path that was provided >> by the user, but if it is missing we will no

Re: RFR: 8299753: Tree/TableView: Column Resizing With Fractional Scale [v4]

2024-10-22 Thread Andy Goryachev
> Modified the resize algorithm to work well with fractional scale, thanks for > deeper understanding of the problem thanks to @hjohn and @mstr2 . > > Removed earlier manual tester in favor of the monkey tester. > > It is important to note that even though the constraints are given by the > us

Integrated: 8342462: TextAreaSkin: remove USE_MULTIPLE_NODES

2024-10-22 Thread Andy Goryachev
On Wed, 16 Oct 2024 23:01:39 GMT, Andy Goryachev wrote: > Removed "not yet fully implemented" USE_MULTIPLE_NODES and related code. > > I would like to remove the early unfinished idea of using multiple Text nodes > in TextAreaSkin to clean up the code, to make it easier to do fixes for > [JDK-

Re: RFR: 8299753: Tree/TableView: Column Resizing With Fractional Scale [v3]

2024-10-22 Thread Andy Goryachev
On Thu, 22 Aug 2024 22:39:25 GMT, Andy Goryachev wrote: >> Modified the resize algorithm to work well with fractional scale, thanks for >> deeper understanding of the problem thanks to @hjohn and @mstr2 . >> >> Removed earlier manual tester in favor of the monkey tester. >> >> It is important

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-22 Thread Nir Lisker
On Sun, 20 Oct 2024 01:23:01 GMT, Michael Strauß wrote: >> This PR is a new take on a highly requested feature: JavaFX controls in the >> header bar (see also #594 for an earlier iteration). >> >> This is a feature with many possible ways to skin the cat, and it has taken >> quite a bit of eff

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-22 Thread Thiago Milczarek Sayao
On Sun, 20 Oct 2024 01:23:01 GMT, Michael Strauß wrote: >> This PR is a new take on a highly requested feature: JavaFX controls in the >> header bar (see also #594 for an earlier iteration). >> >> This is a feature with many possible ways to skin the cat, and it has taken >> quite a bit of eff