Re: Issue in color setting

2024-10-06 Thread clemens.lantha...@itarchitects.at
I will change the code and do a retest. Thanks for the hint. Clemens > On 7. Oct 2024, at 06:27, Michael Strauß wrote: > > You're setting a new value in the change listener of the iconColor > property, which then fires off another change notification, and so on. > I guess that you're not get

Re: Issue in color setting

2024-10-06 Thread Michael Strauß
You're setting a new value in the change listener of the iconColor property, which then fires off another change notification, and so on. I guess that you're not getting a new object if you use one of the predefined constants like "red", which breaks the cycle (as there's no change notification whe

Re: RFR: 8341514: Add reducedMotion and reducedTransparency preferences [v2]

2024-10-06 Thread Michael Strauß
> This PR adds the `Platform.Preferences.reducedMotion` and > `Platform.Preferences.reducedTransparency` accessibility preferences: > > interface Preferences { > /** > * Specifies whether applications should minimize the amount of > non-essential animations, > * reducing discomfort

Re: RFR: 8341418: Prism/es2 DrawableInfo is never freed (leak) [v2]

2024-10-06 Thread Michael Strauß
On Sun, 6 Oct 2024 19:12:42 GMT, Thiago Milczarek Sayao wrote: >> modules/javafx.graphics/src/main/java/com/sun/prism/es2/ES2SwapChain.java >> line 193: >> >>> 191: @Override >>> 192: public ES2Graphics createGraphics() { >>> 193: if (drawable == null || drawable.getNativeWindo

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v26]

2024-10-06 Thread Thiago Milczarek Sayao
On Thu, 3 Oct 2024 14:23:24 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >> positioning on `InputMethodRequest`. >>

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v26]

2024-10-06 Thread Martin Fox
On Thu, 3 Oct 2024 14:23:24 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >> positioning on `InputMethodRequest`. >>

Re: RFR: 8341418: Prism/es2 DrawableInfo is never freed (leak) [v2]

2024-10-06 Thread Thiago Milczarek Sayao
On Sun, 6 Oct 2024 12:03:47 GMT, Michael Strauß wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review changes > > modules/javafx.graphics/src/main/java/com/sun/prism/es2/GLDrawable.java line > 56: > >>

Re: RFR: 8341418: Prism/es2 DrawableInfo is never freed (leak) [v2]

2024-10-06 Thread Thiago Milczarek Sayao
> When creating a Scene, a `DrawableInfo` is allocated with `malloc`. When > scene changes, this is called on `WindowStage.java`: > > `QuantumRenderer.getInstance().disposePresentable(painter.presentable); // > latched on RT` > > But the underlying `DrawableInfo` is never freed. > > I also t

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v25]

2024-10-06 Thread Thiago Milczarek Sayao
On Sun, 6 Oct 2024 00:51:04 GMT, Martin Fox wrote: >> I'll do more testing. > > @tsayao I'm testing your code before you made the last set of changes. On Ubu > 22 running the X11 backend these AltGr combinations generate the expected > TYPED character. On Ubu 24 running Wayland I can reproduce

Re: RFR: 8341418: Prism/es2 DrawableInfo is never freed (leak)

2024-10-06 Thread Thiago Milczarek Sayao
On Sun, 6 Oct 2024 12:03:02 GMT, Michael Strauß wrote: >> When creating a Scene, a `DrawableInfo` is allocated with `malloc`. When >> scene changes, this is called on `WindowStage.java`: >> >> `QuantumRenderer.getInstance().disposePresentable(painter.presentable); // >> latched on RT` >> >>

Issue in color setting

2024-10-06 Thread Clemens Lanthaler
Hi everyone, I have just moved over my application (Photoslide) from JFX22 to JFX23 and I am facing the folling issue: * For any FontIcon (iKonli) where I set the color in web form I am getting the follwing exception: o Exception in thread "JavaFX Application Thread" java.lang.

Re: RFR: 8341418: Prism/es2 DrawableInfo is never freed (leak)

2024-10-06 Thread Michael Strauß
On Tue, 1 Oct 2024 17:37:15 GMT, Thiago Milczarek Sayao wrote: > When creating a Scene, a `DrawableInfo` is allocated with `malloc`. When > scene changes, this is called on `WindowStage.java`: > > `QuantumRenderer.getInstance().disposePresentable(painter.presentable); // > latched on RT` >