Integrated: 8297072: Provide gradle option to test a previously built SDK

2024-09-26 Thread Ambarish Rapte
On Mon, 23 Sep 2024 15:48:00 GMT, Ambarish Rapte wrote: > Requirement: > We want to be able to test a JavaFX SDK built somewhere else other than on > current machine or current repo on same machine. Which means we should be > able to run the unit and system tests with a different JavaFX SD

RFR: 8340852: ScrollPane should not consume navigation keys when it doesn't have direct focus

2024-09-26 Thread John Hendrikx
This change modifies `ScrollPaneBehavior` to only consume keys that are targetted at it. As `KeyEvent`s are in almost all cases only intended for the targetted node (as visually that's where the user expects the keyboard input to go, as per normal UI rules) consuming key events that bubble up i

Re: RFR: 8340852: ScrollPane should not consume navigation keys when it doesn't have direct focus

2024-09-26 Thread Kevin Rushforth
On Thu, 26 Sep 2024 21:17:55 GMT, John Hendrikx wrote: > This change modifies `ScrollPaneBehavior` to only consume keys that are > targetted at it. As `KeyEvent`s are in almost all cases only intended for > the targetted node (as visually that's where the user expects the keyboard > input to

Re: RFR: 8340852: ScrollPane should not consume navigation keys when it doesn't have direct focus

2024-09-26 Thread John Hendrikx
On Thu, 26 Sep 2024 21:17:55 GMT, John Hendrikx wrote: > This change modifies `ScrollPaneBehavior` to only consume keys that are > targetted at it. As `KeyEvent`s are in almost all cases only intended for > the targetted node (as visually that's where the user expects the keyboard > input to

Re: [External] : Re: Proposal: Focus Traversal API

2024-09-26 Thread Martin Fox
Hi Andy, Glad to hear the TraversalEvent is gone. I’ll try go take a look at the new implementation next week. > > There’s a case in the current control set that this API doesn’t cover. > > ToggleButtons intercept the arrow keys so they can implement a cyclic > > traversal policy among buttons

Re: RFR: 8340829: Generated API docs should clearly identify EA builds

2024-09-26 Thread Kevin Rushforth
On Thu, 26 Sep 2024 21:33:10 GMT, Kevin Rushforth wrote: > This PR modifies the header and footer of the javadoc-generated API docs to > add "DRAFT $VER-ea+$BLD" to clearly identify an ea build of the docs, and > also to make it clear which build number the docs refer to. This matches was > th

RFR: 8340829: Generated API docs should clearly identify EA builds

2024-09-26 Thread Kevin Rushforth
This PR modifies the header and footer of the javadoc-generated API docs to add "DRAFT $VER-ea+$BLD" to clearly identify an ea build of the docs, and also to make it clear which build number the docs refer to. This matches was the JDK does. For GA builds, there will be no change to what we gener

Re: Dead keys followed by space

2024-09-26 Thread John Hendrikx
For some reason mails on the openjfx-dev mailinglist coming from mar...@martinfox.com are not coming through to me I have the same problem. It sometimes takes a while, and sometimes they never get through :/  It may indeed by Gmail, as I use that as well for the mailinglist. --John On 26/09

Integrated: 8340980: Cannot build on Windows ARM

2024-09-26 Thread Martin Fox
On Thu, 26 Sep 2024 01:45:14 GMT, Martin Fox wrote: > Restored some behavior in genVSproperties that enabled ARM builds and > cross-compilation on Windows. Verified that I can build on ARM but have no > way of testing other architectures. This pull request has now been integrated. Changeset:

Re: RFR: 8340980: Cannot build on Windows ARM

2024-09-26 Thread Kevin Rushforth
On Thu, 26 Sep 2024 01:45:14 GMT, Martin Fox wrote: > Restored some behavior in genVSproperties that enabled ARM builds and > cross-compilation on Windows. Verified that I can build on ARM but have no > way of testing other architectures. Looks good. - Marked as reviewed by kcr (

Re: RFR: 8341010: JavaFX - TriangleMesh.vertexFormat Property default value is wrong.

2024-09-26 Thread Kevin Rushforth
On Thu, 26 Sep 2024 10:30:47 GMT, Florian Kirmaier wrote: > Fixing the wrong TriangleMesh.vertexFormat property. > TriangleMesh.getVertexFormat() and TriangleMesh.vertexProperty().get() > initially returned different values, which are now fixed. I changed the title to `TriangleMesh.vertexForm

Re: RFR: 8090456: Focus Management [v7]

2024-09-26 Thread Andy Goryachev
> Public APIs for focus traversal and the focus traversal policy: > > https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal.md > > This work is loosely based on the patch > https://cr.openjdk.org/~jgiles/8061673/ Andy Goryachev has updated the pull request inc

[jfx23u] Integrated: 8340954: Add SECURITY.md file

2024-09-26 Thread Kevin Rushforth
On Thu, 26 Sep 2024 14:13:40 GMT, Kevin Rushforth wrote: > Clean backport of new `SECURITY.md` file to the `jfx23u` repo. This pull request has now been integrated. Changeset: bd99f722 Author:Kevin Rushforth URL: https://git.openjdk.org/jfx23u/commit/bd99f722effb799ae4b3023264c05b2d

Missing macOS integration points

2024-09-26 Thread David Kopp
Hello everyone. JavaFX is missing methods that are the equivalent of the macOS integration methods in java.awt.Desktop. I have experimented with calling these methods in a JavaFX application, but they do nothing. Is there any interest in adding something similar to either the HostServices, Platf

Re: [jfx23u] RFR: 8340954: Add SECURITY.md file

2024-09-26 Thread Kevin Rushforth
On Thu, 26 Sep 2024 14:13:40 GMT, Kevin Rushforth wrote: > Clean backport of new `SECURITY.md` file to the `jfx23u` repo. @johanvos Can you approve this? (it doesn't require review, but does require approval) - PR Comment: https://git.openjdk.org/jfx23u/pull/23#issuecomment-237711

[jfx23u] RFR: 8340954: Add SECURITY.md file

2024-09-26 Thread Kevin Rushforth
Clean backport of new `SECURITY.md` file to the `jfx23u` repo. - Commit messages: - Backport 0dd0c794c3b08f816e7618026d5c90deaf952046 Changes: https://git.openjdk.org/jfx23u/pull/23/files Webrev: https://webrevs.openjdk.org/?repo=jfx23u&pr=23&range=00 Issue: https://bugs.openjdk

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v25]

2024-09-26 Thread Thiago Milczarek Sayao
On Wed, 21 Aug 2024 09:58:53 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >> positioning on `InputMethodRequest`. >>

Integrated: 8340954: Add SECURITY.md file

2024-09-26 Thread Kevin Rushforth
On Wed, 25 Sep 2024 21:08:41 GMT, Kevin Rushforth wrote: > A `SECURITY.md` file was recently added to the jdk repo. GitHub will show > that policy if you click on the ["Security" > tab](https://github.com/openjdk/jdk/security) of the jdk repo -- If you are > logged in, you may need to further

Re: RFR: 8297072: Provide gradle option to test a previously built SDK [v3]

2024-09-26 Thread Lukasz Kostyra
On Wed, 25 Sep 2024 12:48:16 GMT, Ambarish Rapte wrote: >> Requirement: >> We want to be able to test a JavaFX SDK built somewhere else other than on >> current machine or current repo on same machine. Which means we should be >> able to run the unit and system tests with a different JavaF

Re: RFR: 8340980: Cannot build on Windows ARM

2024-09-26 Thread Kevin Rushforth
On Thu, 26 Sep 2024 01:45:14 GMT, Martin Fox wrote: > Restored some behavior in genVSproperties that enabled ARM builds and > cross-compilation on Windows. Verified that I can build on ARM but have no > way of testing other architectures. The change looks good to me, and I see a successful GHA

Re: Possible leak on prism es2

2024-09-26 Thread Thiago Milczarek Sayão
Hi, I'm investigating the code, and for someone not familiar with it, it's very complex. On com.sun.javafx.tk.quantum.WindowStage it will do this when changing scene: if (oldScene != null) { ViewPainter painter = ((ViewScene)oldScene).getPainter(); QuantumRenderer.getInstance().disposePr

RFR: 8341010: JavaFX - TriangleMesh.vertexFormat Property default value is wrong.

2024-09-26 Thread Florian Kirmaier
Fixing the wrong TriangleMesh.vertexFormat property. TriangleMesh.getVertexFormat() and TriangleMesh.vertexProperty().get() initially returned different values, which are now fixed. - Commit messages: - JDK-8341010 Changes: https://git.openjdk.org/jfx/pull/1581/files Webrev: htt

Re: RFR: 8340980: Cannot build on Windows ARM

2024-09-26 Thread Joeri Sykora
On Thu, 26 Sep 2024 01:45:14 GMT, Martin Fox wrote: > Restored some behavior in genVSproperties that enabled ARM builds and > cross-compilation on Windows. Verified that I can build on ARM but have no > way of testing other architectures. The change looks good to me. I've done a build on our b

Re: RFR: 8340980: Cannot build on Windows ARM

2024-09-26 Thread Johan Vos
On Thu, 26 Sep 2024 01:45:14 GMT, Martin Fox wrote: > Restored some behavior in genVSproperties that enabled ARM builds and > cross-compilation on Windows. Verified that I can build on ARM but have no > way of testing other architectures. Thanks for this. @tiainen can you review?

Re: Dead keys followed by space

2024-09-26 Thread Johan Corveleyn
Thanks, and thank you Martin for filing the issue https://bugs.openjdk.org/browse/JDK-8340982. I'll try to create an account on openjdk.org to be able to watch the issue :-). Tangentially: For some reason mails on the openjfx-dev mailinglist coming from mar...@martinfox.com are not coming through