Andy,
As you're not responding to any of the suggestions or any of my
questions, but are only re-iterating points that I believe are not going
to be a benefit to the long term viability of FX, I see no point in
continuing the discussion further.
--John
On 18/09/2024 01:09, Andy Goryachev wr
On Mon, 16 Sep 2024 16:34:39 GMT, Andy Goryachev wrote:
>> Converting control module tests to junit5.
>>
>> The following notes might help reviewers and people migrating other parts of
>> https://bugs.openjdk.org/browse/JDK-8339170. The direct link to the notes:
>> https://github.com/andy-gory
On Tue, 17 Sep 2024 13:48:50 GMT, Jay Bhaskar wrote:
>> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
>> are fully compliant with the JUnit 5 framework.
>
> Jay Bhaskar has updated the pull request incrementally with one additional
> commit since the last revision
On Mon, 16 Sep 2024 16:34:39 GMT, Andy Goryachev wrote:
>> Converting control module tests to junit5.
>>
>> The following notes might help reviewers and people migrating other parts of
>> https://bugs.openjdk.org/browse/JDK-8339170. The direct link to the notes:
>> https://github.com/andy-gory
On Mon, 16 Sep 2024 15:23:48 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/behavior/AccordionBehaviorTest.java
>> line 39:
>>
>>> 37:
>>> 38: @Test
>>> 39: public void focusGainedIsCaughtByBehavior() {
>>
>> Wait, is this an empt
Dear John:
You do bring a lot of good points, no doubt. And I do agree with a lot of the
suggestion, but I still want to emphasize two points:
1. The backward compatibility should not be dismissed that easily. There is a
number of existing applications out there and we do not want to break th
On Mon, 16 Sep 2024 16:34:39 GMT, Andy Goryachev wrote:
>> Converting control module tests to junit5.
>>
>> The following notes might help reviewers and people migrating other parts of
>> https://bugs.openjdk.org/browse/JDK-8339170. The direct link to the notes:
>> https://github.com/andy-gory
On Fri, 13 Sep 2024 22:03:53 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 17 additional
>> comm
> Incubating a new feature - rich text control, **RichTextArea**, intended to
> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The
> main design goal is to provide a control that is complete enough to be useful
> out-of-the box, as well as open to extension by the appl
> Incubating a new feature - rich text control, **RichTextArea**, intended to
> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The
> main design goal is to provide a control that is complete enough to be useful
> out-of-the box, as well as open to extension by the appl
On Tue, 17 Sep 2024 15:33:06 GMT, Jayathirth D V wrote:
> This PR is for open-sourcing 2 closed toys EmbeddedSwing and HelloWorld.
> JBS : https://bugs.openjdk.org/browse/JDK-8211234
>
> 1)EmbeddedSwing - a simple FX test app with a SwingNode containing a Swing
> application
>
> 2)HelloWorld c
On Tue, 17 Sep 2024 14:29:11 GMT, Jayathirth D V wrote:
> This PR is for open-sourcing HelloFXCanvas test app.
> JBS : https://bugs.openjdk.org/browse/JDK-8211247
> It is an SWT app with SWT button and an FXCanvas with animated rectangle.
> This is used on our integration testing.
>
> This test
On Tue, 14 May 2024 22:29:18 GMT, Martin Fox wrote:
>> On Linux getKeyCodeForChar does not consult the current keyboard layout. For
>> example, it assumes the “+” character is on KeyCode.PLUS even on layouts
>> which don’t generate KeyCode.PLUS. The result is that most
>> KeyCharacterCombinati
This PR is for open-sourcing 2 closed toys EmbeddedSwing and HelloWorld.
JBS : https://bugs.openjdk.org/browse/JDK-8211234
1)EmbeddedSwing - a simple FX test app with a SwingNode containing a Swing
application
2)HelloWorld contains 2 test apps :
- HelloJFXPanel - a simple Swing test app with a
This PR is for open-sourcing HelloFXCanvas test app.
JBS : https://bugs.openjdk.org/browse/JDK-8211247
It is an SWT app with SWT button and an FXCanvas with animated rectangle.
This is used on our integration testing.
This test is now moved to apps/toys, please refer to
apps/toys/HelloFXCanvas/R
On Tue, 17 Sep 2024 13:00:09 GMT, Kevin Rushforth wrote:
>> It is ok to use instance variable for SubresourceIntegrityTest. there is no
>> issue.
>
> @jaybhaskar Yes, there is an issue as the above comment from @arapte shows.
> Please don't mark this as "resolved" until it is, and @arapte is sa
> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
> are fully compliant with the JUnit 5 framework.
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
remove instance variables in parametrized test
-
On Tue, 17 Sep 2024 13:45:03 GMT, Jay Bhaskar wrote:
>> @jaybhaskar Yes, there is an issue as the above comment from @arapte shows.
>> Please don't mark this as "resolved" until it is, and @arapte is satisfied.
>
> Thanks , I have modified and push according
I found issue , and done changes acc
On Tue, 17 Sep 2024 12:13:19 GMT, Jay Bhaskar wrote:
>> I also think the test needs to be modified as suggested by @Maran23 and
>> @andy-goryachev-oracle .
>> With the changes in this PR the member variables are never assigned with
>> value.
>> I verified the values of the two member variables
On Tue, 17 Sep 2024 11:22:56 GMT, Ambarish Rapte wrote:
>> I think you need to do the same as done by @andy-goryachev-oracle in his
>> JUnit5 replacement PR:
>>
>> public void setup(String hashValue, String expected) throws Exception {
>> htmlFile = new File("subresource-integrity-t
> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
> are fully compliant with the JUnit 5 framework.
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
Cleaning according review comments
-
Change
On Mon, 16 Sep 2024 18:45:45 GMT, Hima Bindu Meda wrote:
> Updated additional webkit-619.1 fixes from webkitgtk-2.44.4. Build is
> successful on all platforms.No issues seen
Builds and tests ran fine.
-
Marked as reviewed by sykora (Author).
PR Review: https://git.openjdk.org/jfx
On Mon, 16 Sep 2024 12:01:41 GMT, Marius Hanl wrote:
>> In this case, keeping the values as instance variables is more reliable.
>> Since all the tests pass when hashValue and expected are instance variables
>> and some of them fail when I adding parameter to
>> testScriptTagWithCorrectHashV
On Mon, 16 Sep 2024 23:03:50 GMT, Jay Bhaskar wrote:
>> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
>> are fully compliant with the JUnit 5 framework.
>
> Jay Bhaskar has updated the pull request incrementally with one additional
> commit since the last revision
On Mon, 16 Sep 2024 23:49:48 GMT, Michael Strauß wrote:
>> This PR completes the CSS Transitions story (see #870) by adding
>> interpolation support for backgrounds and borders, making them targetable by
>> transitions.
>>
>> `Background` and `Border` objects are deeply immutable, but not
>>
25 matches
Mail list logo
