Re: Proposal: Focus Traversal API

2024-09-11 Thread John Hendrikx
Hi Andy / List, I've given this some thought first, without looking too much at the proposal. In my view, focus traversal should be implemented using events, and FX should provide standard handling of these events controlled with properties (potentially even CSS stylable for easy mass changi

Re: RFR: 8339517: Add --enable-native-access flag when running tests [v2]

2024-09-11 Thread Kevin Rushforth
On Wed, 11 Sep 2024 22:16:23 GMT, Kevin Rushforth wrote: >> When running JavaFX tests and apps with JDK 24, we now get illegal access >> warnings of the following form: >> >> >> WARNING: A restricted method in java.lang.System has been called >> WARNING: java.lang.System::load has been called

Re: RFR: 8339517: Add --enable-native-access flag when running tests [v2]

2024-09-11 Thread Kevin Rushforth
> When running JavaFX tests and apps with JDK 24, we now get illegal access > warnings of the following form: > > > WARNING: A restricted method in java.lang.System has been called > WARNING: java.lang.System::load has been called by > com.sun.glass.utils.NativeLibLoader in module javafx.graphi

Re: [jfx17u] RFR: 8319996: Update to GCC 13.2.0 on Linux

2024-09-11 Thread duke
On Wed, 11 Sep 2024 14:10:15 GMT, Sergey Chernyshev wrote: > Hi all, > > Please review this clean backport of > [2e733041](https://github.com/openjdk/jfx/commit/2e7330417c2f39fee15676966d5b7455bb3fcbff) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The fix being backp

Re: RFR: 8090456: Focus Management

2024-09-11 Thread Andy Goryachev
On Tue, 10 Sep 2024 16:38:26 GMT, Kevin Rushforth wrote: >> Public APIs for focus traversal and the focus traversal policy: >> >> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal.md >> >> This work is loosely based on the patch >> https://cr.openjdk.org/

Re: RFR: 8090456: Focus Management

2024-09-11 Thread Michael Strauß
On Wed, 11 Sep 2024 15:06:07 GMT, Andy Goryachev wrote: > The default one seems to be geometry-based ("directional") _where supported_, > and the other being a "logical" one which is not explicitly accessible. The > question, therefore, is do we need a static getter for that kind of a policy?

Re: RFR: 8090456: Focus Management

2024-09-11 Thread Andy Goryachev
On Tue, 10 Sep 2024 16:30:51 GMT, Kevin Rushforth wrote: >> Public APIs for focus traversal and the focus traversal policy: >> >> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal.md >> >> This work is loosely based on the patch >> https://cr.openjdk.org/

Re: RFR: 8090456: Focus Management

2024-09-11 Thread Andy Goryachev
On Wed, 11 Sep 2024 01:05:33 GMT, Michael Strauß wrote: >> Public APIs for focus traversal and the focus traversal policy: >> >> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal.md >> >> This work is loosely based on the patch >> https://cr.openjdk.org/~

Re: RFR: 8339517: Add --enable-native-access flag when running tests

2024-09-11 Thread Kevin Rushforth
On Wed, 11 Sep 2024 14:42:19 GMT, Kevin Rushforth wrote: > When running JavaFX tests and apps with JDK 24, we now get illegal access > warnings of the following form: > > > WARNING: A restricted method in java.lang.System has been called > WARNING: java.lang.System::load has been called by >

RFR: 8339517: Add --enable-native-access flag when running tests

2024-09-11 Thread Kevin Rushforth
When running JavaFX tests and apps with JDK 24, we now get illegal access warnings of the following form: WARNING: A restricted method in java.lang.System has been called WARNING: java.lang.System::load has been called by com.sun.glass.utils.NativeLibLoader in module javafx.graphics (file:buil

[jfx17u] RFR: 8319996: Update to GCC 13.2.0 on Linux

2024-09-11 Thread Sergey Chernyshev
Hi all, Please review this clean backport of [2e733041](https://github.com/openjdk/jfx/commit/2e7330417c2f39fee15676966d5b7455bb3fcbff) from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. The fix being backported was authored by @kevinrushforth on 16 Nov 2023 and was reviewed by @a

[jfx17u] Integrated: 8319762: Update to Visual Studio 2022 version 17.6.5 on Windows

2024-09-11 Thread Sergey Chernyshev
On Wed, 11 Sep 2024 10:57:02 GMT, Sergey Chernyshev wrote: > Hi all, > > Please review a clean backport of > [2d4b494e](https://github.com/openjdk/jfx/commit/2d4b494ea9cee1acd0407b9de61f0af9163f5d62) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The fix being backport

Re: [jfx17u] RFR: 8319762: Update to Visual Studio 2022 version 17.6.5 on Windows

2024-09-11 Thread duke
On Wed, 11 Sep 2024 10:57:02 GMT, Sergey Chernyshev wrote: > Hi all, > > Please review a clean backport of > [2d4b494e](https://github.com/openjdk/jfx/commit/2d4b494ea9cee1acd0407b9de61f0af9163f5d62) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The fix being backport

[jfx17u] Integrated: 8335548: testCookieEnabled fails with WebKit 619.1

2024-09-11 Thread Johan Vos
On Wed, 11 Sep 2024 12:19:40 GMT, Johan Vos wrote: > Hi all, > > This pull request contains a backport of commit 33d82c04 from the openjdk/jfx > repository. > > The commit being backported was authored by Jay Bhaskar on 21 Jul 2024 and > was reviewed by Kevin Rushforth. > > Thanks! This pul

[jfx21u] Integrated: 8335548: testCookieEnabled fails with WebKit 619.1

2024-09-11 Thread Johan Vos
On Wed, 11 Sep 2024 12:23:42 GMT, Johan Vos wrote: > Hi all, > > This pull request contains a backport of commit 33d82c04 from the openjdk/jfx > repository. > > The commit being backported was authored by Jay Bhaskar on 21 Jul 2024 and > was reviewed by Kevin Rushforth. > > Thanks! This pul

[jfx21u] RFR: 8335548: testCookieEnabled fails with WebKit 619.1

2024-09-11 Thread Johan Vos
Hi all, This pull request contains a backport of commit 33d82c04 from the openjdk/jfx repository. The commit being backported was authored by Jay Bhaskar on 21 Jul 2024 and was reviewed by Kevin Rushforth. Thanks! - Commit messages: - Backport 33d82c04dd8c4c3fa9188da5c263e0f406a

[jfx17u] RFR: 8335548: testCookieEnabled fails with WebKit 619.1

2024-09-11 Thread Johan Vos
Hi all, This pull request contains a backport of commit 33d82c04 from the openjdk/jfx repository. The commit being backported was authored by Jay Bhaskar on 21 Jul 2024 and was reviewed by Kevin Rushforth. Thanks! - Commit messages: - Backport 33d82c04dd8c4c3fa9188da5c263e0f406a

Re: [jfx17u] RFR: 8334713: WebKit build failed on LoongArch64 because currentStackPointer is undefined

2024-09-11 Thread Sergey Chernyshev
On Wed, 11 Sep 2024 06:51:22 GMT, Johan Vos wrote: > Thanks for this PR, much appreciated! I'm in the process of updating the > webkit, sqlite and libxml. I believe this (and others) are valid PR's and > will approve once I'm confident that they fit in the general update. Hi Johan! Thanks for

[jfx17u] Integrated: 8328994: Update WebKit to 619.1

2024-09-11 Thread Johan Vos
On Wed, 11 Sep 2024 10:06:27 GMT, Johan Vos wrote: > Hi all, > > This pull request contains a backport of commit 34bbf853 from the openjdk/jfx > repository. > > The commit being backported was authored by Hima Bindu Meda on 16 Jul 2024 > and was reviewed by Kevin Rushforth and Joeri Sykora. >

[jfx21u] Integrated: 8328994: Update WebKit to 619.1

2024-09-11 Thread Johan Vos
On Wed, 11 Sep 2024 09:57:50 GMT, Johan Vos wrote: > Hi all, > > This pull request contains a backport of commit > [34bbf853](https://github.com/openjdk/jfx/commit/34bbf85362fae946c6306eb52a8478aa2ca3ef5f) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The commit being

Re: RFR: 8339247: Create release notes for JavaFX 23 [v2]

2024-09-11 Thread Kevin Rushforth
On Wed, 4 Sep 2024 14:38:00 GMT, Kevin Rushforth wrote: >> This PR adds the release notes for the JavaFX 23 release. This will first go >> into `master`, and then be backported to the `jfx23` branch so it will be >> available in that branch when JavaFX 23 is published (and from there also >> s

Re: [jfx17u] RFR: 8319762: Update to Visual Studio 2022 version 17.6.5 on Windows

2024-09-11 Thread Sergey Chernyshev
On Wed, 11 Sep 2024 10:57:02 GMT, Sergey Chernyshev wrote: > Hi all, > > Please review a clean backport of > [2d4b494e](https://github.com/openjdk/jfx/commit/2d4b494ea9cee1acd0407b9de61f0af9163f5d62) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The fix being backport

[jfx17u] RFR: 8319762: Update to Visual Studio 2022 version 17.6.5 on Windows

2024-09-11 Thread Sergey Chernyshev
Hi all, Please review a clean backport of [2d4b494e](https://github.com/openjdk/jfx/commit/2d4b494ea9cee1acd0407b9de61f0af9163f5d62) from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. The fix being backported was authored by @kevinrushforth on 15 Nov 2023 and was reviewed by @tiai

[jfx17u] RFR: 8328994: Update WebKit to 619.1

2024-09-11 Thread Johan Vos
Hi all, This pull request contains a backport of commit 34bbf853 from the openjdk/jfx repository. The commit being backported was authored by Hima Bindu Meda on 16 Jul 2024 and was reviewed by Kevin Rushforth and Joeri Sykora. Thanks! - Commit messages: - Backport 34bbf85362fae9

[jfx21u] RFR: 8328994: Update WebKit to 619.1

2024-09-11 Thread Johan Vos
Hi all, This pull request contains a backport of commit [34bbf853](https://github.com/openjdk/jfx/commit/34bbf85362fae946c6306eb52a8478aa2ca3ef5f) from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. The commit being backported was authored by Hima Bindu Meda on 16 Jul 2024 and was

[jfx17u] Integrated: 8331765: Websocket callbacks are not executed after WebKit 617.1 update

2024-09-11 Thread Sergey Chernyshev
On Tue, 10 Sep 2024 12:40:02 GMT, Sergey Chernyshev wrote: > Hi all, > > Please review a clean backport of > [6a586b66](https://github.com/openjdk/jfx/commit/6a586b662592be3eb81670f0c5ce48061c2fc07c) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The commit being backp

[jfx17u] Integrated: 8282359: Intermittent WebKit build failure on Windows: C1090: PDB API call failed, error code 23

2024-09-11 Thread Sergey Chernyshev
On Tue, 10 Sep 2024 12:53:42 GMT, Sergey Chernyshev wrote: > Hi all, > > Please review a clean backport of > [a264435d](https://github.com/openjdk/jfx/commit/a264435dccba6ec386548f76f1ace095d943f4ca) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The commit being backp

[jfx21u] Integrated: 8331765: Websocket callbacks are not executed after WebKit 617.1 update

2024-09-11 Thread Sergey Chernyshev
On Tue, 10 Sep 2024 12:39:09 GMT, Sergey Chernyshev wrote: > Hi all, > > Please review a clean backport of > [6a586b66](https://github.com/openjdk/jfx/commit/6a586b662592be3eb81670f0c5ce48061c2fc07c) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The commit being backp

[jfx21u] Integrated: 8334713: WebKit build failed on LoongArch64 because currentStackPointer is undefined

2024-09-11 Thread Sergey Chernyshev
On Tue, 10 Sep 2024 12:33:35 GMT, Sergey Chernyshev wrote: > Hi all, > > Please review the clean backport of the commit > [ca04c87d](https://github.com/openjdk/jfx/commit/ca04c87d307c36591162af8cd6298ede17812834) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The commi

[jfx17u] Integrated: 8334713: WebKit build failed on LoongArch64 because currentStackPointer is undefined

2024-09-11 Thread Sergey Chernyshev
On Tue, 10 Sep 2024 12:36:42 GMT, Sergey Chernyshev wrote: > Hi all, > > Please review the clean backport of the commit > [ca04c87d](https://github.com/openjdk/jfx/commit/ca04c87d307c36591162af8cd6298ede17812834) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The commi

[jfx17u] Integrated: 8318984: Update to Xcode 14.3.1 on macOS

2024-09-11 Thread Sergey Chernyshev
On Tue, 10 Sep 2024 13:39:11 GMT, Sergey Chernyshev wrote: > Hi all, > > Please review a clean backport of > [d24e96a6](https://github.com/openjdk/jfx/commit/d24e96a66f1908b5a1a1a7d48ee938ba1c782e6c) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The fix being backport

Re: [jfx17u] RFR: 8334713: WebKit build failed on LoongArch64 because currentStackPointer is undefined

2024-09-11 Thread duke
On Tue, 10 Sep 2024 12:36:42 GMT, Sergey Chernyshev wrote: > Hi all, > > Please review the clean backport of the commit > [ca04c87d](https://github.com/openjdk/jfx/commit/ca04c87d307c36591162af8cd6298ede17812834) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The commi

Re: [jfx21u] RFR: 8334713: WebKit build failed on LoongArch64 because currentStackPointer is undefined

2024-09-11 Thread duke
On Tue, 10 Sep 2024 12:33:35 GMT, Sergey Chernyshev wrote: > Hi all, > > Please review the clean backport of the commit > [ca04c87d](https://github.com/openjdk/jfx/commit/ca04c87d307c36591162af8cd6298ede17812834) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The commi

Re: [jfx17u] RFR: 8318984: Update to Xcode 14.3.1 on macOS

2024-09-11 Thread duke
On Tue, 10 Sep 2024 13:39:11 GMT, Sergey Chernyshev wrote: > Hi all, > > Please review a clean backport of > [d24e96a6](https://github.com/openjdk/jfx/commit/d24e96a66f1908b5a1a1a7d48ee938ba1c782e6c) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The fix being backport

Re: [jfx17u] RFR: 8331765: Websocket callbacks are not executed after WebKit 617.1 update

2024-09-11 Thread duke
On Tue, 10 Sep 2024 12:40:02 GMT, Sergey Chernyshev wrote: > Hi all, > > Please review a clean backport of > [6a586b66](https://github.com/openjdk/jfx/commit/6a586b662592be3eb81670f0c5ce48061c2fc07c) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The commit being backp

Re: [jfx17u] RFR: 8282359: Intermittent WebKit build failure on Windows: C1090: PDB API call failed, error code 23

2024-09-11 Thread duke
On Tue, 10 Sep 2024 12:53:42 GMT, Sergey Chernyshev wrote: > Hi all, > > Please review a clean backport of > [a264435d](https://github.com/openjdk/jfx/commit/a264435dccba6ec386548f76f1ace095d943f4ca) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The commit being backp

Re: [jfx21u] RFR: 8331765: Websocket callbacks are not executed after WebKit 617.1 update

2024-09-11 Thread duke
On Tue, 10 Sep 2024 12:39:09 GMT, Sergey Chernyshev wrote: > Hi all, > > Please review a clean backport of > [6a586b66](https://github.com/openjdk/jfx/commit/6a586b662592be3eb81670f0c5ce48061c2fc07c) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The commit being backp

Re: [jfx17u] RFR: 8318984: Update to Xcode 14.3.1 on macOS

2024-09-11 Thread Johan Vos
On Tue, 10 Sep 2024 13:39:11 GMT, Sergey Chernyshev wrote: > Hi all, > > Please review a clean backport of > [d24e96a6](https://github.com/openjdk/jfx/commit/d24e96a66f1908b5a1a1a7d48ee938ba1c782e6c) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The fix being backport