RFR: 8339212: When build jfx in Linux(aarch64), gradle downloads the wrong eclipse swt jar

2024-08-28 Thread ANUPAM DEV
Hi, I have updated the name of the SWT.jar that needs to be downloaded during the build process for Linux aarch64. Please review. Regards, Anupam - Commit messages: - Updated build.gradle for SWT_FILE_NAME to support Linux aarch64 Changes: https://git.openjdk.org/jfx/pull/1549/fi

[jfx23u] Integrated: 8338886: JavaFX debug builds fail on macOS

2024-08-28 Thread Jay Bhaskar
On Wed, 28 Aug 2024 14:10:04 GMT, Jay Bhaskar wrote: > A clean backport to jfx23u. The fix is for a build error , failing to build > on mac on debug mode. This pull request has now been integrated. Changeset: 5a81743a Author:Jay Bhaskar URL: https://git.openjdk.org/jfx23u/commit/5a

Re: RFR: 8339068: [Linux] NPE: Cannot read field "firstFont" because "" is null

2024-08-28 Thread Phil Race
On Tue, 27 Aug 2024 15:50:54 GMT, Jose Pereda wrote: > This PR adds a couple of null checks to `LogicalFont` and `FTFactory`, that > make use of `FontConfigManager::getFontConfigFont`, which under certain > cases, can return null. > > I've tested this PR on both Linux (Ubuntu 22.04.4) and Andr

RFR: 8339178: [macos] Swing InterOp Platform.exit() crash

2024-08-28 Thread Kevin Rushforth
A Swing / FX interop app will crash if an application creates a new AWT / Swing window after calling Platform.exit. The root cause of the crash is that AWT caches the JNI env pointer for the AppKit thread, and assumes that it is valid for the life of the application. In the case where JavaFX is

Re: RFR: 8339178: [macos] Swing InterOp Platform.exit() crash

2024-08-28 Thread Kevin Rushforth
On Mon, 26 Aug 2024 21:11:03 GMT, Kevin Rushforth wrote: > A Swing / FX interop app will crash if an application creates a new AWT / > Swing window after calling Platform.exit. The root cause of the crash is that > AWT caches the JNI env pointer for the AppKit thread, and assumes that it is >

Re: RFR: 8339178: [macos] Swing InterOp Platform.exit() crash

2024-08-28 Thread Andy Goryachev
On Tue, 27 Aug 2024 14:42:58 GMT, Kevin Rushforth wrote: >> modules/javafx.graphics/src/main/java/com/sun/glass/ui/mac/MacApplication.java >> line 81: >> >>> 79: thr.setName("JavaFX-KeepAlive"); >>> 80: thr.setDaemon(false); >>> 81: thr.start(); >> >> is it possible to

Re: RFR: 8339178: [macos] Swing InterOp Platform.exit() crash

2024-08-28 Thread Andy Goryachev
On Mon, 26 Aug 2024 21:11:03 GMT, Kevin Rushforth wrote: > A Swing / FX interop app will crash if an application creates a new AWT / > Swing window after calling Platform.exit. The root cause of the crash is that > AWT caches the JNI env pointer for the AppKit thread, and assumes that it is >

Re: RFR: 8339178: [macos] Swing InterOp Platform.exit() crash

2024-08-28 Thread Kevin Rushforth
On Mon, 26 Aug 2024 21:57:51 GMT, Andy Goryachev wrote: >> A Swing / FX interop app will crash if an application creates a new AWT / >> Swing window after calling Platform.exit. The root cause of the crash is >> that AWT caches the JNI env pointer for the AppKit thread, and assumes that >> it

Re: [jfx23u] RFR: 8338886: JavaFX debug builds fail on macOS

2024-08-28 Thread Andy Goryachev
On Wed, 28 Aug 2024 14:10:04 GMT, Jay Bhaskar wrote: > A clean backport to jfx23u. The fix is for a build error , failing to build > on mac on debug mode. clean backport - Marked as reviewed by angorya (Reviewer). PR Review: https://git.openjdk.org/jfx23u/pull/16#pullrequestrevie

[jfx23u] RFR: 8338886: JavaFX debug builds fail on macOS

2024-08-28 Thread Jay Bhaskar
A clean backport to jfx23u. The fix is for a build error , failing to build on mac on debug mode. - Commit messages: - Backport 48497168892f5625f77936eccf19e836a6c1971e Changes: https://git.openjdk.org/jfx23u/pull/16/files Webrev: https://webrevs.openjdk.org/?repo=jfx23u&pr=16&ra