On Tue, 6 Aug 2024 17:17:15 GMT, Andy Goryachev wrote:
> Item 4 seems to have been introduced by this PR - don't see the issue with
> the master branch. Also, notice that we don't get a stack trace but a bunch
> of concatenated messages.
I can not reproduce this on my build - probably because
Issue: ASSERT Statement: The ASSERT macro or function seems to be used to check
if a condition involving ExceptionCode is true, but it's failing to compile.
Solution: The expression for ASSERT should be checked with type.
-
Commit messages:
- 8338886: JavaFX debug builds fail on mac
Gottcha,
That helps give the context I need to better elaborate. And to be clear I'm
not suggesting you've done anything wrong, I realized maybe I had implied
that I was upset, so I just wanted to say explicitly that is not the case.
Anywho, regarding CustomMesh it would be impossible to inherit
On Thu, 22 Aug 2024 16:09:29 GMT, Ambarish Rapte wrote:
> Update copyright year in files updated in year 2024.
> This update is done specifically to update the year in webkit files, so that
> the webkit source shows no diff.
This pull request has now been integrated.
Changeset: fac1c2ab
Author
I understand that you propose to add a special-purpose mesh
(GouraudShadedTriangleMesh) instead of adding yet another buffer to
the existing TriangleMesh. That might be a valid idea if the goal is
to not overload the TriangleMesh class with special-purpose stuff.
However, I still feel that the sol
Sorry want to reword the first paragraph since it didn't make sense.
I don't feel like my email was understood, because I explained how a
solution like the one you've just suggested is one we should eventually
add, but that regardless of that eventual feature, my current suggestion is
still a wort
Was hoping to get feedback on my suggestion instead, but another suggestion
doesn't work.
The idea of a CustomMesh is impossible to implement until after we
have fully user-supplied shader support, which I've already addressed as
being not the scope of this change (but instead it is a separate fut
That seems to be a tough one.
Delaying the invocation of listeners sounds interesting, as it might
allow using a pattern like the following:
childrenTriggerPermutation = true;
try (var scope = new DelayedEventScope(children)) {
children.remove(node);
children.add(node);
Small sample program that triggers an assert in Parent:
@Override
publicvoidstart(Stage primaryStage) {
HBox hbox = newHBox();
Scene scene = newScene(hbox);
Button button1 = newButton("Hi");
Button button2 = newButton("World");
Button button3 = newButton("!");
hbox.getChildren().addAll(but
> Any solution which was good enough for normals is also good enough for vertex
> colors right?
Not necessarily. Designing APIs is hard, and one should try to start
from a point of asking "how would the API look like if we had
considered all of the things we know now from the beginning".
An idea
On Thu, 22 Aug 2024 15:29:45 GMT, Kevin Rushforth wrote:
> snapInnerSpace method.
The main idea is to handle the case when computing snapped coordinates within
the unsnapped container. Granted, this is somewhat unusual case, so I am ok
with using simple rounding here.
FYI, I've added Page ->
> Modified the resize algorithm to work well with fractional scale, thanks for
> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>
> Removed earlier manual tester in favor of the monkey tester.
>
> It is important to note that even though the constraints are given by the
> us
Hi all, just sending an update on the proposal since I'm hoping to start
work on a draft PR for this, but I'd like feedback on the proposed API
(with & without the changes mentioned in the previous email).
Thanks!
On Tue, Aug 20, 2024 at 11:49 PM Knee Snap wrote:
> Hi Michael,
>
> Thanks for th
On Wed, 21 Aug 2024 09:53:24 GMT, Hima Bindu Meda wrote:
> Updated additonal fixes from webkit-2.44.3. Verified build on all platforms.
> No issue seen.
Looks good. The code changes match those in the upstream `webkitgtk-2.44.3`
tag. I did a build and sanity test. All good.
-
Mar
> Modified the resize algorithm to work well with fractional scale, thanks for
> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>
> Removed earlier manual tester in favor of the monkey tester.
>
> It is important to note that even though the constraints are given by the
> us
On Thu, 22 Aug 2024 18:08:53 GMT, Kevin Rushforth wrote:
> Clean merge from `jfx:jfx23` to `jfx23u:master`.
This pull request has now been integrated.
Changeset: faf4c287
Author:Kevin Rushforth
URL:
https://git.openjdk.org/jfx23u/commit/faf4c287890d805781e6d5b621cb32729b93d563
Stats
Clean merge from `jfx:jfx23` to `jfx23u:master`.
-
Commit messages:
- Merge
- 8338478: [macos] Crash in CoreText with certain strings using JDK 22 or later
The merge commit only contains trivial merges, so no merge-specific webrevs
have been generated.
Changes: https://git.openjd
On Thu, 22 Aug 2024 17:37:28 GMT, Ambarish Rapte wrote:
>> Update copyright year in files updated in year 2024.
>> This update is done specifically to update the year in webkit files, so that
>> the webkit source shows no diff.
>
> Ambarish Rapte has updated the pull request incrementally with o
On Thu, 22 Aug 2024 17:09:10 GMT, Kevin Rushforth wrote:
> Looks good except for two media files. One definitely must be reverted (the
> legal file) and the other probably should be.
Thanks Kevin, Reverted both the files.
-
PR Comment: https://git.openjdk.org/jfx/pull/1543#issueco
> Update copyright year in files updated in year 2024.
> This update is done specifically to update the year in webkit files, so that
> the webkit source shows no diff.
Ambarish Rapte has updated the pull request incrementally with one additional
commit since the last revision:
revert unrequi
On Thu, 22 Aug 2024 16:09:29 GMT, Ambarish Rapte wrote:
> Update copyright year in files updated in year 2024.
> This update is done specifically to update the year in webkit files, so that
> the webkit source shows no diff.
Looks good except for two media files. One definitely must be reverted
On Wed, 21 Aug 2024 09:53:24 GMT, Hima Bindu Meda wrote:
> Updated additonal fixes from webkit-2.44.3. Verified build on all platforms.
> No issue seen.
Reviewers: @kevinrushforth @tiainen
-
PR Comment: https://git.openjdk.org/jfx/pull/1541#issuecomment-2305217262
Update copyright year in files updated in year 2024.
This update is done specifically to update the year in webkit files, so that
the webkit source shows no diff.
-
Commit messages:
- copyright year 2024
Changes: https://git.openjdk.org/jfx/pull/1543/files
Webrev: https://webrevs
On Thu, 15 Jun 2023 19:38:00 GMT, Andy Goryachev wrote:
> Modified the resize algorithm to work well with fractional scale, thanks for
> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>
> Removed earlier manual tester in favor of the monkey tester.
>
> It is important to no
On Thu, 15 Jun 2023 19:38:00 GMT, Andy Goryachev wrote:
> Modified the resize algorithm to work well with fractional scale, thanks for
> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>
> Removed earlier manual tester in favor of the monkey tester.
>
> It is important to no
Updated additonal fixes from webkit-2.44.3. Verified build on all platforms. No
issue seen.
-
Commit messages:
- correct spaces
- Update changes related to webkit-2.44.3
Changes: https://git.openjdk.org/jfx/pull/1541/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1541&ra
Clean Backport
-
Commit messages:
- Backport 67ac9d7804cd8d572bcc3e06e2f640d8a744d3bb
Changes: https://git.openjdk.org/jfx23u/pull/12/files
Webrev: https://webrevs.openjdk.org/?repo=jfx23u&pr=12&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8338306
Stats: 3 lines in 1 fi
On Thu, 22 Aug 2024 12:35:07 GMT, Hima Bindu Meda wrote:
> Clean Backport
This pull request has now been integrated.
Changeset: 82110a38
Author:Hima Bindu Meda
URL:
https://git.openjdk.org/jfx23u/commit/82110a38b2895c607d6d33109c95fb5c8bd9bfec
Stats: 3 lines in 1 file changed: 2
On Wed, 21 Aug 2024 21:36:52 GMT, Alexander Matveev
wrote:
>> - Updated GStreamer to 1.24.6 and Glib to 2.80.4.
>> - Testing done on all platforms with all supported formats.
>> - Removed gstpluginloader.c. This file contains additional plugin loading
>> mechanism which we do not use. Latest GS
I think I figured out the reason why this fails. The root cause lies in
a misconception I've seen in a lot of FX code.
JavaFX uses a single event thread model, which ensures all structures
are only ever accessed by a single thread. This frees FX from having to
do synchronization on almost ev
30 matches
Mail list logo
