[Feature Proposal] Vertex Colors on TriangleMesh

2024-08-19 Thread Knee Snap
This is my first time attempting to submit a feature request so bear with me if I mess up the instructions, I'll do my best to rectify any issues if they occur and are pointed out. *Feature Proposal:* Vertex Colors on TriangleMesh Add a new ObservableIntegerArray to TriangleMesh which contains ver

RFR: 8336632: Update Gradle to 8.9

2024-08-19 Thread Ambarish Rapte
Gradle 8.8 released on May 31, 2024, supports JDK 22. On Jul 11, 2024, gradle 8.9 was released too, so we can update to the latest gradle 8.9 This gradle update is required in order to update the boot jdk to 22.0.2. The changes are minimal, no source code changes were required. This PR also inc

Integrated: 8336938: Update libFFI to 3.4.6

2024-08-19 Thread Alexander Matveev
On Wed, 7 Aug 2024 00:26:13 GMT, Alexander Matveev wrote: > - libFFI updated to 3.4.6. > - No additional changes are done. > - Tested on Windows, macOS and Linux with all supported formats. This pull request has now been integrated. Changeset: f1bac5a8 Author:Alexander Matveev URL:

Re: RFR: 8337400: [Linux] Initial window position is not centered on Ubuntu 24.04 / Xorg

2024-08-19 Thread Thiago Milczarek Sayao
On Mon, 29 Jul 2024 17:46:52 GMT, Thiago Milczarek Sayao wrote: > On Ubuntu 24.04 with Xorg windows are not shown centered. > > This is due a configure event being received with position 0,0 which is wrong. > > The fix ignores the configure events until the window is mapped. The problem is th

Re: RFR: 8337400: [Linux] Initial window position is not centered on Ubuntu 24.04 / Xorg

2024-08-19 Thread Marius Hanl
On Mon, 19 Aug 2024 00:06:07 GMT, Thiago Milczarek Sayao wrote: > It always failing for me, with this PR or without. Since I wrote them, maybe we can fix those tests for you as well and make them more stable across Linux. I think generally those tests are good to have as they can catch serious

Integrated: 8338478: [macos] Crash in CoreText with certain strings using JDK 22 or later

2024-08-19 Thread Phil Race
On Sat, 17 Aug 2024 21:02:59 GMT, Phil Race wrote: > The test in the bug report crashes reliably with JDK 22 on retina. > It coincides with an update to the macOS compilers which seem likely to > eagerly invalidate the target of a CFRelease on the native CTFontRef. > Adding a ReachabilityFence t

Re: RFR: 8338306: WebView Drag and Drop fails with WebKit 619.1

2024-08-19 Thread Kevin Rushforth
On Mon, 19 Aug 2024 09:32:22 GMT, Hima Bindu Meda wrote: > This commit resolves drag and drop issue observed with Webkit-619.1. Verified > build on all platforms. No issue seen The fix works as expected. I confirm that Drag and Drop fails without the fix and works with the fix. I left a sugge

Re: RFR: 8338306: WebView Drag and Drop fails with WebKit 619.1

2024-08-19 Thread Kevin Rushforth
On Mon, 19 Aug 2024 09:32:22 GMT, Hima Bindu Meda wrote: > This commit resolves drag and drop issue observed with Webkit-619.1. Verified > build on all platforms. No issue seen Reviewers: @kevinrushforth and @tiainen or @johanvos - PR Comment: https://git.openjdk.org/jfx/pull/1538

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v22]

2024-08-19 Thread Martin Fox
On Mon, 19 Aug 2024 16:32:31 GMT, Andy Goryachev wrote: >> Interesting. I just did a quick test on the Mac and verified that either >> coordinate can go negative. There must be a difference in the way the >> platform's model multiple monitors. > > on mac and windows the coordinates can be negat

[jfx23u] Integrated: 8336941: Update libxslt to 1.1.42

2024-08-19 Thread Hima Bindu Meda
On Mon, 19 Aug 2024 16:55:46 GMT, Hima Bindu Meda wrote: > Clean Backport This pull request has now been integrated. Changeset: 48853242 Author:Hima Bindu Meda URL: https://git.openjdk.org/jfx23u/commit/48853242735bc08c909eb0cb0a68a08ec50f7109 Stats: 478 lines in 19 files change

[jfx23u] Integrated: 8336941: Update libxslt to 1.1.42

2024-08-19 Thread Hima Bindu Meda
Clean Backport - Commit messages: - Backport dc8f607e4ce95e348bb812a1c942e4321c00f0f8 Changes: https://git.openjdk.org/jfx23u/pull/10/files Webrev: https://webrevs.openjdk.org/?repo=jfx23u&pr=10&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336941 Stats: 478 lines in 19

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v22]

2024-08-19 Thread Andy Goryachev
On Sun, 18 Aug 2024 21:33:46 GMT, Martin Fox wrote: >> I tested on both XWayland and Xorg. They are never negative. >> >> The input method window did always pop up on the right place. >> >> ![image](https://github.com/user-attachments/assets/05568b82-3602-48d0-acf1-65aabc8a316b) >> >> ![image]

Re: RFR: 8301121: RichTextArea Control (Incubator) [v3]

2024-08-19 Thread Andy Goryachev
On Mon, 19 Aug 2024 05:01:13 GMT, Robert Lichtenberger wrote: >> You are right, but this is just a default implementation. you can still >> implement your own `BasicTextModel.Content` and pass it to the constructor. >> >> Do you want to see an in-memory implementation optimized for large numb

RFR: 8338306: WebView Drag and Drop fails with WebKit 619.1

2024-08-19 Thread Hima Bindu Meda
This commit resolves drag and drop issue observed with Webkit-619.1. Verified build on all platforms. No issue seen - Commit messages: - Resolve DragandDrop issue Changes: https://git.openjdk.org/jfx/pull/1538/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1538&range=00

Re: RFR: 8301121: RichTextArea Control (Incubator) [v3]

2024-08-19 Thread Andy Goryachev
On Mon, 19 Aug 2024 05:05:08 GMT, Robert Lichtenberger wrote: >> Correct, this is just a demo. >> >> The information passed to the **SyntaxDecorator** interface should be >> sufficient to support any "real" syntax, at least I hope it is. We are >> passing the model to each method, so it can

Re: RFR: 8338478: [macos] Crash in CoreText with certain strings using JDK 22 or later

2024-08-19 Thread Ambarish Rapte
On Sat, 17 Aug 2024 21:02:59 GMT, Phil Race wrote: > The test in the bug report crashes reliably with JDK 22 on retina. > It coincides with an update to the macOS compilers which seem likely to > eagerly invalidate the target of a CFRelease on the native CTFontRef. > Adding a ReachabilityFence t

Re: RFR: 8338478: [macos] Crash in CoreText with certain strings using JDK 22 or later

2024-08-19 Thread Kevin Rushforth
On Sat, 17 Aug 2024 21:02:59 GMT, Phil Race wrote: > The test in the bug report crashes reliably with JDK 22 on retina. > It coincides with an update to the macOS compilers which seem likely to > eagerly invalidate the target of a CFRelease on the native CTFontRef. > Adding a ReachabilityFence t

Re: RFR: 8338478: [macos] Crash in CoreText with certain strings using JDK 22 or later

2024-08-19 Thread Kevin Rushforth
On Sat, 17 Aug 2024 21:02:59 GMT, Phil Race wrote: > The test in the bug report crashes reliably with JDK 22 on retina. > It coincides with an update to the macOS compilers which seem likely to > eagerly invalidate the target of a CFRelease on the native CTFontRef. > Adding a ReachabilityFence t

[jfx23u] Integrated: 8319779: SystemMenu: memory leak due to listener never being removed

2024-08-19 Thread Johan Vos
On Sun, 18 Aug 2024 20:46:00 GMT, Johan Vos wrote: > Hi all, > > This pull request contains a backport of commit 25ac6fed from the openjdk/jfx > repository. > > The commit being backported was authored by Johan Vos on 25 Jul 2024 and was > reviewed by John Hendrikx, Ambarish Rapte and Jose Pe

[jfx23u] Integrated: 8334874: Horizontal scroll events from touch pads should scroll the TabPane tabs

2024-08-19 Thread Johan Vos
On Sun, 18 Aug 2024 20:36:48 GMT, Johan Vos wrote: > Hi all, > > This pull request contains a backport of commit > [1bdb93c7](https://github.com/openjdk/jfx/commit/1bdb93c792cf7c218c74ec5cacda8bac1242f73b) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The commit being

Re: RFR: 8336938: Update libFFI to 3.4.6 [v2]

2024-08-19 Thread Joeri Sykora
On Tue, 13 Aug 2024 19:04:09 GMT, Alexander Matveev wrote: >> - libFFI updated to 3.4.6. >> - No additional changes are done. >> - Tested on Windows, macOS and Linux with all supported formats. > > Alexander Matveev has updated the pull request incrementally with one > additional commit since t

Aw: Label Text Selection

2024-08-19 Thread Marius Hanl
I also think this might be a good addition to the JFX Core. This behavior should be off by default, but can be turned on via CSS or Code. Another idea could be a new Control that extends from Label.   -- Marius     Gesendet: Freitag, 16. August 2024 um 12:12 Uhr Von: "Dirk Lemmermann" An: "ope

[jfx17u] Integrated: 8334657: Enable binary check

2024-08-19 Thread Johan Vos
On Sun, 18 Aug 2024 20:37:23 GMT, Johan Vos wrote: > Hi all, > > This pull request contains a backport of commit 101e5175 from the openjdk/jfx > repository. > > The commit being backported was authored by Kevin Rushforth on 25 Jun 2024 > and was reviewed by Ambarish Rapte and Phil Race. > >

[jfx21u] Integrated: 8334657: Enable binary check

2024-08-19 Thread Johan Vos
On Sun, 18 Aug 2024 20:46:48 GMT, Johan Vos wrote: > Hi all, > > This pull request contains a backport of commit 101e5175 from the openjdk/jfx > repository. > > The commit being backported was authored by Kevin Rushforth on 25 Jun 2024 > and was reviewed by Ambarish Rapte and Phil Race. > >

Re: Label Text Selection

2024-08-19 Thread Dirk Lemmermann
That looks like a much better approach. We implemented the initial version of the selectable text control for JavaFX 8, so the whole hit point API wasn’t even there back then (or at least not public). I think I will move the control to use your approach … which is probably what the TextArea is d