Integrated: 8338016: SplitMenuButton constructors should match MenuButton

2024-08-16 Thread Andy Goryachev
On Tue, 13 Aug 2024 22:27:58 GMT, Andy Goryachev wrote: > Adding SplitMenuButton constructors matching MenuButton: > > - public SplitMenuButton(String text) > - public SplitMenuButton(String text, Node graphic) > - public SplitMenuButton(String text, Node graphic, MenuItem... items) This pull r

Re: RFR: 8337400: [Linux] Initial window position is not centered on Ubuntu 24.04 / Xorg

2024-08-16 Thread Kevin Rushforth
On Mon, 29 Jul 2024 17:46:52 GMT, Thiago Milczarek Sayao wrote: > On Ubuntu 24.04 with Xorg windows are not shown centered. > > This is due a configure event being received with position 0,0 which is wrong. > > The fix ignores the configure events until the window is mapped. This causes a reg

Re: RFR: 8338016: SplitMenuButton constructors should match MenuButton [v2]

2024-08-16 Thread Kevin Rushforth
On Thu, 15 Aug 2024 14:46:23 GMT, Andy Goryachev wrote: >> Adding SplitMenuButton constructors matching MenuButton: >> >> - public SplitMenuButton(String text) >> - public SplitMenuButton(String text, Node graphic) >> - public SplitMenuButton(String text, Node graphic, MenuItem... items) > > And

Re: RFR: 8323706: Remove SimpleSelector and CompoundSelector classes [v8]

2024-08-16 Thread Kevin Rushforth
On Tue, 13 Aug 2024 12:18:12 GMT, John Hendrikx wrote: >> Moves `SimpleSelector` and `CompoundSelector` to internal packages. >> >> This can be done with only a minor API break, as `SimpleSelector` and >> `CompoundSelector` were public before. However, these classes could not be >> constructe

Re: RFR: 8323706: Remove SimpleSelector and CompoundSelector classes [v8]

2024-08-16 Thread Andy Goryachev
On Tue, 13 Aug 2024 12:18:12 GMT, John Hendrikx wrote: >> Moves `SimpleSelector` and `CompoundSelector` to internal packages. >> >> This can be done with only a minor API break, as `SimpleSelector` and >> `CompoundSelector` were public before. However, these classes could not be >> constructe

Re: RFR: 8323706: Remove SimpleSelector and CompoundSelector classes [v7]

2024-08-16 Thread Kevin Rushforth
On Wed, 7 Aug 2024 22:58:57 GMT, John Hendrikx wrote: > Anyway, I'm fine with rejecting values that are not `TYPE_SIMPLE`. That seems like a good idea for maximum compatibility. - PR Review Comment: https://git.openjdk.org/jfx/pull/1333#discussion_r1720105420

Re: RFR: 8323706: Remove SimpleSelector and CompoundSelector classes [v8]

2024-08-16 Thread Kevin Rushforth
On Tue, 13 Aug 2024 12:18:12 GMT, John Hendrikx wrote: >> Moves `SimpleSelector` and `CompoundSelector` to internal packages. >> >> This can be done with only a minor API break, as `SimpleSelector` and >> `CompoundSelector` were public before. However, these classes could not be >> constructe

Re: RFR: 8087863: Mac: "Select All" within ListView/TreeView is handled differently depending on the useSystemMenuBar value

2024-08-16 Thread Andy Goryachev
On Fri, 2 Aug 2024 19:07:35 GMT, Martin Fox wrote: > macOS processes a shortcut key like Cmd+A in two phases. In the first phase > it’s shopped around as a “key equivalent”. If it’s not consumed as a key > equivalent it enters the second phase and processed as a normal keyDown > event. Among o

Re: RFR: 8087863: Mac: "Select All" within ListView/TreeView is handled differently depending on the useSystemMenuBar value

2024-08-16 Thread Martin Fox
On Tue, 13 Aug 2024 21:46:22 GMT, Andy Goryachev wrote: > is there a compelling reason we are not using Event::isConsumed? As detailed in the discussion of PR #1523 the `isConsumed` flag doesn't work because the consumed event is a copy of the original one. The reliable way is to compare the r

Re: RFR: 8087863: Mac: "Select All" within ListView/TreeView is handled differently depending on the useSystemMenuBar value

2024-08-16 Thread Martin Fox
On Fri, 2 Aug 2024 19:07:35 GMT, Martin Fox wrote: > macOS processes a shortcut key like Cmd+A in two phases. In the first phase > it’s shopped around as a “key equivalent”. If it’s not consumed as a key > equivalent it enters the second phase and processed as a normal keyDown > event. Among o

Re: RFR: 8087863: Mac: "Select All" within ListView/TreeView is handled differently depending on the useSystemMenuBar value [v2]

2024-08-16 Thread Martin Fox
> macOS processes a shortcut key like Cmd+A in two phases. In the first phase > it’s shopped around as a “key equivalent”. If it’s not consumed as a key > equivalent it enters the second phase and processed as a normal keyDown > event. Among other things the key equivalent phase ensures the shor

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v22]

2024-08-16 Thread Martin Fox
On Sun, 9 Jun 2024 12:56:32 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >> positioning on `InputMethodRequest`. >>

Re: Label Text Selection

2024-08-16 Thread Andy Goryachev
TextArea is probably the right approach given the requirements (selection, avoiding ellipses). It needs one improvement though which is “use content height” https://bugs.openjdk.org/browse/JDK-8310593 RFE to get rid of the scroll bars. One can also try implementing a custom component modeled a

Re: Label Text Selection

2024-08-16 Thread quizynox
Hello, Both TextFlow and Text support the HitInfo API, which makes getting selected characters very easy. Then you just need to wrap the selected characters in Path. The way it is implemented in GemsFX with overlay pane is quite complicated. Here is a rough sketch of the selectable TextFlow I

Re: Label Text Selection

2024-08-16 Thread Tobias Oelgarte
I would also like to see this implemented, but as an additional "SelectableLabel" control, to avoid side effects (ellipsise, ...). I also had to use the non editable TextField hack way to often. On 16.08.24 12:29, Thiago Milczarek Sayão wrote: Hi Dirk, This would be great. It's a feature I mi

Re: Label Text Selection

2024-08-16 Thread Thiago Milczarek Sayão
Hi Dirk, This would be great. It's a feature I miss. On my scenario (we do a POS pharmacy software) users want to copy things such as product code/barcode, description, etc. I think it's not a trivial task to develop this, since labels can wrap, ellipsise. They are inside tables and other compon

Re: Label Text Selection

2024-08-16 Thread Daniel Peintner
Hi Dirk, all, Personally I think this would be a great addition since I am getting the same request over and over again. I solved it by *mis-using* a TextField and making it look like a Label. Thanks all for your efforts, -- Daniel On Fri, Aug 16, 2024 at 12:13 PM Dirk Lemmermann wrote: > Hi

Label Text Selection

2024-08-16 Thread Dirk Lemmermann
Hi everyone, I recently added a custom text control (called “TextView") to the GemsFX project. It supports a somewhat limited text selection. Selection is only possible on a per-word basis. I received a bit of feedback on this control and I was wondering whether it would be worth thinking about