Updated libxslt to v1.1.42. Verified build on all platforms. No issue seen
-
Commit messages:
- Update libxslt to v1.1.42
Changes: https://git.openjdk.org/jfx/pull/1527/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1527&range=00
Issue: https://bugs.openjdk.org/browse/JD
On Sat, 8 Jun 2024 09:11:03 GMT, Glavo wrote:
>> Thiago Milczarek Sayao has updated the pull request with a new target base
>> due to a merge or a rebase. The pull request now contains 95 commits:
>>
>> - Merge branch 'refs/heads/master' into new_ime
>> - Merge branch 'master' into new_ime
>>
On Thu, 1 Aug 2024 23:49:08 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed a bug
>
> modules/javafx.graphics/src/main/java/javafx/scene/paint/Color.java line 1956:
>
>> 1954:
>> 1955:
On Thu, 1 Aug 2024 23:36:41 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed a bug
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/BorderConverter.java
> line 270:
>
>> 26
> This PR completes the CSS Transitions story (see #870) by adding
> interpolation support for backgrounds and borders, making them targetable by
> transitions.
>
> `Background` and `Border` objects are deeply immutable, but not
> interpolatable. Consider the following `Background`, which descr
On Thu, 1 Aug 2024 23:21:12 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed a bug
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/BackgroundPosition.java
> line 266:
>
>>
On Thu, 1 Aug 2024 21:40:54 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed a bug
>
> modules/javafx.graphics/src/main/java/javafx/animation/Interpolatable.java
> line 37:
>
>> 35: *
On Thu, 1 Aug 2024 22:10:31 GMT, Kevin Rushforth wrote:
> I note that PR #1471 was originally proposed to address this. Can you
> highlight the differences? Are any of the comments added to that PR still
> relevant?
The CSS specification allows specifying separate transitions for sub-propertie
On Thu, 1 Aug 2024 23:25:10 GMT, Alexander Matveev wrote:
> I think this issue/PR should specify it.
The main reason to mention what needs to be corrected is to help the person who
will be working on JDK-8337686 many years from now ;-)
-
PR Comment: https://git.openjdk.org/jfx/pul
On Wed, 31 Jul 2024 19:34:12 GMT, Michael Strauß wrote:
>> This PR completes the CSS Transitions story (see #870) by adding
>> interpolation support for backgrounds and borders, making them targetable by
>> transitions.
>>
>> `Background` and `Border` objects are deeply immutable, but not
>>
On Thu, 1 Aug 2024 21:21:45 GMT, Andy Goryachev wrote:
> > JDK-8337686
>
> thank you for filing the RFE. Should JDK-8337686 explicitly specify that the
> double conversion introduced in this PR be replaced?
I think this issue/PR should specify it. I just updated description for this PR
that c
On Thu, 1 Aug 2024 19:51:09 GMT, Martin Fox wrote:
>> When drawing to the screen JavaFX is producing sRGB colors but on macOS
>> that’s not necessarily what the user is seeing. Since the pixels are not
>> tagged as sRGB the OS is copying them unmodified to the frame buffer to be
>> displayed i
On Mon, 22 Jul 2024 20:30:51 GMT, John Hendrikx wrote:
>>> You might want to merge in the latest upstream master to pick up the JUnit
>>> 5 change (also, Skara doesn't report a conflict, but GitHub does).
>>
>> Skara woke up and reported the merge conflict, so you will need to merge
>> master
On Mon, 29 Jul 2024 17:46:52 GMT, Thiago Milczarek Sayao
wrote:
> On Ubuntu 24.04 with Xorg windows are not shown centered.
>
> This is due a configure event being received with position 0,0 which is wrong.
>
> The fix ignores the configure events until the window is mapped.
I've noticed a fe
On Mon, 29 Jul 2024 18:45:23 GMT, Marius Hanl wrote:
> This PR fixes a bug where a `TableView` inside a `TitledPane` may 'duplicate'
> the cells. This actually has nothing to do with the `TitledPane`, but it
> triggered the bug easily due to its nature to change the size of his content
> when
On Thu, 1 Aug 2024 22:41:05 GMT, Alexander Zuev wrote:
>> Initial implementation of the protocol.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removing methods that supposed to generate attributed strings. String
> at
On Thu, 1 Aug 2024 22:22:41 GMT, Andy Goryachev wrote:
> how do I set 3 reviewers and at least 2 "R"eviewers?
You can't. You can set it to `/reviewers 2 reviewers` and ask others to also
review.
-
PR Comment: https://git.openjdk.org/jfx/pull/1524#issuecomment-2264139892
> Initial implementation of the protocol.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Removing methods that supposed to generate attributed strings. String
attributes are not available for the static text elements and cause exc
On Tue, 30 Jul 2024 21:01:15 GMT, Andy Goryachev wrote:
> Incubating a new feature - rich text control, **RichTextArea**, intended to
> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The
> main design goal is to provide a control that is complete enough to be useful
On Wed, 31 Jul 2024 19:34:12 GMT, Michael Strauß wrote:
>> This PR completes the CSS Transitions story (see #870) by adding
>> interpolation support for backgrounds and borders, making them targetable by
>> transitions.
>>
>> `Background` and `Border` objects are deeply immutable, but not
>>
On Thu, 1 Aug 2024 20:49:35 GMT, Alexander Matveev wrote:
> JDK-8337686
thank you for filing the RFE. Should JDK-8337686 explicitly specify that the
double conversion introduced in this PR be replaced?
-
PR Comment: https://git.openjdk.org/jfx/pull/1525#issuecomment-2264025287
On Thu, 1 Aug 2024 15:12:15 GMT, Andy Goryachev wrote:
> This might sound silly, but these formats seem to differ by the way color
> bits are laid out in memory - would it be possible to write a utility that
> does the direct conversion instead of calling two conversion methods?
NV12 and IYUV
On Thu, 1 Aug 2024 19:51:09 GMT, Martin Fox wrote:
>> When drawing to the screen JavaFX is producing sRGB colors but on macOS
>> that’s not necessarily what the user is seeing. Since the pixels are not
>> tagged as sRGB the OS is copying them unmodified to the frame buffer to be
>> displayed i
On Thu, 1 Aug 2024 18:02:05 GMT, Andy Goryachev wrote:
>> I'm not sure this test needs to be that precise. And I'm fine with the
>> threshold falling below 2.0/255.0 since it should be as small as possible (I
>> even experimented briefly with lower numbers). I haven't run into an issue
>> on t
> When drawing to the screen JavaFX is producing sRGB colors but on macOS
> that’s not necessarily what the user is seeing. Since the pixels are not
> tagged as sRGB the OS is copying them unmodified to the frame buffer to be
> displayed in the screen’s color space. In general Mac’s don’t defaul
On Thu, 1 Aug 2024 17:42:16 GMT, Andy Goryachev wrote:
>> Martin Fox has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated comments concerning the AWT Robot
>
> modules/javafx.graphics/src/main/native-glass/mac/GlassRobot.m line 423:
>
On Tue, 30 Jul 2024 23:34:13 GMT, Martin Fox wrote:
>> When drawing to the screen JavaFX is producing sRGB colors but on macOS
>> that’s not necessarily what the user is seeing. Since the pixels are not
>> tagged as sRGB the OS is copying them unmodified to the frame buffer to be
>> displayed
On Tue, 30 Jul 2024 23:31:38 GMT, Martin Fox wrote:
>> tests/system/src/test/java/test/robot/javafx/scene/SRGBTest.java line 52:
>>
>>> 50:
>>> 51: import org.junit.Test;
>>> 52: import static org.junit.Assume.assumeTrue;
>>
>> should we use junit5 for the new tests?
>
> This test is based on
On Thu, 1 Aug 2024 16:57:40 GMT, 8Mi_Yile wrote:
> pls test and accept this pr can use this
> [app](https://github.com/HMCL-dev/HMCL/releases) test this fix
@8MiYile : are you saying that the proposed fix works with this app? Would you
provide more information on which platform(s) you've test
On Sun, 9 Jun 2024 12:56:32 GMT, Thiago Milczarek Sayao
wrote:
>> This replaces obsolete XIM and uses gtk api for IME.
>> Gtk uses [ibus](https://github.com/ibus/ibus)
>>
>> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative
>> positioning on `InputMethodRequest`.
>>
On Wed, 31 Jul 2024 03:45:20 GMT, Alexander Matveev
wrote:
> - For some reason H.265 decoder on Windows accepts proposed media format
> without error, but does not actually change output format.
> - For 8-bit we proposed IYUV, but decoder outputs NV12. For 10-bit we
> proposed NV12, but decode
Fixing WebView on iOS
(I couldn't compile it because I don't know how to build it for iOS, but the
code should be correct.)
@johanvos
If this looks reasonable to you, can you provide a test build for @dlemmermann ?
Then he can test it with his JFX-Central iOS version.
-
Commit mess
On Thu, 1 Aug 2024 10:04:12 GMT, Johan Vos wrote:
> almost clean backport of 8319779: SystemMenu: memory leak due to listener
> never being removed
> Didn't apply clean because the imports where shuffled.
This pull request has now been integrated.
Changeset: ef8397aa
Author:Johan Vos
URL:
On Thu, 1 Aug 2024 10:04:12 GMT, Johan Vos wrote:
> almost clean backport of 8319779: SystemMenu: memory leak due to listener
> never being removed
> Didn't apply clean because the imports where shuffled.
Marked as reviewed by jpereda (Reviewer).
-
PR Review: https://git.openjdk.o
On Thu, 1 Aug 2024 08:47:38 GMT, Johan Vos wrote:
> Almost clean backport of JDK-8334874: Horizontal scroll events from touch
> pads should scroll the TabPane tabs
> The only change was the (c) date that had changed.
This pull request has now been integrated.
Changeset: 29aa85ab
Author:Joh
almost clean backport of 8319779: SystemMenu: memory leak due to listener never
being removed
Didn't apply clean because the imports where shuffled.
-
Commit messages:
- Backport 25ac6fed22d0f49d01c831aaa48049c34899fe96
Changes: https://git.openjdk.org/jfx21u/pull/66/files
Webrev
On Thu, 1 Aug 2024 08:41:59 GMT, Johan Vos wrote:
> Backport of 8323787: Mac System MenuBar throws IOB exception
>
> Required manual changes as the location of the test has changed.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jfx21u/p
On Thu, 1 Aug 2024 08:41:59 GMT, Johan Vos wrote:
> Backport of 8323787: Mac System MenuBar throws IOB exception
>
> Required manual changes as the location of the test has changed.
closed in favor of #66
-
PR Comment: https://git.openjdk.org/jfx21u/pull/63#issuecomment-226265826
On Thu, 1 Aug 2024 09:23:42 GMT, Johan Vos wrote:
> 8318841: macOS: Memory leak with MenuItem when Menu.useSystemMenuBar(true) is
> used
This pull request has now been integrated.
Changeset: e6f725f5
Author:Johan Vos
URL:
https://git.openjdk.org/jfx21u/commit/e6f725f59a801805bab090
8318841: macOS: Memory leak with MenuItem when Menu.useSystemMenuBar(true) is
used
-
Commit messages:
- Backport 8dd3c37cae3dd52dc3a258033d0e8f168ceaf307
Changes: https://git.openjdk.org/jfx21u/pull/65/files
Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=65&range=00
Issue:
Almost clean backport of JDK-8334874: Horizontal scroll events from touch pads
should scroll the TabPane tabs
The only change was the (c) date that had changed.
-
Commit messages:
- 8334874: Horizontal scroll events from touch pads should scroll the TabPane
tabs
Changes: https://g
Backport of 8323787: Mac System MenuBar throws IOB exception
Required manual changes as the location of the test has changed.
-
Commit messages:
- 8319779: SystemMenu: memory leak due to listener never being removed
Changes: https://git.openjdk.org/jfx21u/pull/63/files
Webrev: h
On Fri, 26 Jul 2024 23:00:33 GMT, Kevin Rushforth wrote:
>> This PR fixes a bad assumption in a few places in `build.gradle`, which
>> assumes that the module name can be derived from the name of the gradle
>> project name by prepending `"javafx."` to the name rather than using the
>> `moduleN
43 matches
Mail list logo
