On Fri, 26 Jul 2024 18:18:07 GMT, Kevin Rushforth wrote:
>> Kevin Rushforth has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix bug where String was being used as if it were a Project
>
> build.gradle line 1799:
>
>> 1797:
> This PR fixes a bad assumption in a few places in `build.gradle`, which
> assumes that the module name can be derived from the name of the gradle
> project name by prepending `"javafx."` to the name rather than using the
> `moduleName` property of the project. In many of these places, the logi
On Fri, 26 Jul 2024 17:04:17 GMT, Kevin Rushforth wrote:
> This PR fixes a bad assumption in a few places in `build.gradle`, which
> assumes that the module name can be derived from the name of the gradle
> project name by prepending `"javafx."` to the name rather than using the
> `moduleName`
This PR fixes a bad assumption in a few places in `build.gradle`, which assumes
that the module name can be derived from the name of the gradle project name by
prepending `"javafx."` to the name rather than using the `moduleName` property
of the project. In many of these places, the logic replac
On Fri, 26 Jul 2024 17:04:17 GMT, Kevin Rushforth wrote:
> This PR fixes a bad assumption in a few places in `build.gradle`, which
> assumes that the module name can be derived from the name of the gradle
> project name by prepending `"javafx."` to the name rather than using the
> `moduleName`
Hello, Kevin
Yes, I filed that enhancement request.
When user presses CTRL+C then SIGINT signal is sent to the process. SIGINT is a
signal used to request a graceful termination of a process, typically initiated
by the user(more details are here https://stackoverflow.com/a/4047975).
Now, we a
Hi Pavel
Not sure if this will help in your situation but you can try using
"primaryStage.setOnCloseRequest" where you can run any cleanup code needed.
If you want to cancel the close request completely then just consume the
WindowEvent and then later issue Platform.exit() when ready.
Reg
I am not sure we will want to disabling the shutdown hook, since that is
likely to cause problems (they were added to fix bugs that resulted from
applications calling System.exit()).
In the bug report for JDK-8320923, you mentioned that Swing doesn't have
this problem, but that's because Swing
On Thu, 25 Jul 2024 19:03:14 GMT, Andy Goryachev wrote:
> Fixed Eclipse .classpath in the systemTests-test project.
Marked as reviewed by jhendrikx (Reviewer).
-
PR Review: https://git.openjdk.org/jfx/pull/1516#pullrequestreview-2201629740
On Thu, 25 Jul 2024 19:03:14 GMT, Andy Goryachev wrote:
> Fixed Eclipse .classpath in the systemTests-test project.
I'm not an Eclipse user, but this looks like a trivially correct fix.
-
Marked as reviewed by kcr (Lead).
PR Review: https://git.openjdk.org/jfx/pull/1516#pullreques
On Thu, 25 Jul 2024 19:07:01 GMT, Andy Goryachev wrote:
> Added missing @Overrides
>
> We need to turn this warning into error in the gradle build.
Marked as reviewed by kcr (Lead).
-
PR Review: https://git.openjdk.org/jfx/pull/1517#pullrequestreview-2201616415
11 matches
Mail list logo
