On Sun, 9 Jun 2024 12:56:32 GMT, Thiago Milczarek Sayao
wrote:
>> This replaces obsolete XIM and uses gtk api for IME.
>> Gtk uses [ibus](https://github.com/ibus/ibus)
>>
>> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative
>> positioning on `InputMethodRequest`.
>>
On Wed, 17 Jul 2024 14:42:43 GMT, Andy Goryachev wrote:
>> Hello,
>>
>> There was a typo in the documentation of TreeTableView.
>> I have changed TreeTableColumns to TreeTableColumn
>>
>> Please review.
>>
>> Regards,
>> Anupam
>
> you may want to configure github actions for this repository -
On Tue, 9 Jul 2024 09:06:58 GMT, Johan Vos wrote:
>> A listener was added but never removed.
>> This patch removes the listener when the menu it links to is cleared. Fix
>> for https://bugs.openjdk.org/browse/JDK-8319779
>
> Johan Vos has updated the pull request incrementally with one additiona
On Tue, 9 Jul 2024 14:48:30 GMT, Kevin Rushforth wrote:
>> I manually reverted the add/remove part, and replaced it with `git mv`. I
>> assume/hope that by squashing the commits, the add/remove will not be part
>> of the change.
>
> git doesn't actually track renames and copies, so there is ult
On Thu, 23 May 2024 10:53:36 GMT, Thiago Milczarek Sayao
wrote:
>> This fixes two bugs appointed on the JBS issue:
>>
>> 1) Sometimes window was moving to the top left corner - seems to be a bug
>> somewhere in `gdk_window_get_origin` when used before map (a X concept when
>> the window appea
On Wed, 17 Jul 2024 12:21:59 GMT, Kevin Rushforth wrote:
> Clean backport of this crash-on-exit fix to the `jfx23` stabilization branch.
forgot to mention: checked the target branch is jfx23
-
PR Comment: https://git.openjdk.org/jfx/pull/1511#issuecomment-2234396795
On Wed, 17 Jul 2024 12:21:59 GMT, Kevin Rushforth wrote:
> Clean backport of this crash-on-exit fix to the `jfx23` stabilization branch.
lgtm
-
Marked as reviewed by angorya (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1511#pullrequestreview-2184019091
On Wed, 17 Jul 2024 12:21:59 GMT, Kevin Rushforth wrote:
> Clean backport of this crash-on-exit fix to the `jfx23` stabilization branch.
Reviewer: @andy-goryachev-oracle
(as it is a clean backport, a single Reviewer will suffiice)
-
PR Comment: https://git.openjdk.org/jfx/pull/15
On Tue, 16 Jul 2024 21:57:30 GMT, John Hendrikx wrote:
> First, the order from highest to lowest priority is: `INLINE` (using
> `Node::setStyle`), `AUTHOR` (from user set stylesheets), `USER` (for setters)
> and then `USER_AGENT` (a stylesheet like Modena set by FX itself).
What are the priori
On Wed, 17 Jul 2024 04:55:25 GMT, Alexander Zuev wrote:
>> modules/javafx.graphics/src/main/native-glass/mac/a11y/AccessibleBase.m line
>> 53:
>>
>>> 51: [rolesMap setObject:@"JFXCheckboxAccessibility"
>>> forKey:@"CHECK_BOX"];
>>> 52: [rolesMap setObject:@"JFXCheckboxAccessibility"
>
On Wed, 17 Jul 2024 05:34:31 GMT, Alexander Zuev wrote:
>> Initial implementation of the protocol.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add comment about AccessibleRole enuM
lgtm
-
Marked as revi
On Wed, 17 Jul 2024 05:53:45 GMT, ANUPAM DEV wrote:
> Hello,
>
> There was a typo in the documentation of TreeTableView.
> I have changed TreeTableColumns to TreeTableColumn
>
> Please review.
>
> Regards,
> Anupam
thank you for finding and fixing this documentation issue!
you may want to co
Clean backport of this crash-on-exit fix to the `jfx23` stabilization branch.
-
Commit messages:
- Backport 81f11c4a39eb505d17c57a49c5e084f75a169856
Changes: https://git.openjdk.org/jfx/pull/1511/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1511&range=00
Issue: https:/
On Mon, 15 Jul 2024 19:36:43 GMT, Kevin Rushforth wrote:
> This PR solves two related bugs that are caused by events being delivered
> while the FX runtime is in the process of shutting down. These bugs are
> related enough that I think they need to be addressed at the same time. While
> debug
14 matches
Mail list logo
