Integrated: 8289115: Touch events is not dispatched after upgrade to JAVAFX17+

2024-07-02 Thread Michael Strauß
On Tue, 21 May 2024 14:25:51 GMT, Michael Strauß wrote: > This PR fixes a bug > ([JDK-8289115](https://bugs.openjdk.org/browse/JDK-8289115)) that was > introduced with #394, which changed the following line in the > `NotifyTouchInput` function (ViewContainer.cpp): > > - const bool isDirect =

Re: RFR: 8326712: Robot tests fail on XWayland [v4]

2024-07-02 Thread Phil Race
On Tue, 2 Jul 2024 20:04:39 GMT, Alexander Zvegintsev wrote: >> Most of the headful test failures on XWayland are due to screen capture is >> not working. >> >> Wayland, unlike X11, does not allow arbitrary applications to capture the >> screen contents directly. >> Instead, screen capture fu

Re: RFR: 8326619: Stage.sizeToScene() on maximized/fullscreen Stage breaks the Window [v8]

2024-07-02 Thread Kevin Rushforth
On Thu, 27 Jun 2024 11:49:04 GMT, Marius Hanl wrote: >> Change looks good, but I'm still seeing failures on my macOS system (Sonoma >> 14.5, MacBook Pro M1 Max): >> >> >> SizeToSceneTest > testInitialSizeOnSizeToSceneThenFullscreen() FAILED >> org.opentest4j.AssertionFailedError: 1080.0 >=

Re: RFR: 8289115: Touch events is not dispatched after upgrade to JAVAFX17+

2024-07-02 Thread Kevin Rushforth
On Tue, 21 May 2024 14:25:51 GMT, Michael Strauß wrote: > This PR fixes a bug > ([JDK-8289115](https://bugs.openjdk.org/browse/JDK-8289115)) that was > introduced with #394, which changed the following line in the > `NotifyTouchInput` function (ViewContainer.cpp): > > - const bool isDirect =

Re: RFR: 8326712: Robot tests fail on XWayland [v4]

2024-07-02 Thread Kevin Rushforth
On Tue, 2 Jul 2024 20:04:39 GMT, Alexander Zvegintsev wrote: >> Most of the headful test failures on XWayland are due to screen capture is >> not working. >> >> Wayland, unlike X11, does not allow arbitrary applications to capture the >> screen contents directly. >> Instead, screen capture fu

Re: RFR: 8326712: Robot tests fail on XWayland [v3]

2024-07-02 Thread Alexander Zvegintsev
On Tue, 2 Jul 2024 15:36:59 GMT, Kevin Rushforth wrote: >> Alexander Zvegintsev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix the SwingNodeJDialogTest.testNodeRemovalBeforeShow test failure > > modules/javafx.graphics/src/main/java

Re: RFR: 8326712: Robot tests fail on XWayland [v4]

2024-07-02 Thread Alexander Zvegintsev
> Most of the headful test failures on XWayland are due to screen capture is > not working. > > Wayland, unlike X11, does not allow arbitrary applications to capture the > screen contents directly. > Instead, screen capture functionality is managed by the compositor, which can > enforce stricte

Re: RFR: 8326712: Robot tests fail on XWayland [v3]

2024-07-02 Thread Kevin Rushforth
On Tue, 2 Jul 2024 13:07:55 GMT, Alexander Zvegintsev wrote: >> Most of the headful test failures on XWayland are due to screen capture is >> not working. >> >> Wayland, unlike X11, does not allow arbitrary applications to capture the >> screen contents directly. >> Instead, screen capture fu

Re: RFR: 8334593: Adding, removing and then adding a JFXPanel again leads to NullPointerException [v3]

2024-07-02 Thread Andy Goryachev
On Tue, 2 Jul 2024 03:45:24 GMT, Prasanta Sadhukhan wrote: > QuantumToolkit.runWithRenderLock locking a class field may not be sufficient. or rather, cannot be sufficient when multiple threads are accessing the field, as there are no guarantees as to the order of invocations. Instead, we mi

Re: RFR: 8326712: Robot tests fail on XWayland [v3]

2024-07-02 Thread Alexander Zvegintsev
On Tue, 2 Jul 2024 13:07:55 GMT, Alexander Zvegintsev wrote: >> Most of the headful test failures on XWayland are due to screen capture is >> not working. >> >> Wayland, unlike X11, does not allow arbitrary applications to capture the >> screen contents directly. >> Instead, screen capture fu

Re: RFR: 8326712: Robot tests fail on XWayland [v3]

2024-07-02 Thread Alexander Zvegintsev
> Most of the headful test failures on XWayland are due to screen capture is > not working. > > Wayland, unlike X11, does not allow arbitrary applications to capture the > screen contents directly. > Instead, screen capture functionality is managed by the compositor, which can > enforce stricte

Re: Should we document Styleable properties?

2024-07-02 Thread Eric Bresie
A little off topic but… There is a pending JEP for allowing markup to be included in javadocs https://openjdk.org/jeps/467 Eric Bresie ebre...@gmail.com On Mon, Jul 1, 2024 at 4:35 PM Michael Strauß wrote: > Further testing shows that while the javadoc tool does support custom > tags, it does

[jfx17u] RFR: 8236689: macOS 10.15 Catalina: LCD text renders badly

2024-07-02 Thread Jose Pereda
Hi all, This pull request contains a clean backport of commit [a118d333](https://github.com/openjdk/jfx/commit/a118d33314a363336134d31c45b50329594e5a24) from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. The commit being backported was authored by Phil Race on 20 Oct 2021 and was