Re: RFR: 8088923: IOOBE when adding duplicate categories to the BarChart [v5]

2024-06-22 Thread Michael Strauß
On Sat, 22 Jun 2024 10:55:28 GMT, Markus Mack wrote: >> This PR provides the test case given in the JBS issue, and a simple fix for >> the index calculation when inserting data after previous data with duplicate >> categories. >> >> Also, I've added a comment to `BarChart`s javadoc, clarifying

Re: RFR: 8327255: javac lint warnings: removal, missing-explicit-ctor [v2]

2024-06-22 Thread Kevin Rushforth
On Tue, 18 Jun 2024 14:16:25 GMT, Ambarish Rapte wrote: >> Kevin Rushforth has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> co

Re: RFR: 8327255: javac lint warnings: removal, missing-explicit-ctor [v2]

2024-06-22 Thread Kevin Rushforth
> This PR updates `build.gradle` to define javac lint options for three > different types of java compilation tasks: sdk classes, test classes > (including shims), and tool classes (including JSLC). The defaults for these > three groups of lint options are specified in `build.gradle`. > > We al

Re: RFR: 8088923: IOOBE when adding duplicate categories to the BarChart [v5]

2024-06-22 Thread Markus Mack
On Sat, 22 Jun 2024 10:55:28 GMT, Markus Mack wrote: >> This PR provides the test case given in the JBS issue, and a simple fix for >> the index calculation when inserting data after previous data with duplicate >> categories. >> >> Also, I've added a comment to `BarChart`s javadoc, clarifying

Re: RFR: 8088923: IOOBE when adding duplicate categories to the BarChart [v5]

2024-06-22 Thread Markus Mack
> This PR provides the test case given in the JBS issue, and a simple fix for > the index calculation when inserting data after previous data with duplicate > categories. > > Also, I've added a comment to `BarChart`s javadoc, clarifying the behavior > that was apparently assumed (but broken) pr

Re: RFR: 8088923: IOOBE when adding duplicate categories to the BarChart [v4]

2024-06-22 Thread Markus Mack
On Fri, 21 Jun 2024 22:07:22 GMT, Andy Goryachev wrote: >> Markus Mack has updated the pull request incrementally with one additional >> commit since the last revision: >> >> testAddingDataAtIndex & fix > > modules/javafx.controls/src/main/java/javafx/scene/chart/BarChart.java line > 227: >