Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v18]

2024-06-13 Thread Jose Pereda
On Thu, 13 Jun 2024 20:07:32 GMT, Johan Vos wrote: >> A listener was added but never removed. >> This patch removes the listener when the menu it links to is cleared. Fix >> for https://bugs.openjdk.org/browse/JDK-8319779 > > Johan Vos has updated the pull request incrementally with two addition

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v16]

2024-06-13 Thread Johan Vos
On Thu, 13 Jun 2024 10:25:15 GMT, Jose Pereda wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add more type info > > modules/javafx.graphics/src/shims/java/com/sun/javafx/tk/quantum/GlassSystemMenuShim.java > line 37

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v2]

2024-06-13 Thread Johan Vos
On Tue, 12 Dec 2023 07:05:49 GMT, Ambarish Rapte wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> process reviewers comments > > Looks all good to me. > Is it possible to add an automated test ? @arapte if possible, c

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v18]

2024-06-13 Thread Johan Vos
> A listener was added but never removed. > This patch removes the listener when the menu it links to is cleared. Fix for > https://bugs.openjdk.org/browse/JDK-8319779 Johan Vos has updated the pull request incrementally with two additional commits since the last revision: - process more revie

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v17]

2024-06-13 Thread Johan Vos
> A listener was added but never removed. > This patch removes the listener when the menu it links to is cleared. Fix for > https://bugs.openjdk.org/browse/JDK-8319779 Johan Vos has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 18 commi

Re: 8289521: Publication to Apple App Store still not possible with JavaFX web 21

2024-06-13 Thread Laurin Murer
Yes, it sounds like the method cache_simulate_memory_warning_event was never public (at least I couldn’t find any documentation about it) and Apple started to enforce its removal. As far as I can tell, a user of JavaFX web cannot fix this and has currently no chance of publishing a (new?) app to

Integrated: 8311895: CSS Transitions

2024-06-13 Thread Michael Strauß
On Tue, 16 Aug 2022 03:01:23 GMT, Michael Strauß wrote: > Implementation of [CSS Transitions](https://www.w3.org/TR/css-transitions-1/). > > ### Future enhancements > CSS transition support for backgrounds and borders: #1471 > > ### Limitations > This implementation supports both shorthand and

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v16]

2024-06-13 Thread Kevin Rushforth
On Thu, 13 Jun 2024 07:21:47 GMT, John Hendrikx wrote: > The new test passed with both the old and the new version (I reverted the > code, aside from leaving `setMenuBindings` `protected`). Is the test testing > the right thing? > > (If relevant, this was done on a Windows platform) That's no

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v16]

2024-06-13 Thread Jose Pereda
On Thu, 9 May 2024 19:48:19 GMT, Johan Vos wrote: >> A listener was added but never removed. >> This patch removes the listener when the menu it links to is cleared. Fix >> for https://bugs.openjdk.org/browse/JDK-8319779 > > Johan Vos has updated the pull request incrementally with one additiona

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v22]

2024-06-13 Thread leewyatt
On Sun, 9 Jun 2024 16:21:50 GMT, Thiago Milczarek Sayao wrote: > I did an updated build of this branch > [here](https://github.com/tsayao/jfx/releases/download/test-ime/jfx_23_linux_ime.zip) > (for testing only). Wow, thank you. I have downloaded it and will test it as soon as possible.

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v16]

2024-06-13 Thread John Hendrikx
On Thu, 9 May 2024 19:48:19 GMT, Johan Vos wrote: >> A listener was added but never removed. >> This patch removes the listener when the menu it links to is cleared. Fix >> for https://bugs.openjdk.org/browse/JDK-8319779 > > Johan Vos has updated the pull request incrementally with one additiona