On Thu, 2 May 2024 10:03:46 GMT, Ambarish Rapte wrote:
> 1. The test does not compile without fix, hence it won't fail without fix
> as we are only testing the newly added helper method.
Yes, we could not build on existing a11y test.
> 2. It is not required to change the error stream,
> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>
> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, then
> an addition of `start` to it leads to a negative value. This is "fixed" by
> using `Math.max` comparing the `maxLength` and `maxLength + start`.
Oliver Kopp h
On Thu, 2 May 2024 22:10:24 GMT, Andy Goryachev wrote:
>> Adds **Labeled.textTruncated** property which indicates when the text is
>> visually truncated (and the ellipsis string is inserted) in order to fit the
>> available width.
>>
>> The new property reacts to changes in the following prope
On Thu, 2 May 2024 18:21:52 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 15 commits:
>>
>> - missing )
>> - review comments
>> - Merge branch 'master' into 8092102.truncated
>>
On Thu, 2 May 2024 18:34:04 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/Labeled.java line
>> 114:
>>
>>> 112: * by itself looks rather weird.
>>> 113: */
>>> 114: private static boolean useActualContentWidth;
>>
>> Even given your comm
> Adds **Labeled.textTruncated** property which indicates when the text is
> visually truncated (and the ellipsis string is inserted) in order to fit the
> available width.
>
> The new property reacts to changes in the following properties:
> - ellipsisString
> - font
> - height
> - text
> - wid
> Adds **Labeled.textTruncated** property which indicates when the text is
> visually truncated (and the ellipsis string is inserted) in order to fit the
> available width.
>
> The new property reacts to changes in the following properties:
> - ellipsisString
> - font
> - height
> - text
> - wid
On Thu, 2 May 2024 17:37:52 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 15 commits:
>>
>> - missing )
>> - review comments
>> - Merge branch 'master' into 8092102.truncated
>>
On Thu, 2 May 2024 18:07:12 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 15 commits:
>>
>> - missing )
>> - review comments
>> - Merge branch 'master' into 8092102.truncated
>>
On Wed, 10 Apr 2024 21:25:10 GMT, Andy Goryachev wrote:
>> Adds **Labeled.textTruncated** property which indicates when the text is
>> visually truncated (and the ellipsis string is inserted) in order to fit the
>> available width.
>>
>> The new property reacts to changes in the following prop
On Thu, 2 May 2024 09:27:41 GMT, drmarmac wrote:
> I can create the PR.
thank you!
-
PR Comment: https://git.openjdk.org/jfx/pull/1431#issuecomment-2090784273
On Wed, 10 Apr 2024 21:25:10 GMT, Andy Goryachev wrote:
>> Adds **Labeled.textTruncated** property which indicates when the text is
>> visually truncated (and the ellipsis string is inserted) in order to fit the
>> available width.
>>
>> The new property reacts to changes in the following prop
On Thu, 2 May 2024 13:12:09 GMT, drmarmac wrote:
>> This PR adds the missing checks, as well as code documentation that an
>> IndexOutOfBoundsException may be thrown.
>
> drmarmac has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes t
On Tue, 23 Apr 2024 06:55:18 GMT, Lukasz Kostyra wrote:
>> drmarmac has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five additional commits
>> s
On Thu, 2 May 2024 12:18:30 GMT, Kevin Rushforth wrote:
>> drmarmac has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JavaDoc updates
>
> modules/javafx.base/src/main/java/javafx/collections/transformation/TransformationList.java
> line 1
> This PR adds the missing checks, as well as code documentation that an
> IndexOutOfBoundsException may be thrown.
drmarmac has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The
On Thu, 2 May 2024 10:06:23 GMT, drmarmac wrote:
>> This PR adds the missing checks, as well as code documentation that an
>> IndexOutOfBoundsException may be thrown.
>
> drmarmac has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JavaDoc upd
On Sun, 24 Mar 2024 15:11:29 GMT, drmarmac wrote:
> This PR adds the missing checks, as well as code documentation that an
> IndexOutOfBoundsException may be thrown.
I've updated the PR with Kevin's suggestions.
-
PR Comment: https://git.openjdk.org/jfx/pull/1432#issuecomment-2090
On Mon, 29 Apr 2024 22:48:28 GMT, Kevin Rushforth wrote:
>> drmarmac has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JavaDoc updates
>
> modules/javafx.base/src/main/java/javafx/collections/transformation/TransformationList.java
> line
> This PR adds the missing checks, as well as code documentation that an
> IndexOutOfBoundsException may be thrown.
drmarmac has updated the pull request incrementally with one additional commit
since the last revision:
JavaDoc updates
-
Changes:
- all: https://git.openjdk.org
On Wed, 1 May 2024 04:46:29 GMT, Oliver Kopp wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>>
>> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`,
>> then an addition of `start` to it leads to a negative value. This is "fixed"
>> by using `Math.max` compar
On Wed, 10 Apr 2024 11:47:28 GMT, drmarmac wrote:
>> This PR should fix the issue and cover all relevant cases with new tests.
>>
>> Note: This involves a small behavior change, as can be seen in
>> dblSpinner_testWrapAround_decrement_twoSteps() in SpinnerTest.java:749. With
>> this change the
> Implementation of [CSS
> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a).
>
> ### Example
>
> .button {
> -fx-background-color: dodgerblue;
> }
>
> .button:hover {
> -fx-background-color: red;
> -fx-scale-x: 1.1;
> -fx-scale-y: 1.1;
>
> transi
23 matches
Mail list logo
