Re: RFR: 8285893: Hiding dialog and showing new one causes dialog to be frozen [v7]

2024-05-01 Thread Undecium
On Thu, 7 Mar 2024 22:32:13 GMT, Marius Hanl wrote: >> This PR fixes the dialog freeze problem once and for all. >> >> This one is a bit tricky to understand, here is how it works: >> This bug happens on every platform, although the implementation of nested >> event loops differs on every plat

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v10]

2024-05-01 Thread Thiago Milczarek Sayao
> Wayland implementation will require EGL. > > EGL works with Xorg as well. The idea is to be EGL first and if it fails, > fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. > > > See: > [Switching the Linux graphics stack from GLX to > EGL](https://mozillagfx.wordpress.com

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v9]

2024-05-01 Thread Thiago Milczarek Sayao
> Wayland implementation will require EGL. > > EGL works with Xorg as well. The idea is to be EGL first and if it fails, > fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. > > > See: > [Switching the Linux graphics stack from GLX to > EGL](https://mozillagfx.wordpress.com

Integrated: 8325591: [Mac] DRAG_DONE reports null transferMode when destination is external

2024-05-01 Thread Martin Fox
On Fri, 16 Feb 2024 22:35:49 GMT, Martin Fox wrote: > At the end of a drag operation the Mac Glass code sends out a DRAG_DONE event > using the operation mask tracked in the GlassDragSource to determine the > final transfer mode. That mask is only updated when a window in the JavaFX > app is t

Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v24]

2024-05-01 Thread Kevin Rushforth
On Mon, 29 Apr 2024 17:53:50 GMT, Ambarish Rapte wrote: >> I applied the software engineering principle to leave the code cleaner than >> seen. (Martin Fowler et all) >> >> Should I revert this? > > Sorry for not being clear. I just wanted to point out that it is not required > for the issue

Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v25]

2024-05-01 Thread Kevin Rushforth
On Wed, 1 May 2024 04:46:29 GMT, Oliver Kopp wrote: >> Fixes https://bugs.openjdk.org/browse/JDK-8330462. >> >> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, >> then an addition of `start` to it leads to a negative value. This is "fixed" >> by using `Math.max` compar