> Improves performance of selector matching in the CSS subsystem. This is done
> by using custom set implementation which are highly optimized for the most
> common cases where the number of selectors is small (most commonly 1 or 2).
> It also should be more memory efficient for medium sized and
On Sat, 9 Mar 2024 00:04:04 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Optimize performance of OpenAddressed Set just in case it is ever used
>
> modules/javafx.graphics/src/test/java/test
On Fri, 8 Mar 2024 23:46:16 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Optimize performance of OpenAddressed Set just in case it is ever used
>
> modules/javafx.graphics/src/main/java/com/
On Fri, 8 Mar 2024 23:26:05 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Optimize performance of OpenAddressed Set just in case it is ever used
>
> modules/javafx.graphics/src/main/java/com/
On Fri, 8 Mar 2024 23:17:28 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Optimize performance of OpenAddressed Set just in case it is ever used
>
> modules/javafx.graphics/src/main/java/com/
On Fri, 8 Mar 2024 23:14:12 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Optimize performance of OpenAddressed Set just in case it is ever used
>
> modules/javafx.graphics/src/main/java/com/
On Fri, 8 Mar 2024 18:08:15 GMT, Marius Hanl wrote:
> Tested with a big application, did not find any regression. All listeners
> still work as expected, tested especially a lot of 'if something is selected,
> this button should be enabled/disabled' and the like. I did not checked the
> code y
I think there is definitely room for improvement here, but I think most
controls can currently be build externally, if you are willing to do all
the work. Your control may suffer however when you need to integrate
with event, focus handling or keyboard navigation. Skins and Behaviors
are not
On Fri, 8 Mar 2024 16:10:26 GMT, Marius Hanl wrote:
>> This PR fixes a long standing issue where the `Tooltip` will always wait one
>> second until it appears the very first time, even if the
>> `-fx-show-delay` was set to another value.
>>
>> The culprit is, that the `cssForced` flag is not i
On Sun, 25 Feb 2024 22:28:12 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>>
On Fri, 8 Mar 2024 16:10:26 GMT, Marius Hanl wrote:
>> This PR fixes a long standing issue where the `Tooltip` will always wait one
>> second until it appears the very first time, even if the
>> `-fx-show-delay` was set to another value.
>>
>> The culprit is, that the `cssForced` flag is not i
On Fri, 8 Mar 2024 16:10:26 GMT, Marius Hanl wrote:
>> This PR fixes a long standing issue where the `Tooltip` will always wait one
>> second until it appears the very first time, even if the
>> `-fx-show-delay` was set to another value.
>>
>> The culprit is, that the `cssForced` flag is not i
On Fri, 8 Mar 2024 16:10:26 GMT, Marius Hanl wrote:
>> This PR fixes a long standing issue where the `Tooltip` will always wait one
>> second until it appears the very first time, even if the
>> `-fx-show-delay` was set to another value.
>>
>> The culprit is, that the `cssForced` flag is not i
On Fri, 8 Mar 2024 16:10:26 GMT, Marius Hanl wrote:
>> This PR fixes a long standing issue where the `Tooltip` will always wait one
>> second until it appears the very first time, even if the
>> `-fx-show-delay` was set to another value.
>>
>> The culprit is, that the `cssForced` flag is not i
Daniel:
Thank you, both the PR and the code have been updated.
This change provides an illustration of the problem we have with JavaFX - it is
nearly impossible to talk about custom skin development when most of the
essential machinery is hidden behind accessors and non-public classes. In this
> Adds **Labeled.textTruncated** property which indicates when the text is
> visually truncated (and the ellipsis string is inserted) in order to fit the
> available width.
>
> The new property reacts to changes in the following properties:
> - ellipsisString
> - font
> - height
> - text
> - wid
* Offtopic: Maybe we should collect the things which should be public in
our opinion at one point to (better) get this started as well?
My sentiment exactly! Marius, would you like to create a new thread?
Thanks!
-andy
From: openjfx-dev on behalf of Marius Hanl
Date: Thursday, March 7,
On Wed, 10 Jan 2024 19:21:16 GMT, Marius Hanl wrote:
> This PR fixes the border glitch/gap as explained in both linked tickets.
>
> I noted that the `ScrollPane` control does not suffer from this problem,
> although the code is mostly the same as in `VirtualFlow`. The `ScrollPane`
> snaps the
On Fri, 9 Jun 2023 12: 00: 06 GMT, John Hendrikx wrote: >> This provides and uses a new implementation of `ExpressionHelper`, called `ListenerManager` with improved semantics. >> >> # Behavior >>
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
On Sun, 25 Feb 2024 22: 28: 12 GMT, John Hendrikx wrote: >> Improves performance of selector matching in the CSS subsystem. This is done by using custom set implementation which are highly optimized for the
ZjQcmQRYFpfptBannerStart
This Message Is From an External Send
On Tue, 3 Oct 2023 19: 10: 14 GMT, Andy Goryachev wrote: > Summary: > - public InputMap, KeyBinding, BehaviorBase in javafx. scene. control. behavior package > - InputMap allows for adding key mappings on control
ZjQcmQRYFpfptBannerStart
This Message Is From an Externa
On Wed, 28 Feb 2024 23:43:40 GMT, Kevin Rushforth wrote:
> This seems like a reasonable fix and spec change. Have you tested the case of
> calling sizeToScene before setting full-screen or maximzed? Since the pending
> flag will still be set in that case, I want to make sure that case is tested
> This PR fixes the problem that maximizing/fullscreen a `Stage` or `Dialog` is
> broken when `sizeToScene()` was called before or after.
>
> The approach here is to ignore the `sizeToScene()` request when the `Stage`
> is maximized or set to fullscreen.
> Otherwise the Window Manager of the OS
> This PR fixes a long standing issue where the `Tooltip` will always wait one
> second until it appears the very first time, even if the
> `-fx-show-delay` was set to another value.
>
> The culprit is, that the `cssForced` flag is not inside `Tooltip`, but inside
> the `TooltipBehaviour`. So t
This PR fixes a long standing issue where the `Tooltip` will always wait one
second until it appears the very first time, even if the
`-fx-show-delay` was set to another value.
The culprit is, that the `cssForced` flag is not inside `Tooltip`, but inside
the `TooltipBehvaiour`. So the very firs
On Fri, 8 Mar 2024 10:18:21 GMT, Johan Vos wrote:
> Hi all,
>
> This pull request contains a backport of commit 64af9875 from the openjdk/jfx
> repository.
>
> The commit being backported was authored by Hima Bindu Meda on 7 Mar 2024 and
> was reviewed by Kevin Rushforth and Jose Pereda.
>
>
Hi all,
This pull request contains a backport of commit 64af9875 from the openjdk/jfx
repository.
The commit being backported was authored by Hima Bindu Meda on 7 Mar 2024 and
was reviewed by Kevin Rushforth and Jose Pereda.
Thanks!
-
Commit messages:
- Backport 64af987576214fc5
On Fri, 8 Mar 2024 10:13:27 GMT, Johan Vos wrote:
> Hi all,
>
> This pull request contains a backport of commit 64af9875 from the openjdk/jfx
> repository.
>
> The commit being backported was authored by Hima Bindu Meda on 7 Mar 2024 and
> was reviewed by Kevin Rushforth and Jose Pereda.
>
>
Hi all,
This pull request contains a backport of commit 64af9875 from the openjdk/jfx
repository.
The commit being backported was authored by Hima Bindu Meda on 7 Mar 2024 and
was reviewed by Kevin Rushforth and Jose Pereda.
Thanks!
-
Commit messages:
- Backport 64af987576214fc5
On Fri, 8 Mar 2024 10:09:53 GMT, Johan Vos wrote:
> 8325258: Additional WebKit 617.1 fixes from WebKitGTK 2.42.5
This pull request has now been integrated.
Changeset: eb922637
Author:Johan Vos
URL:
https://git.openjdk.org/jfx17u/commit/eb9226375bdaa2edc0976d51f34337721ef0c9bb
Stats:
8325258: Additional WebKit 617.1 fixes from WebKitGTK 2.42.5
-
Commit messages:
- Backport a7f6de8d13fd7a7e37ca80b28badcb24566153d8
Changes: https://git.openjdk.org/jfx17u/pull/186/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=186&range=00
Issue: https://bugs.openjdk.
On Fri, 8 Mar 2024 10:03:29 GMT, Johan Vos wrote:
> 8325258: Additional WebKit 617.1 fixes from WebKitGTK 2.42.5
This pull request has now been integrated.
Changeset: b0ed455c
Author:Johan Vos
URL:
https://git.openjdk.org/jfx21u/commit/b0ed455c3bdb60b18427f568c609a89a8e88b4ed
Stats:
8325258: Additional WebKit 617.1 fixes from WebKitGTK 2.42.5
-
Commit messages:
- Backport a7f6de8d13fd7a7e37ca80b28badcb24566153d8
Changes: https://git.openjdk.org/jfx21u/pull/52/files
Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=52&range=00
Issue: https://bugs.openjdk.or
On Fri, 8 Mar 2024 10:01:26 GMT, Johan Vos wrote:
> 8324337: Cherry-pick WebKit 617.1 stabilization fixes
This pull request has now been integrated.
Changeset: 426f4eb0
Author:Johan Vos
URL:
https://git.openjdk.org/jfx17u/commit/426f4eb0001e9d1c747df0951446030c3d0adcec
Stats: 12
8324337: Cherry-pick WebKit 617.1 stabilization fixes
-
Commit messages:
- Backport 52840a17dee6a92fb9b1f3ff1b314b0ae228b95f
Changes: https://git.openjdk.org/jfx17u/pull/185/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=185&range=00
Issue: https://bugs.openjdk.org/bro
On Fri, 8 Mar 2024 09:29:55 GMT, Johan Vos wrote:
> 8324337: Cherry-pick WebKit 617.1 stabilization fixes
This pull request has now been integrated.
Changeset: eec2c96b
Author:Johan Vos
URL:
https://git.openjdk.org/jfx21u/commit/eec2c96b8d35b65d6090496451114b00c9ecd3ca
Stats: 12
8324337: Cherry-pick WebKit 617.1 stabilization fixes
-
Commit messages:
- Backport 52840a17dee6a92fb9b1f3ff1b314b0ae228b95f
Changes: https://git.openjdk.org/jfx21u/pull/51/files
Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=51&range=00
Issue: https://bugs.openjdk.org/brows
On Fri, 8 Mar 2024 09:09:37 GMT, Johan Vos wrote:
> Hi all,
>
> This pull request contains a backport of commit 8114559e from the openjdk/jfx
> repository.
>
> The commit being backported was authored by Johan Vos on 4 Mar 2024 and was
> reviewed by Kevin Rushforth.
>
> Thanks!
This pull re
Hi all,
This pull request contains a backport of commit 8114559e from the openjdk/jfx
repository.
The commit being backported was authored by Johan Vos on 4 Mar 2024 and was
reviewed by Kevin Rushforth.
Thanks!
-
Commit messages:
- Backport 8114559ed666fe272d238cdf1e531e5d8ec222
On Thu, 7 Mar 2024 11:28:01 GMT, Johan Vos wrote:
> Almost clean backport of JDK-8318386.
> The original patch contains a fix to gstaacparse.c which is not in jfx17u
> because it does not have JDK-8277309 (JDK-8277309)
This pull request has now been integrated.
Changeset: 34922457
Author:J
On Thu, 7 Mar 2024 11:32:29 GMT, Johan Vos wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [ba79e081](https://github.com/openjdk/jfx/commit/ba79e081547b7f15697bfaaac42ec2de1971935a)
> from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
>
> The commit being b
On Thu, 7 Mar 2024 11:03:42 GMT, Johan Vos wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [ba79e081](https://github.com/openjdk/jfx/commit/ba79e081547b7f15697bfaaac42ec2de1971935a)
> from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
>
> The commit being b
Andy, Marius, all,
Thank you for your input and your insights.
If I understand correctly we cannot purely do it with public methods for
now (at least not for TableCells)
This makes the argument to support https://github.com/openjdk/jfx/pull/1389
even stronger and maybe should be mentioned in the
43 matches
Mail list logo
