On Thu, 11 Jan 2024 00:20:19 GMT, John Hendrikx wrote:
>> No, the explicit goal of this construction is to set active to false (in
>> case it exists) so that existing listeners can be released; followed by
>> creating a new active property that is by default set to true until
>> `setMenus` is
On Mon, 4 Mar 2024 19:26:37 GMT, Jose Pereda wrote:
>> Johan Vos has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains 11 additional commits
>> since
On Sat, 24 Feb 2024 17:38:11 GMT, Marius Hanl wrote:
>> `TreeTableRow` does not check the item with `isItemChanged(..)`, unlike all
>> other implementations of the cell.
>>
>> This also means that the `TreeTableRow` always updates the item, although it
>> should not, resulting in a performance
On Tue, 9 Jan 2024 07:31:51 GMT, Karthik P K wrote:
> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation
> conditions were not considered, hence hit test values such as character index
> and insertion index values were incorrect.
>
> Added checks for RTL orientation of nodes
On Thu, 29 Feb 2024 23:56:06 GMT, Andy Goryachev wrote:
>> Adding `@SuppressWarnings("doclint:missing")` to the lines in Serializable
>> classes that generated javadoc's "missing comments" warning.
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since
On Fri, 1 Mar 2024 17:11:00 GMT, Kevin Rushforth wrote:
>> FYI: after merging this and #1384 together all I see in the build log are 4
>> native warnings (on macOS):
>>
>>
>> /Users/angorya/Projects/jfx-1/jfx/rt/modules/javafx.graphics/src/main/native-prism-es2/macosx/MacOSXWindowSystemInterfa
Adds Labeled.truncated property which indicates when the text is visually
truncated (and the ellipsis string is inserted) in order to fit the available
width.
The new property reacts to changes in the following properties:
- ellipsisString
- font
- text
- width
- wrapText
For some reason, line
On Tue, 27 Feb 2024 09:30:14 GMT, Johan Vos wrote:
>> A listener was added but never removed.
>> This patch removes the listener when the menu it links to is cleared. Fix
>> for https://bugs.openjdk.org/browse/JDK-8319779
>
> Johan Vos has updated the pull request with a new target base due to a
> This PR fixes the dialog freeze problem once and for all.
>
> This one is a bit tricky to understand, here is how it works:
> This bug happens on every platform, although the implementation of nested
> event loops differs on every platform.
> E.g. on Linux we use `gtk_main` and `gtk_main_quit`
On Fri, 1 Mar 2024 23:56:19 GMT, Martin Fox wrote:
> The top of the call stack when the exception is thrown:
Yeah, had the same issue and fixed it locally. Now pushed. Problem as stated
above remains though
-
PR Comment: https://git.openjdk.org/jfx/pull/1324#issuecomment-197726514
> This PR fixes the dialog freeze problem once and for all.
>
> This one is a bit tricky to understand, here is how it works:
> This bug happens on every platform, although the implementation of nested
> event loops differs on every platform.
> E.g. on Linux we use `gtk_main` and `gtk_main_quit`
On Mon, 4 Mar 2024 17:13:01 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 1044:
>>
>>> 1042: private int findFirstRunStart() {
>>> 1043: int start = Integer.MAX_VALUE;
>>> 1044: for (GlyphList r: getRuns()) {
>>
>> the ol
On Mon, 4 Mar 2024 11:03:26 GMT, Karthik P K wrote:
>> @andy-goryachev-oracle The coverage comes from EclEmma, an Eclipse plugin.
>> Once installed, there is another way to run tests called `Coverage as...`
>> just above `Run as...`. It's very useful to use it on a JUnit test to see
>> if th
On Mon, 4 Mar 2024 11:01:09 GMT, Karthik P K wrote:
>> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation
>> conditions were not considered, hence hit test values such as character
>> index and insertion index values were incorrect.
>>
>> Added checks for RTL orientation of
On Mon, 4 Mar 2024 16:15:02 GMT, Andy Goryachev wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add unit test
>
> modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 1044:
>
>> 1042: private
On Mon, 4 Mar 2024 11:01:09 GMT, Karthik P K wrote:
>> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation
>> conditions were not considered, hence hit test values such as character
>> index and insertion index values were incorrect.
>>
>> Added checks for RTL orientation of
On Mon, 4 Mar 2024 16:12:12 GMT, Andy Goryachev wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add unit test
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/scene/text/TextLayout.java
> line 108:
>
>> 10
On Mon, 4 Mar 2024 11:01:09 GMT, Karthik P K wrote:
>> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation
>> conditions were not considered, hence hit test values such as character
>> index and insertion index values were incorrect.
>>
>> Added checks for RTL orientation of
On Mon, 4 Mar 2024 11:07:07 GMT, Johan Vos wrote:
> Explicitly remove old global ref value from menu->jCallback.
> This avoids the possibility of that value (which can be reused for other
> refs) to be deleted twice.
This pull request has now been integrated.
Changeset: 8114559e
Author:Joh
On Mon, 4 Mar 2024 11:07:07 GMT, Johan Vos wrote:
> Explicitly remove old global ref value from menu->jCallback.
> This avoids the possibility of that value (which can be reused for other
> refs) to be deleted twice.
Updated title looks good. Thanks.
-
PR Comment: https://git.open
On Mon, 4 Mar 2024 11:07:07 GMT, Johan Vos wrote:
> Explicitly remove old global ref value from menu->jCallback.
> This avoids the possibility of that value (which can be reused for other
> refs) to be deleted twice.
This is a safe fix that is clearly the right thing to do.
I recommend changin
On Sun, 3 Mar 2024 22:29:02 GMT, Nir Lisker wrote:
> Update for the 3D lighting test tool as described in the JBS issue.
Reviewer: @arapte
@jayathirthrao you might also want to take a look?
-
PR Comment: https://git.openjdk.org/jfx/pull/1387#issuecomment-1976604084
Explicitly remove old global ref value from menu->jCallback.
This avoids the possibility of that value (which can be reused for other refs)
to be deleted twice.
-
Commit messages:
- Explicitly remove old global ref value from menu->jCallback.
Changes: https://git.openjdk.org/jfx/pu
On Thu, 29 Feb 2024 17:33:14 GMT, John Hendrikx wrote:
>> @hjohn how do you get this coverage diagram?
>>
>> The BreakIterator is a part of the existing code, we should probably have
>> this discussion outside of this PR. I agree, there might be a situation
>> when the app wants to select a s
On Thu, 29 Feb 2024 12:12:01 GMT, John Hendrikx wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 1031:
>
>> 1029: if
> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation
> conditions were not considered, hence hit test values such as character index
> and insertion index values were incorrect.
>
> Added checks for RTL orientation of nodes and fixed the issue in
> `getHitInfo()` to calculat
I second what John and Michael say (provide more APIs in OpenJFX that can
only realistically be implemented in OpenJFX).
I believe the experience from Robert as the creator of ValidatorFX is
extremely valuable to this. The key question that might help to see what we
need here is: "What would have
Am 04.03.24 um 10:01 schrieb Michael Strauß:
I would not be in favor of adding any particular data validation
framework to JavaFX. Data validation comes in all kinds of different
shapes and sizes, which makes it a good fit for (opinionated)
third-party libraries.
I agree with that while at th
I would not be in favor of adding any particular data validation
framework to JavaFX. Data validation comes in all kinds of different
shapes and sizes, which makes it a good fit for (opinionated)
third-party libraries. However, I fully agree with John that JavaFX
should provide more APIs that can o
29 matches
Mail list logo
