Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v13]

2024-02-25 Thread Karthik P K
On Sat, 24 Feb 2024 22:44:05 GMT, John Hendrikx wrote: > The character index, even in your example image above, seems to be relative > to the `Text`, not to the `TextFlow` (it is 0, even though there are clearly > 10 characters before it belonging to another `Text`), so what exactly do you > m

Re: RFR: JDK-8322964 Optimize performance of CSS selector matching [v5]

2024-02-25 Thread John Hendrikx
> Improves performance of selector matching in the CSS subsystem. This is done > by using custom set implementation which are highly optimized for the most > common cases where the number of selectors is small (most commonly 1 or 2). > It also should be more memory efficient for medium sized and

Re: RFR: JDK-8322964 Optimize performance of CSS selector matching [v4]

2024-02-25 Thread John Hendrikx
> Improves performance of selector matching in the CSS subsystem. This is done > by using custom set implementation which are highly optimized for the most > common cases where the number of selectors is small (most commonly 1 or 2). > It also should be more memory efficient for medium sized and

Re: RFR: JDK-8322964 Optimize performance of CSS selector matching [v4]

2024-02-25 Thread John Hendrikx
On Mon, 15 Jan 2024 20:48:54 GMT, Michael Strauß wrote: >> @mstr2 I've created #1333 to show how it would look when we move >> `SimpleSelector` and `CompoundSelector` to internal packages. I think that >> should alleviate most concerns, and we can either integrate this first with >> a new pub

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v3]

2024-02-25 Thread Jose Pereda
On Sat, 24 Feb 2024 17:34:54 GMT, Thiago Milczarek Sayao wrote: >> I've just reverted the previous changes, and just applied the touch mask to >> the `gdk_pointer_grab` function. Tests should be green now. > > @jperedadnr Would you confirm that scroll on a touch screen still works on > Xorg ?

Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v13]

2024-02-25 Thread John Hendrikx
On Wed, 21 Feb 2024 10:01:37 GMT, Karthik P K wrote: >> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation >> conditions were not considered, hence hit test values such as character >> index and insertion index values were incorrect. >> >> Added checks for RTL orientation of